fix(@tarojs/components): 循环依赖 #17936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17936 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 417 417
Lines 21693 21693
Branches 5352 5359 +7
=======================================
Hits 11928 11928
- Misses 8245 8253 +8
+ Partials 1520 1512 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
""" Walkthrough本次变更将 Changes
Suggested reviewers
Poem
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningspackages/taroize/src/wxml.ts (4)🪛 Biome (1.9.4)packages/taroize/src/wxml.ts[error] 456-456: Change to an optional chain. Unsafe fix: Change to an optional chain. (lint/complexity/useOptionalChain) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (13)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yoyo837
reviewed
Jul 1, 2025
| "loader", | ||
| "mini", | ||
| "types", | ||
| "virtual-list", |
Contributor
Author
There was a problem hiding this comment.
代码库搜索到的virtual-list都是@tarojs/components-advanced导出的，文档中搜到的也是，除非是taro3的文档
yoyo837
reviewed
Jul 2, 2025
yoyo837
reviewed
Jul 2, 2025
packages/taro-components-advanced/src/components/virtual-list/index.ts
Outdated
Show resolved
Hide resolved
yoyo837
reviewed
Jul 2, 2025
packages/taro-components-advanced/src/components/virtual-list/index.ts
Outdated
Show resolved
Hide resolved
…index.ts Co-authored-by: Amumu <[email protected]>
Contributor
|
这样直接从 |
Contributor
Author
你是说它可能会生成 |
Contributor
是的 |
Contributor
Author
已添加处理逻辑 |
This was referenced Jul 5, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/taroize/src/wxml.ts (1)
360-363: 避免在库代码中直接使用console.log这里用于输出编译警告，但运行时依然会打印到用户终端，污染日志：
console.log(`属性 ${nodeName}不能编译，会被替换为 wx:if`)建议统一改为项目封装的日志函数
printLog或移除，保持日志输出的一致性与可控性。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/taroize/src/script.ts(11 hunks)packages/taroize/src/wxml.ts(35 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/taroize/src/script.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中，必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taroize/src/wxml.ts (4)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中，必须禁用 treeshake 来保留 dom-external/index.js 文件。
Learnt from: Single-Dancer
PR: NervJS/taro#17653
File: packages/taro-components-advanced/src/components/water-flow/node.ts:83-95
Timestamp: 2025-05-06T06:55:44.077Z
Learning: 在 Taro 的 getRectSizeSync 函数中，如果找不到指定的节点，函数会一直处于 pending 状态而不是抛出错误。在这种情况下，使用 try/catch 处理不够充分，需要添加超时处理如 Promise.race 来避免无限等待。
Learnt from: Single-Dancer
PR: NervJS/taro#17653
File: packages/taro-components-advanced/src/components/water-flow/node.ts:83-95
Timestamp: 2025-05-06T06:55:44.077Z
Learning: 在 Taro 的 water-flow 组件中，getRectSizeSync 函数如果找不到指定的节点，会一直处于 pending 状态而不是抛出错误。在这种情况下，应该使用 Promise.race 添加超时机制，而不是仅依赖 try/catch 来处理错误。
Learnt from: Single-Dancer
PR: NervJS/taro#17653
File: packages/taro-components-advanced/src/components/water-flow/node.ts:83-95
Timestamp: 2025-05-06T06:55:44.077Z
Learning: 在 Taro 的 water-flow 组件中，getRectSizeSync 函数如果找不到指定的节点并且重试次数用尽，会一直处于 pending 状态而不是抛出错误，因为它在 retryTimes <= 0 时直接返回而不 resolve 或 reject Promise。应该使用 Promise.race 添加超时机制来解决这个问题。
🪛 Biome (1.9.4)
packages/taroize/src/wxml.ts
[error] 456-456: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
- GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
- GitHub Check: Build Rust WASM / stable - wasm32-wasi
- GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-gnu
- GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
yoyo837
approved these changes
Jul 8, 2025
This was referenced Jul 12, 2025
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么？ (简要描述所做更改)
删除 @tarojs/components 的 virtual-list 导出，解决循环依赖
这个 PR 是什么类型？ (至少选择一个)
这个 PR 涉及以下平台：
Summary by CodeRabbit