-
Notifications
You must be signed in to change notification settings - Fork 4.9k
修复picker-view-column在taro4不生效 #17884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
""" Walkthrough本次更改简化了 Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant TemplateEngine
App->>TemplateEngine: 渲染 picker-view 结构
TemplateEngine->>TemplateEngine: 调用 modifyLoopBody (直接返回子内容)
TemplateEngine->>TemplateEngine: 调用 modifyTemplateResult
alt 节点为 swiper-item
TemplateEngine-->>App: 返回空字符串
else 其他节点(如 picker-view-column)
TemplateEngine-->>App: 返回原始模板结果
end
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(未发现与已链接 issue 目标无关的代码更改) Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17884 +/- ##
========================================
Coverage 55.90% 55.90%
========================================
Files 417 417
Lines 21693 21693
Branches 5385 5352 -33
========================================
Hits 12127 12127
- Misses 7930 8061 +131
+ Partials 1636 1505 -131
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
这个 PR 做了什么? (简要描述所做更改)
问题是在删除基类模版中block后出现的。
根据issues中ycyeye说的方法做了修改。
辛苦看一下是否有问题,没问题尽快合并,着急用谢谢。
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit