Skip to content

Conversation

@rfourquet
Copy link
Contributor

No description provided.

@wbhart
Copy link
Contributor

wbhart commented Oct 14, 2019

Seems to cause test failures. Could you possibly look into why. Ignore all the failed builds with an exclamation mark, just look at the ones with an X.

@rfourquet
Copy link
Contributor Author

Seems to cause test failures

Ah yes thanks for checking, this was due to a last second change beforfe pushing.

@rfourquet
Copy link
Contributor Author

rfourquet commented Oct 15, 2019

More errors, some of them will be automatically fixed if #504 is merged. And maybe the other errors would be fixed by #496.

@wbhart
Copy link
Contributor

wbhart commented Oct 23, 2019

The Julia 1.2 errors seem to be real, so I don't think we should merge this yet until we understand why they are happening. Are they using == instead of isapprox?

@rfourquet
Copy link
Contributor Author

Yeah some errors look definitely real. I didn't investigate too closely, but something seems to have changed in some Julia versions in how reduce(vcat, ...) is handled. That's why I think #496 would solve the problem. If not, or if that PR doesn't get merged, I will look into changing the tests to make them pass.

@rfourquet
Copy link
Contributor Author

That's why I think #496 would solve the problem

Actually I think it will not, I will fix the problem here.

@thofma thofma closed this Dec 12, 2019
@thofma thofma reopened this Dec 12, 2019
@thofma thofma merged commit 5d3f830 into Nemocas:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants