-
-
Notifications
You must be signed in to change notification settings - Fork 38
feat: re-enabled inspector protocol handling #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[wip] code is unoptimised and ugly... we'll clean this up.
WIP: the code is a mess, but it's working now!
note: this is a hack to make it work - we should figure out a proper fix for this
edusperoni
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enabling Inspector protocol handling in core
inspector_modules.Previously, most of these protocols had c++ Agents selectively calling into the core dispatchers registered with the
__registerDomainDispatcher.With this change, we now pass all protocol messages to the registered domain dispatcher as long as it has a matching method. ie.
Network.enablewill call theenable()method on the Network domain dispatcher.Since the previous version selectively called these methods,
Network.enablewas only called from the domain dispatcher constructor, and never from the incoming protocol message (was handled in the c++ implementation instead). While that worked, it was limiting and required runtime changes whenever requiring a new protocol event handler...Core also tends to throw errors like:
One CSSDomainDebugger may be enabled at a timein theenablehandlers - these don't make sense with this new setup, because these will get called every time a devtools frontend connects and sends theCSS.enableprotocol message.To handle this, we'll refactor core, however for backwards compatibility these errors are automatically caught on the c++/v8 side.