From e935a61de5043ae2febd76b34963bcaba7049791 Mon Sep 17 00:00:00 2001
From: Igor Randjelovic <rigor789@gmail.com>
Date: Wed, 8 Sep 2021 19:42:47 +0200
Subject: [PATCH] fix(chrome-devtools): Elements tab

This partially reverts the fix from #1641 as it ends up never calling `m_backend->getDocument`.

This may bring back an issue from #1640 - though was unable to reproduce with latest everything.
---
 .../src/inspector/protocol/DOM.cpp            | 41 ++++++++-----------
 1 file changed, 18 insertions(+), 23 deletions(-)

diff --git a/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/protocol/DOM.cpp b/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/protocol/DOM.cpp
index ba2ee42c8..205d47801 100644
--- a/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/protocol/DOM.cpp
+++ b/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/protocol/DOM.cpp
@@ -1932,42 +1932,37 @@ void DomainDispatcherImpl::getDocument(const v8_crdtp::Dispatchable& dispatchabl
         errors->SetName("depth");
         in_depth = ValueConversions<int>::fromValue(depthValue, errors);
     }
-
     protocol::Value* pierceValue = params ? params->get("pierce") : nullptr;
     Maybe<bool> in_pierce;
     if (pierceValue) {
         errors->SetName("pierce");
         in_pierce = ValueConversions<bool>::fromValue(pierceValue, errors);
     }
-
     if (MaybeReportInvalidParams(dispatchable, *errors)) return;
     // Declare output parameters.
     std::unique_ptr<protocol::DOM::Node> out_root;
 
     std::unique_ptr<DomainDispatcher::WeakPtr> weak = weakPtr();
 
-    if (depthValue && pierceValue) {
-        //NOTE: in_depth & in_pierce are not used in the method getDocument, see in v8-dom-agent-impl.cpp:63
-        DispatchResponse response = m_backend->getDocument(std::move(in_depth),
-                                                           std::move(in_pierce), &out_root);
-        if (response.IsFallThrough()) {
-            channel()->FallThrough(dispatchable.CallId(), v8_crdtp::SpanFrom("DOM.getDocument"),
-                                   dispatchable.Serialized());
-            return;
-        }
-        if (weak->get()) {
-            std::vector<uint8_t> result;
-            if (response.IsSuccess()) {
-                v8_crdtp::cbor::EnvelopeEncoder envelope_encoder;
-                envelope_encoder.EncodeStart(&result);
-                result.push_back(v8_crdtp::cbor::EncodeIndefiniteLengthMapStart());
-                v8_crdtp::SerializeField(v8_crdtp::SpanFrom("root"), out_root, &result);
-                result.push_back(v8_crdtp::cbor::EncodeStop());
-                envelope_encoder.EncodeStop(&result);
-            }
-            weak->get()->sendResponse(dispatchable.CallId(), response,
-                                      v8_crdtp::Serializable::From(std::move(result)));
+    DispatchResponse response = m_backend->getDocument(std::move(in_depth),
+                                                        std::move(in_pierce), &out_root);
+    if (response.IsFallThrough()) {
+        channel()->FallThrough(dispatchable.CallId(), v8_crdtp::SpanFrom("DOM.getDocument"),
+                                dispatchable.Serialized());
+        return;
+    }
+    if (weak->get()) {
+        std::vector<uint8_t> result;
+        if (response.IsSuccess()) {
+            v8_crdtp::cbor::EnvelopeEncoder envelope_encoder;
+            envelope_encoder.EncodeStart(&result);
+            result.push_back(v8_crdtp::cbor::EncodeIndefiniteLengthMapStart());
+            v8_crdtp::SerializeField(v8_crdtp::SpanFrom("root"), out_root, &result);
+            result.push_back(v8_crdtp::cbor::EncodeStop());
+            envelope_encoder.EncodeStop(&result);
         }
+        weak->get()->sendResponse(dispatchable.CallId(), response,
+                                    v8_crdtp::Serializable::From(std::move(result)));
     }
     return;
 }