Skip to content

Fix Issue #10286 window material shade mis-alignment for Output:Constructions #10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myoldmopar merged 6 commits into from
Nov 18, 2024
Merged

Fix Issue #10286 window material shade mis-alignment for Output:Constructions #10750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb5747a
Fix Issue #10286 window material shade eio write-out typo.
jcyuan2020 Oct 30, 2023
735a4bc
Merge remote-tracking branch 'remotes/origin/develop' into Y1_fix_win…
mjwitte Oct 21, 2024
285a086
Output rules
mjwitte Oct 21, 2024
89b382c
Merge develop, resolve conflict, try using PAT for PR commenting
Myoldmopar Nov 13, 2024
c5bdf65
Add separate failure step for forked repos with regressions
Myoldmopar Nov 14, 2024
0bdd8b4
Merge remote-tracking branch 'upstream/develop' into Y1_fix_window_ma…
Myoldmopar Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test_pull_requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,14 @@ jobs:
${{ steps.upload_regressions.outputs.artifact-url }}

- uses: actions/github-script@v7
if: always() && matrix.run_regressions && steps.regressions.outcome == 'failure'
if: always() && matrix.run_regressions && steps.regressions.outcome == 'failure' && github.event.pull_request.head.repo.full_name == 'NREL/EnergyPlus'
with:
script: |
const script = require('${{ github.workspace }}/regressions/summary.js')
console.log(script({github, context}))

- name: Fail on Regressions from Forked Repository
if: always() && matrix.run_regressions && steps.regressions.outcome == 'failure' && github.event.pull_request.head.repo.full_name != 'NREL/EnergyPlus'
run: |
echo "::error::Regressions detected in pull request from forked repository, check job summary for details and to download regression results"
exit 1
2 changes: 1 addition & 1 deletion src/EnergyPlus/WindowManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6980,7 +6980,7 @@ namespace Window {
auto const *matShade = dynamic_cast<Material::MaterialShade const *>(mat);
assert(matShade != nullptr);

static constexpr std::string_view Format_703(" WindowMaterial:Shade,,{},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R}\n");
static constexpr std::string_view Format_703(" WindowMaterial:Shade,{},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R}\n");
print(state.files.eio,
Format_703,
matShade->Name,
Expand Down
5 changes: 5 additions & 0 deletions src/Transition/OutputRulesFiles/OutputChanges24-2-0-to-25-1-0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ This file documents the structural changes on the output of EnergyPlus that coul

This will eventually become a more structured file, but currently it isn't clear what format is best. As an intermediate solution, and to allow the form to be formed organically, this plain text file is being used. Entries should be clearly delimited. It isn't expected that there will be but maybe a couple each release at most. Entries should also include some reference back to the repo. At least a PR number or whatever.

### Output:Constructions for WindowMaterial:Shade
Data for Output:Constructions for WindowMaterial:Shade were misaligned with the column headings in the eio output and the table Initialization Summary report. Data has shifted one column to the left.

See PR [#10750](https://github.com/NREL/EnergyPlus/pull/10750)

### Table Output, Sizing Output, and Output:Variable Spelling Corrections
* "Equipment Summary" table report, sub-table "VAV DX Cooling Standard Rating Details", column heading, "Assocated Fan" --> "Associated Fan".

Expand Down