Merge pull request #11104 from NREL/11061MissingNodesinWaterHeaterMixedErrorMessageLevel

Correct Error Message Level when Node Types are Undefined

Author: Myoldmopar

src/EnergyPlus/SimulationManager.cc

@@ -2192,6 +2192,7 @@ namespace SimulationManager {
         static constexpr std::string_view Format_723 =
             "! <Zone Equipment Component>,<Component Count>,<Component Type>,<Component Name>,<Zone Name>,<Heating "
             "Priority>,<Cooling Priority>";
+        bool nodeConnectionErrorFlag = false;
 
         // Report outside air node names on the Branch-Node Details file
         print(state.files.bnd, "{}\n", "! ===============================================================");
@@ -2256,12 +2257,13 @@ namespace SimulationManager {
                                      "been retrieved.");
                     state.dataSimulationManager->WarningOut = false;
                 }
-                ShowWarningError(
+                ShowSevereError(
                     state,
                     format("Potential Node Connection Error for object {}, name={}", CType, state.dataBranchNodeConnections->CompSets(Count).CName));
                 ShowContinueError(state, "  Node Types are still UNDEFINED -- See Branch/Node Details file for further information");
                 ShowContinueError(state, format("  Inlet Node : {}", state.dataBranchNodeConnections->CompSets(Count).InletNodeName));
                 ShowContinueError(state, format("  Outlet Node: {}", state.dataBranchNodeConnections->CompSets(Count).OutletNodeName));
+                nodeConnectionErrorFlag = true;
                 ++state.dataBranchNodeConnections->NumNodeConnectionErrors;
             }
         }
@@ -2723,6 +2725,10 @@ namespace SimulationManager {
         }
 
         state.dataErrTracking->AskForConnectionsReport = false;
+
+        if (nodeConnectionErrorFlag) {
+            ShowFatalError(state, "Please see severe error(s) and correct either the branch nodes or the component nodes so that they match.");
+        }
     }
 
     void PostIPProcessing(EnergyPlusData &state)

testfiles/ASHRAE901_OfficeSmall_STD2019_Denver.idf

@@ -5257,7 +5257,11 @@
     1.205980747,             !- On Cycle Loss Coefficient to Ambient Temperature {W/K}
     ,                        !- On Cycle Loss Fraction to Zone
     4.048e-06,               !- Peak Use Flow Rate {m3/s}
-    BLDG_SWH_SCH;            !- Use Flow Rate Fraction Schedule Name
+    BLDG_SWH_SCH,            !- Use Flow Rate Fraction Schedule Name
+    ,                        !- Cold Water Supply Temperature Schedule Name
+    SHWSys1 Pump-SHWSys1 Water HeaterNode, !- Use Side Inlet Node Name
+    SHWSys1 Supply Equipment Outlet Node;  !- Use Side Outlet Node Name
+
 
 !-   ===========  ALL OBJECTS IN CLASS: PLANTLOOP ===========
 

tst/EnergyPlus/unit/SimulationManager.unit.cc

@@ -50,6 +50,7 @@
 
 // EnergyPlus Headers
 #include "Fixtures/EnergyPlusFixture.hh"
+#include <EnergyPlus/DataBranchNodeConnections.hh>
 #include <EnergyPlus/DataEnvironment.hh>
 #include <EnergyPlus/DataGlobals.hh>
 #include <EnergyPlus/DataReportingFlags.hh>
@@ -551,3 +552,34 @@ TEST_F(EnergyPlusFixture, Test_SimulationControl_PureLoadCalc)
 
     EXPECT_TRUE(compare_err_stream(error_string, true));
 }
+
+TEST_F(EnergyPlusFixture, SimulationManager_ReportLoopConnectionsTest)
+{
+    // Unit Test for Defect #11061: Test Error Message (modified level of message)
+    state->dataBranchNodeConnections->NumCompSets = 1;
+    state->dataBranchNodeConnections->CompSets.allocate(1);
+    state->dataBranchNodeConnections->CompSets(1).ParentObjectType = DataLoopNode::ConnectionObjectType::WaterHeaterMixed;
+    state->dataBranchNodeConnections->CompSets(1).ComponentObjectType = DataLoopNode::ConnectionObjectType::WaterHeaterMixed;
+    state->dataBranchNodeConnections->CompSets(1).CName = "WaterHeaterMixed1";
+    state->dataBranchNodeConnections->CompSets(1).ParentObjectType == DataLoopNode::ConnectionObjectType::Undefined;
+    state->dataBranchNodeConnections->CompSets(1).InletNodeName = "MixedWaterHeater1Inlet";
+    state->dataBranchNodeConnections->CompSets(1).OutletNodeName = "MixedWaterHeater1Outlet";
+    state->dataSimulationManager->WarningOut = false;
+    state->dataBranchNodeConnections->CompSets(1).Description = "UNDEFINED";
+
+    EXPECT_THROW(EnergyPlus::SimulationManager::ReportLoopConnections(*state), std::runtime_error);
+
+    std::string const error_string = delimited_string({
+        "   ** Severe  ** Potential Node Connection Error for object WATERHEATER:MIXED, name=WaterHeaterMixed1",
+        "   **   ~~~   **   Node Types are still UNDEFINED -- See Branch/Node Details file for further information",
+        "   **   ~~~   **   Inlet Node : MixedWaterHeater1Inlet",
+        "   **   ~~~   **   Outlet Node: MixedWaterHeater1Outlet",
+        "   ************* There was 1 node connection error noted.",
+        "   **  Fatal  ** Please see severe error(s) and correct either the branch nodes or the component nodes so that they match.",
+        "   ...Summary of Errors that led to program termination:",
+        "   ..... Reference severe error count=1",
+        "   ..... Last severe error=Potential Node Connection Error for object WATERHEATER:MIXED, name=WaterHeaterMixed1",
+    });
+
+    EXPECT_TRUE(compare_err_stream(error_string, true));
+}