Merge pull request #11366 from bigladder/Fix-9968-PIU-reheat-coil-node-connection-error

Fix 9968 - Remove Reheat Coil Air Inlet Node Name field from PIU objects

Author: mitchute

doc/input-output-reference/src/overview/group-air-distribution-equipment.tex

@@ -924,10 +924,6 @@ \subsubsection{Inputs}\label{inputs-7-000}
 
 The name of the HVAC system node to which the unit sends its outlet air. This should be one of the inlet air nodes of the zone which is being served.
 
-\paragraph{Field: Reheat Coil Air Inlet Node Name}\label{field-reheat-coil-air-inlet-node-name}
-
-The name of the HVAC system node which is the inlet node of the unit's heating coil. This is also the outlet node of the unit's fan.
-
 \paragraph{Field: Zone Mixer Name}\label{field-zone-mixer-name}
 
 The name of a zone mixer component (object: \hyperref[airloophvaczonemixer]{AirLoopHVAC:ZoneMixer}) which composes part of the unit. Note that some of the input for the mixer will duplicate input fields of the powered induction unit. One of the zone mixer inlet nodes should be the same as the supply air inlet node of the PIU; the other inlet node of the zone mixer should be the same as the secondary air inlet node of the PIU. The outlet node of the zone mixer should be the same as the inlet node of the PIU fan.
@@ -1186,10 +1182,6 @@ \subsubsection{Inputs}\label{inputs-8-000}
 
 The name of the HVAC system node to which the unit sends its outlet air. This should be one of the inlet air nodes of the zone which is being served.
 
-\paragraph{Field: Reheat Coil Air Inlet Node Name}\label{field-reheat-coil-air-inlet-node-name-1}
-
-The name of the HVAC system node which is the inlet node of the unit's heating coil. This is also the outlet node of the unit's zone mixer.
-
 \paragraph{Field: Zone Mixer Name}\label{field-zone-mixer-name-1}
 
 The name of an zone mixer component (object: \hyperref[airloophvaczonemixer]{AirLoopHVAC:ZoneMixer}) which composes part of the unit. Note that some of the input for the mixer will duplicate input fields of the powered induction unit. One of the zone mixer inlet nodes should be the same as the supply air inlet node of the PIU; the other inlet node of the zone mixer should be the same as the air outlet node of the fan. The outlet node of the zone mixer should be the same as the inlet node of the heating coil.

idd/Energy+.idd.in

@@ -48803,24 +48803,22 @@ AirTerminal:SingleDuct:SeriesPIU:Reheat,
        \type node
   A5,  \field Outlet Node Name
        \type node
-  A6,  \field Reheat Coil Air Inlet Node Name
-       \type node
-  A7,  \field Zone Mixer Name
+  A6,  \field Zone Mixer Name
        \type object-list
        \object-list ZoneMixers
-  A8,  \field Fan Name
+  A7,  \field Fan Name
        \note Fan type must be Fan:SystemModel or Fan:ConstantVolume
        \type object-list
        \object-list FansCV
        \object-list FansSystemModel
-  A9,  \field Reheat Coil Object Type
+  A8,  \field Reheat Coil Object Type
        \required-field
        \type choice
        \key Coil:Heating:Water
        \key Coil:Heating:Electric
        \key Coil:Heating:Fuel
        \key Coil:Heating:Steam
-  A10, \field Reheat Coil Name
+  A9,  \field Reheat Coil Name
        \required-field
        \type object-list
        \object-list HeatingCoilName
@@ -48841,7 +48839,7 @@ AirTerminal:SingleDuct:SeriesPIU:Reheat,
        \type real
        \minimum> 0.0
        \default 0.001
-  A11, \field Fan Control Type
+  A10, \field Fan Control Type
        \note If VariableSpeed, then the fan object type must be Fan:SystemModel
        \type choice
        \key VariableSpeed
@@ -48854,7 +48852,7 @@ AirTerminal:SingleDuct:SeriesPIU:Reheat,
        \minimum 0.0
        \maximum 1.0
        \default 0.3
-  A12, \field Heating Control Type
+  A11, \field Heating Control Type
        \type choice
        \key Staged
        \key Modulated
@@ -48916,25 +48914,22 @@ AirTerminal:SingleDuct:ParallelPIU:Reheat,
        \type node
   A5,  \field Outlet Node Name
        \type node
-  A6,  \field Reheat Coil Air Inlet Node Name
-       \type node
-       \note mixer outlet node
-  A7,  \field Zone Mixer Name
+  A6,  \field Zone Mixer Name
        \type object-list
        \object-list ZoneMixers
-  A8,  \field Fan Name
+  A7,  \field Fan Name
        \note Fan type must be Fan:SystemModel or Fan:ConstantVolume
        \type object-list
        \object-list FansCV
        \object-list FansSystemModel
-  A9,  \field Reheat Coil Object Type
+  A8,  \field Reheat Coil Object Type
        \required-field
        \type choice
        \key Coil:Heating:Water
        \key Coil:Heating:Electric
        \key Coil:Heating:Fuel
        \key Coil:Heating:Steam
-  A10, \field Reheat Coil Name
+  A9,  \field Reheat Coil Name
        \required-field
        \type object-list
        \object-list HeatingCoilName
@@ -48955,7 +48950,7 @@ AirTerminal:SingleDuct:ParallelPIU:Reheat,
        \type real
        \minimum> 0.0
        \default 0.001
-  A11, \field Fan Control Type
+  A10, \field Fan Control Type
        \note If VariableSpeed, then the fan object type must be Fan:SystemModel
        \type choice
        \key VariableSpeed
@@ -48968,7 +48963,7 @@ AirTerminal:SingleDuct:ParallelPIU:Reheat,
        \minimum 0.0
        \maximum 1.0
        \default 0.3
-  A12, \field Heating Control Type
+  A11, \field Heating Control Type
        \type choice
        \key Staged
        \key Modulated

src/EnergyPlus/PoweredInductionUnits.cc

@@ -381,29 +381,47 @@ void GetPIUs(EnergyPlusData &state)
                                                        ObjectIsParent,
                                                        "Outlet Node Name");
 
-                thisPIU.HCoilInAirNode = GetOnlySingleNode(state,
-                                                           ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_air_inlet_node_name"),
-                                                           ErrorsFound,
-                                                           connectionType,
-                                                           thisPIU.Name,
-                                                           DataLoopNode::NodeFluidType::Air,
-                                                           DataLoopNode::ConnectionType::Internal,
-                                                           NodeInputManager::CompFluidStream::Primary,
-                                                           ObjectIsParent,
-                                                           "Reheat Coil Air Inlet Node Name");
-                // The reheat coil control node is necessary for hot water reheat, but not necessary for
-                // electric or gas reheat.
-                if (thisPIU.HCoilType == HtgCoilType::SimpleHeating) {
+                // The reheat coil control node is necessary for hot water reheat, but not necessary for electric or gas reheat.
+                switch (thisPIU.HCoilType) {
+                case HtgCoilType::SimpleHeating: {
+                    thisPIU.HCoilInAirNode =
+                        WaterCoils::GetCoilInletNode(state,
+                                                     ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_object_type"),
+                                                     ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"),
+                                                     ErrorsFound);
+
                     thisPIU.HotControlNode = GetCoilWaterInletNode(state,
                                                                    ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_object_type"),
                                                                    ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"),
                                                                    ErrorsFound);
+                    break;
                 }
-                if (thisPIU.HCoilType == HtgCoilType::SteamAirHeating) {
+                case HtgCoilType::SteamAirHeating: {
+                    int SteamCoilIndex = SteamCoils::GetSteamCoilIndex(state,
+                                                                       ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_object_type"),
+                                                                       ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"),
+                                                                       ErrorsFound);
+                    thisPIU.HCoilInAirNode = SteamCoils::GetCoilAirInletNode(
+                        state, SteamCoilIndex, ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"), ErrorsFound);
+
                     thisPIU.HotControlNode = GetCoilSteamInletNode(state,
                                                                    ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_object_type"),
                                                                    ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"),
                                                                    ErrorsFound);
+                    break;
+                }
+                case HtgCoilType::Electric:
+                case HtgCoilType::Gas: {
+                    thisPIU.HCoilInAirNode =
+                        HeatingCoils::GetCoilInletNode(state,
+                                                       ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_object_type"),
+                                                       ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"),
+                                                       ErrorsFound);
+                    break;
+                }
+                default: {
+                    break;
+                }
                 }
                 thisPIU.MixerName = ip->getAlphaFieldValue(fields, objectSchemaProps, "zone_mixer_name");
                 thisPIU.FanName = ip->getAlphaFieldValue(fields, objectSchemaProps, "fan_name");
@@ -474,7 +492,7 @@ void GetPIUs(EnergyPlusData &state)
                                   "UNDEFINED",
                                   thisPIU.FanName,
                                   "UNDEFINED",
-                                  ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_air_inlet_node_name"));
+                                  state.dataLoopNodes->NodeID(thisPIU.HCoilInAirNode));
                 } else if (cCurrentModuleObject == "AirTerminal:SingleDuct:ParallelPIU:Reheat") {
                     SetUpCompSets(state,
                                   thisPIU.UnitType,
@@ -491,7 +509,7 @@ void GetPIUs(EnergyPlusData &state)
                               thisPIU.Name,
                               ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_object_type"),
                               ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_name"),
-                              ip->getAlphaFieldValue(fields, objectSchemaProps, "reheat_coil_air_inlet_node_name"),
+                              state.dataLoopNodes->NodeID(thisPIU.HCoilInAirNode),
                               ip->getAlphaFieldValue(fields, objectSchemaProps, "outlet_node_name"));
 
                 // Register component set data

src/ExpandObjects/epfilter.f90

@@ -9589,7 +9589,6 @@ SUBROUTINE CreateNewVAV
     END IF
     CALL AddToObjFld('Secondary Air Inlet Node Name', base + fpvzNameOff,' PIU Secondary Inlet')
     CALL AddToObjFld('Outlet Node Name', base + fpvzNameOff,' Supply Inlet')
-    CALL AddToObjFld('Reheat Coil Air Inlet Node Name', base + fpvzNameOff,' PIU Fan Outlet')
     CALL AddToObjFld('Zone Mixer Name', base + fpvzNameOff,' PIU Mixer')
     CALL AddToObjFld('Fan Name', base + fpvzNameOff,' PIU Fan')
     IF (reheatCoilType .EQ. ctHotWater) THEN
@@ -9627,7 +9626,6 @@ SUBROUTINE CreateNewVAV
     END IF
     CALL AddToObjFld('Secondary Air Inlet Node Name', base + fpvzNameOff,' PIU Secondary Inlet')
     CALL AddToObjFld('Outlet Node Name', base + fpvzNameOff,' Supply Inlet')
-    CALL AddToObjFld('Reheat Coil Air Inlet Node Name', base + fpvzNameOff,' PIU Mixer Outlet')
     CALL AddToObjFld('Zone Mixer Name', base + fpvzNameOff,' PIU Mixer')
     CALL AddToObjFld('Fan Name', base + fpvzNameOff,' PIU Fan')
     IF (reheatCoilType .EQ. ctHotWater) THEN

src/Transition/CreateNewIDFUsingRulesV26_1_0.f90

@@ -383,6 +383,21 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
 
               ! If your original object starts with A, insert the rules here
 
+              CASE('AIRTERMINAL:SINGLEDUCT:PARALLELPIU:REHEAT')
+                  CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
+                  nodiff=.false.
+                  OutArgs(1:9)=InArgs(1:9)
+                  ! InArgs(10) is deleted
+                  OutArgs(10:CurArgs-1)=InArgs(11:CurArgs)
+                  CurArgs = CurArgs - 1
+              CASE('AIRTERMINAL:SINGLEDUCT:SERIESPIU:REHEAT')
+                  CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
+                  nodiff=.false.
+                  OutArgs(1:8)=InArgs(1:8)
+                  ! InArgs(9) is deleted
+                  OutArgs(9:CurArgs-1)=InArgs(10:CurArgs)
+                  CurArgs = CurArgs - 1
+
               ! If your original object starts with C, insert the rules here
 
               ! If your original object starts with D, insert the rules here

src/Transition/InputRulesFiles/Rules25-2-0-to-26-1-0.md

@@ -12,6 +12,14 @@ The alpha/numeric A/N numbers are not as important here.
 
 # Object Change: ObjectStartsWithA
 
+# Object Change: AirTerminal:SingleDuct:ParallelPIU:Reheat
+# Object Change: AirTerminal:SingleDuct:SeriesPIU:Reheat
+
+Remove field A6 "Reheat Coil Air Inlet Node Name"
+Shift remaining alpha fields down 1 (i.e. A7-A12 now A6-A11)
+
+See pull request [#11366](https://github.com/NREL/EnergyPlus/pull/11366)
+
 # Object Change: ObjectStartsWithB
 
 # Object Change: ObjectStartsWithC

testfiles/5ZoneAirCooledConvCoef.idf

@@ -2426,7 +2426,6 @@
     SPACE1-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE1-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE1-1 In Node,        !- Outlet Node Name
-    SPACE1-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE1-1 PIU Mixer,      !- Zone Mixer Name
     SPACE1-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type
@@ -2479,7 +2478,6 @@
     SPACE2-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE2-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE2-1 In Node,        !- Outlet Node Name
-    SPACE2-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE2-1 PIU Mixer,      !- Zone Mixer Name
     SPACE2-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type
@@ -2531,7 +2529,6 @@
     SPACE3-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE3-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE3-1 In Node,        !- Outlet Node Name
-    SPACE3-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE3-1 PIU Mixer,      !- Zone Mixer Name
     SPACE3-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type
@@ -2584,7 +2581,6 @@
     SPACE4-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE4-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE4-1 In Node,        !- Outlet Node Name
-    SPACE4-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE4-1 PIU Mixer,      !- Zone Mixer Name
     SPACE4-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type

testfiles/5ZoneAirCooledConvCoef_VSFan.idf

@@ -2426,7 +2426,6 @@
     SPACE1-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE1-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE1-1 In Node,        !- Outlet Node Name
-    SPACE1-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE1-1 PIU Mixer,      !- Zone Mixer Name
     SPACE1-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type
@@ -2502,7 +2501,6 @@
     SPACE2-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE2-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE2-1 In Node,        !- Outlet Node Name
-    SPACE2-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE2-1 PIU Mixer,      !- Zone Mixer Name
     SPACE2-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type
@@ -2566,7 +2564,6 @@
     SPACE3-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE3-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE3-1 In Node,        !- Outlet Node Name
-    SPACE3-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE3-1 PIU Mixer,      !- Zone Mixer Name
     SPACE3-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type
@@ -2631,7 +2628,6 @@
     SPACE4-1 ATU In Node,    !- Supply Air Inlet Node Name
     SPACE4-1 ATU Sec Node,   !- Secondary Air Inlet Node Name
     SPACE4-1 In Node,        !- Outlet Node Name
-    SPACE4-1 Zone Coil Air In Node,  !- Reheat Coil Air Inlet Node Name
     SPACE4-1 PIU Mixer,      !- Zone Mixer Name
     SPACE4-1 PIU Fan,        !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type

testfiles/5ZoneVAV-ChilledWaterStorage-Mixed_DCV_MaxZd.idf

@@ -1483,7 +1483,6 @@
     ZN_1_FLR_1_SEC_1 VAV Box Inlet Node,  !- Supply Air Inlet Node Name
     ZN_1_FLR_1_SEC_1 Exhaust Node,  !- Secondary Air Inlet Node Name
     ZN_1_FLR_1_SEC_1 VAV Box Outlet Node,  !- Outlet Node Name
-    ZN_1_FLR_1_SEC_1 VAV Box Damper Node,  !- Reheat Coil Air Inlet Node Name
     Zone 1 PIU Mixer,        !- Zone Mixer Name
     Zone 1 PIU Fan,          !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type

testfiles/5ZoneVAV-ChilledWaterStorage-Mixed_DCV_MultiPath.idf

@@ -1492,7 +1492,6 @@
     ZN_1_FLR_1_SEC_1 VAV Box Inlet Node,  !- Supply Air Inlet Node Name
     ZN_1_FLR_1_SEC_1 Exhaust Node,  !- Secondary Air Inlet Node Name
     ZN_1_FLR_1_SEC_1 VAV Box Outlet Node,  !- Outlet Node Name
-    ZN_1_FLR_1_SEC_1 VAV Box Damper Node,  !- Reheat Coil Air Inlet Node Name
     Zone 1 PIU Mixer,        !- Zone Mixer Name
     Zone 1 PIU Fan,          !- Fan Name
     Coil:Heating:Water,      !- Reheat Coil Object Type