Skip to content

Make prediction column optional for performance estimation / calculation.#380

Merged
nnansters merged 4 commits intomainfrom
feat/optional-prediction-column
Apr 29, 2024
Merged

Make prediction column optional for performance estimation / calculation.#380
nnansters merged 4 commits intomainfrom
feat/optional-prediction-column

Conversation

@nnansters
Copy link
Copy Markdown
Contributor

This PR makes the y_pred column name optional for realised and estimated performance calculators in binary classification problem types.

When no y_pred column is given, only AUROC and average precision are allowed as metric values.

@nnansters nnansters requested a review from nikml as a code owner April 28, 2024 21:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.58%. Comparing base (e98cab9) to head (b6d8bdf).

Files Patch % Lines
nannyml/performance_calculation/calculator.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   78.41%   78.58%   +0.16%     
==========================================
  Files         110      110              
  Lines        8520     8540      +20     
  Branches     1514     1522       +8     
==========================================
+ Hits         6681     6711      +30     
+ Misses       1476     1465      -11     
- Partials      363      364       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters merged commit a52c06d into main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant