Skip to content

Commit 6e7e138

Browse files
committed
Comment
1 parent 466faae commit 6e7e138

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

csrc/host_ir/lowering.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,8 @@ void lowerSegment(
174174
// without cloning the value again.
175175
Expr* e = ir_cloner.clone(group.exprs().front());
176176

177-
// FIXME: should this be associated with the scope?
177+
// TODO: `replacement_map` should be associated with the scope os
178+
// ShardByStream across segments in the same for-loop can be reused.
178179
std::unordered_map<Val*, Val*> replacement_map;
179180
for (Expr* c : convertSingleOpToCommunication(e, device_id)) {
180181
NVF_ERROR(

0 commit comments

Comments
 (0)