Skip to content

Commit c98cf46

Browse files
committed
Fixes possible ground-source heat pump sizing error if the heating or cooling design temperature differences are zero.
1 parent 8724df2 commit c98cf46

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ __Bugfixes__
3030
- Fixes zero mech vent fan energy when CFIS system w/ `AdditionalRuntimeOperatingMode="air handler fan"` has the airflow rate set to zero.
3131
- Fixes requested EnergyPlus timeseries output variables/meters not displayed in DView if they don't have units.
3232
- Fixes possible errors when small water flow rates for variable-speed experimental ground-source heat pump model.
33+
- Fixes possible ground-source heat pump sizing error if the heating or cooling design temperature differences are zero.
3334

3435
## OpenStudio-HPXML v1.10.0
3536

HPXMLtoOpenStudio/measure.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
<schema_version>3.1</schema_version>
44
<name>hpxm_lto_openstudio</name>
55
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
6-
<version_id>ebf347a8-a3b8-4096-a72c-078aa24e7d59</version_id>
7-
<version_modified>2025-10-31T18:46:56Z</version_modified>
6+
<version_id>a76321a6-1fe2-4a9b-8574-86c1fa95f899</version_id>
7+
<version_modified>2025-10-31T20:47:24Z</version_modified>
88
<xml_checksum>D8922A73</xml_checksum>
99
<class_name>HPXMLtoOpenStudio</class_name>
1010
<display_name>HPXML to OpenStudio Translator</display_name>
@@ -420,7 +420,7 @@
420420
<filename>hvac_sizing.rb</filename>
421421
<filetype>rb</filetype>
422422
<usage_type>resource</usage_type>
423-
<checksum>AFA48130</checksum>
423+
<checksum>EE39F054</checksum>
424424
</file>
425425
<file>
426426
<filename>internal_gains.rb</filename>

HPXMLtoOpenStudio/resources/hvac_sizing.rb

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3409,8 +3409,19 @@ def self.get_geothermal_loop_borefield_ft_per_ton(mj, hpxml_bldg, geothermal_loo
34093409
cooling_month = 6 # July
34103410
end
34113411

3412-
rtf_DesignMon_Heat = [0.25, (71.0 - weather.data.MonthlyAvgDrybulbs[heating_month]) / mj.htd].max
3413-
rtf_DesignMon_Cool = [0.25, (weather.data.MonthlyAvgDrybulbs[cooling_month] - 76.0) / mj.ctd].max
3412+
# Runtime fraction average in heating/cooling months, assumed
3413+
if mj.htd > 0
3414+
rtf_DesignMon_Heat = (mj.heat_setpoint - weather.data.MonthlyAvgDrybulbs[heating_month]) / mj.htd
3415+
else
3416+
rtf_DesignMon_Heat = 0
3417+
end
3418+
if mj.ctd > 0
3419+
rtf_DesignMon_Cool = (weather.data.MonthlyAvgDrybulbs[cooling_month] - mj.cool_setpoint) / mj.ctd
3420+
else
3421+
rtf_DesignMon_Cool = 0
3422+
end
3423+
rtf_DesignMon_Heat = [[rtf_DesignMon_Heat, 0.25].max, 1.0].min
3424+
rtf_DesignMon_Cool = [[rtf_DesignMon_Cool, 0.25].max, 1.0].min
34143425

34153426
nom_length_heat = (1.0 - 1.0 / clg_ap.heat_rated_cops[0]) * (r_value_bore + r_value_ground * rtf_DesignMon_Heat) / (weather.data.DeepGroundAnnualTemp - (2.0 * clg_ap.design_hw - clg_ap.design_delta_t) / 2.0) * UnitConversions.convert(1.0, 'ton', 'Btu/hr')
34163427
nom_length_cool = (1.0 + 1.0 / clg_ap.cool_rated_cops[0]) * (r_value_bore + r_value_ground * rtf_DesignMon_Cool) / ((2.0 * clg_ap.design_chw + clg_ap.design_delta_t) / 2.0 - weather.data.DeepGroundAnnualTemp) * UnitConversions.convert(1.0, 'ton', 'Btu/hr')

0 commit comments

Comments
 (0)