Skip to content

Removed FluentAssertions in favour of Shouldly #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Removed FluentAssertions in favour of Shouldly #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ To ensure consistency and maintainability across the Valuify codebase, we follow
var actual = Math.Max(expected, 4);

// Assert
_ = actual.Should().Be(expected);
actual.ShouldBe(expected);
```

- **Test Naming**:
Expand Down
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="coverlet.msbuild" Version="6.0.3" />
<PackageVersion Include="FluentAssertions" Version="7.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.12.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.1.2" />
Expand All @@ -14,9 +13,10 @@
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="NSubstitute" Version="5.3.0" />
<PackageVersion Include="Shouldly" Version="4.2.1" />
<PackageVersion Include="SonarAnalyzer.CSharp" Version="10.5.0.109200" />
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
<PackageVersion Include="System.Formats.Asn1" Version="9.0.0" />
<PackageVersion Include="System.Formats.Asn1" Version="9.0.1" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.0.1" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions build/Tests.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
<PackageReference Include="FluentAssertions" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="NSubstitute" />
<PackageReference Include="Shouldly" />
<PackageReference Include="xunit" />
<PackageReference Include="xunit.runner.visualstudio">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand All @@ -29,8 +29,8 @@
<ProjectReference Include="..\$(RootNamespace)\$(RootNamespace).csproj" />
</ItemGroup>
<ItemGroup>
<Using Include="FluentAssertions"/>
<Using Include="NSubstitute"/>
<Using Include="Shouldly"/>
<Using Include="Xunit"/>
</ItemGroup>
</Project>
14 changes: 7 additions & 7 deletions src/Valuify.Console.Tests/NestingTests/WhenEqualityIsChecked.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void GivenIdenticalInstancesThenTheyAreDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeTrue();
areEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -49,7 +49,7 @@ public void GivenADifferentNameThenTheyAreNotDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -74,7 +74,7 @@ public void GivenADifferentQualificationThenTheyAreNotDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -99,7 +99,7 @@ public void GivenDifferentTypeThenTheyAreDeemedNotEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -117,7 +117,7 @@ public void GivenOneInstanceIsNullThenTheyAreDeemedNotEqual()
bool areEqual = AreEqual(instance, default);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -131,7 +131,7 @@ public void GivenBothInstancesAreNullThenTheyAreDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeTrue();
areEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -151,7 +151,7 @@ public void GivenSameReferenceThenTheyAreDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeTrue();
areEqual.ShouldBeTrue();
}

private protected abstract bool AreEqual(Nesting? instance1, Nesting? instance2);
Expand Down
14 changes: 7 additions & 7 deletions src/Valuify.Console.Tests/NestingTests/WhenInequalityIsChecked.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void GivenIdenticalInstancesThenTheyAreDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeFalse();
areNotEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -49,7 +49,7 @@ public void GivenADifferentNameThenTheyAreNotDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -74,7 +74,7 @@ public void GivenADifferentQualificationThenTheyAreNotDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -99,7 +99,7 @@ public void GivenDifferentTypeThenTheyAreDeemedNotEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -117,7 +117,7 @@ public void GivenOneInstanceIsNullThenTheyAreDeemedNotEqual()
bool areNotEqual = AreNotEqual(instance, default);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -131,7 +131,7 @@ public void GivenBothInstancesAreNullThenTheyAreDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeFalse();
areNotEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -151,7 +151,7 @@ public void GivenSameReferenceThenTheyAreDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeFalse();
areNotEqual.ShouldBeFalse();
}

private protected abstract bool AreNotEqual(Nesting? instance1, Nesting? instance2);
Expand Down
14 changes: 7 additions & 7 deletions src/Valuify.Console.Tests/PropertyTests/WhenEqualityIsChecked.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void GivenIdenticalInstancesThenTheyAreDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeTrue();
areEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -49,7 +49,7 @@ public void GivenADifferentIsSequenceThenTheyAreNotDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -74,7 +74,7 @@ public void GivenADifferentNameThenTheyAreNotDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -99,7 +99,7 @@ public void GivenDifferentTypeThenTheyAreDeemedNotEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -117,7 +117,7 @@ public void GivenOneInstanceIsNullThenTheyAreDeemedNotEqual()
bool areEqual = AreEqual(instance, default);

// Assert
_ = areEqual.Should().BeFalse();
areEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -131,7 +131,7 @@ public void GivenBothInstancesAreNullThenTheyAreDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeTrue();
areEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -151,7 +151,7 @@ public void GivenSameReferenceThenTheyAreDeemedEqual()
bool areEqual = AreEqual(instance1, instance2);

// Assert
_ = areEqual.Should().BeTrue();
areEqual.ShouldBeTrue();
}

private protected abstract bool AreEqual(Property? instance1, Property? instance2);
Expand Down
12 changes: 6 additions & 6 deletions src/Valuify.Console.Tests/PropertyTests/WhenInequalityIsChecked.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void GivenIdenticalInstancesThenTheyAreDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeFalse();
areNotEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -49,7 +49,7 @@ public void GivenADifferentNameThenTheyAreNotDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -74,7 +74,7 @@ public void GivenDifferentTypeThenTheyAreDeemedNotEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -92,7 +92,7 @@ public void GivenOneInstanceIsNullThenTheyAreDeemedNotEqual()
bool areNotEqual = AreNotEqual(instance, default);

// Assert
_ = areNotEqual.Should().BeTrue();
areNotEqual.ShouldBeTrue();
}

[Fact]
Expand All @@ -106,7 +106,7 @@ public void GivenBothInstancesAreNullThenTheyAreDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeFalse();
areNotEqual.ShouldBeFalse();
}

[Fact]
Expand All @@ -126,7 +126,7 @@ public void GivenSameReferenceThenTheyAreDeemedEqual()
bool areNotEqual = AreNotEqual(instance1, instance2);

// Assert
_ = areNotEqual.Should().BeFalse();
areNotEqual.ShouldBeFalse();
}

private protected abstract bool AreNotEqual(Property? instance1, Property? instance2);
Expand Down
Loading
Loading