Merge pull request #250 from MoiraeSoftware/repo-assist/fix-issue-249-filtertypes-helper-ast-ebf30c132bdcabc7

[Repo Assist] Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes #249

Author: 7sharp9

src/Myriad.Core/Ast.fs

@@ -240,19 +240,14 @@ module Ast =
         | SynTypeDefnRepr.Simple(SynTypeDefnSimpleRepr.Union _, _) -> true
         | _ -> false
 
+    let private filterTypes predicate types =
+        types |> List.map (fun (ns, types) -> ns, types |> List.filter predicate)
+
     let extractRecords (ast: ParsedInput) =
-        let types = extractTypeDefn ast
-        let onlyRecords =
-            types
-            |> List.map (fun (ns, types) -> ns, types |> List.filter isRecord )
-        onlyRecords
+        extractTypeDefn ast |> filterTypes isRecord
 
     let extractDU (ast: ParsedInput) =
-        let types = extractTypeDefn ast
-        let onlyDus =
-            types
-            |> List.map (fun (ns, types) -> ns, types |> List.filter isDu )
-        onlyDus
+        extractTypeDefn ast |> filterTypes isDu
 
 
     module ModuleOrNamespace =
@@ -286,31 +281,13 @@ module Ast =
             extractTypes moduleDecls namespaceId
 
         let records (nsOrModule: SynModuleOrNamespace) =
-            let types = getTypeDefns nsOrModule
-
-            let onlyRecords =
-                types
-                |> List.map (fun (ns, types) -> ns, types |> List.filter isRecord)
-
-            onlyRecords
+            getTypeDefns nsOrModule |> filterTypes isRecord
 
         let dus (nsOrModule: SynModuleOrNamespace) =
-            let types = getTypeDefns nsOrModule
-
-            let onlyDus =
-                types
-                |> List.map (fun (ns, types) -> ns, types |> List.filter isDu)
-
-            onlyDus
+            getTypeDefns nsOrModule |> filterTypes isDu
 
         let recordsOrDus (nsOrModule: SynModuleOrNamespace) =
-            let types = getTypeDefns nsOrModule
-
-            let recordsOrDus =
-                types
-                |> List.map (fun (ns, types) -> ns, types |> List.filter (fun t -> t |> isDu || t |> isRecord))
-
-            recordsOrDus
+            getTypeDefns nsOrModule |> filterTypes (fun t -> isDu t || isRecord t)
 
     module Ident =
         let asCamelCase (ident: Ident) =