From 6ad646ecc8fb8d9700578ac33c5797ac9b879444 Mon Sep 17 00:00:00 2001 From: Maiicy Date: Fri, 17 Oct 2025 11:11:56 +0800 Subject: [PATCH 1/3] [fit] correct Javadoc of isInvalidCookiePair to reflect invalid check --- .../src/main/java/modelengine/fit/http/util/HttpUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/util/HttpUtils.java b/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/util/HttpUtils.java index 4aa4df42e..22a474742 100644 --- a/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/util/HttpUtils.java +++ b/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/util/HttpUtils.java @@ -229,11 +229,11 @@ private static void parseCookieAttributes(String[] parts, Cookie.Builder builder } /** - * 验证给定的 Cookie 名称和值是否合法。 + * 判断给定的 Cookie 名称和值是否无效。 * * @param name 表示 Cookie 的名称 {@link String}。 * @param value 表示 Cookie 的值 {@link String}，允许为空但不允许为 {@code null}，可带双引号。 - * @return 如果 name 和 value 都合法返回 {@code true}，否则返回 {@code false}。 + * @return 如果 name 或 value 无效返回 {@code true}，否则返回 {@code false}。 */ public static boolean isInvalidCookiePair(String name, String value) { if (StringUtils.isEmpty(name) || !TOKEN_PATTERN.matcher(name).matches()) { From 5e365f6d566c589528ab2d56923f46d87798b8f0 Mon Sep 17 00:00:00 2001 From: Maiicy Date: Fri, 17 Oct 2025 14:33:02 +0800 Subject: [PATCH 2/3] [fit] add default value for Cookie.Builder.value --- .../definition/src/main/java/modelengine/fit/http/Cookie.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/Cookie.java b/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/Cookie.java index 8721b7d53..b6e2e65c1 100644 --- a/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/Cookie.java +++ b/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/Cookie.java @@ -7,6 +7,7 @@ package modelengine.fit.http; import modelengine.fitframework.pattern.builder.BuilderFactory; +import modelengine.fitframework.util.StringUtils; /** * 表示 Http 中的 Cookie。 @@ -210,7 +211,7 @@ interface Builder { * @return 表示 {@link Cookie} 的构建器的 {@link Builder}。 */ static Builder builder() { - return builder(null).maxAge(-1); + return builder(null).value(StringUtils.EMPTY).maxAge(-1).secure(false).httpOnly(false); } /** From 14788e4cfe1742e99448c73a92c17ed16bc26a3e Mon Sep 17 00:00:00 2001 From: Maiicy Date: Fri, 17 Oct 2025 14:38:19 +0800 Subject: [PATCH 3/3] [fit] update cookie parse test --- .../src/test/java/modelengine/fit/http/util/HttpUtilsTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/test/java/modelengine/fit/http/util/HttpUtilsTest.java b/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/test/java/modelengine/fit/http/util/HttpUtilsTest.java index 3641ac7fe..7e9b67b0a 100644 --- a/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/test/java/modelengine/fit/http/util/HttpUtilsTest.java +++ b/framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/test/java/modelengine/fit/http/util/HttpUtilsTest.java @@ -82,7 +82,7 @@ void givenValidSetCookieStringThenParseSuccessfully() { void givenEmptySetCookieThenReturnEmptyCookie() { Cookie cookie = HttpUtils.parseSetCookie(""); assertThat(cookie.name()).isNull(); - assertThat(cookie.value()).isNull(); + assertThat(cookie.value()).isEmpty(); } @Test