This repository was archived by the owner on Oct 12, 2022. It is now read-only.
.NET Standard TraceListener logging#166
Merged
SergeyKanzhelev merged 4 commits intomicrosoft:developfrom Mar 25, 2018
pharring:TraceListenerNetStandard
Merged
.NET Standard TraceListener logging#166SergeyKanzhelev merged 4 commits intomicrosoft:developfrom pharring:TraceListenerNetStandard
SergeyKanzhelev merged 4 commits intomicrosoft:developfrom
pharring:TraceListenerNetStandard
Conversation
SergeyKanzhelev
approved these changes
Mar 25, 2018
Contributor
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Please address feedback
src/TraceListener/AssemblyInfo.cs
Outdated
| [assembly: Guid("3aada9bf-fc15-42fd-ace5-4cb2f11c1f2a")] | ||
|
|
||
| [assembly: InternalsVisibleTo("Microsoft.ApplicationInsights.TraceListener.Net45.Tests, PublicKey=" + AssemblyInfo.PublicKey)] | ||
| [assembly: InternalsVisibleTo("Microsoft.ApplicationInsights.TraceListener.Tests, PublicKey=" + AssemblyInfo.PublicKey)] |
Contributor
There was a problem hiding this comment.
maybe have netcoreapp10 in the name of test assembly?
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Include="..\TraceListener.Net45.Tests\ApplicationInsightsTraceFilterTests.cs" Link="ApplicationInsightsTraceFilterTests.cs" /> |
Contributor
There was a problem hiding this comment.
moving thos to the folder with the name Shared can make folders structure cleaner. Can you do it please?
Member
Author
|
Ready to merge (I don't have permission myself) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a .NET Standard version of the TraceListener logging package so that it can be used in .NET Core applications.