Minor code cleanup

Author: egorodet

Modules/Graphics/RHI/DirectX/Sources/Methane/Graphics/DirectX/DescriptorHeap.cpp

@@ -34,6 +34,7 @@ Descriptor Heap is a platform abstraction of DirectX 12 descriptor heaps.
 
 #include <magic_enum/magic_enum.hpp>
 #include <directx/d3dx12_root_signature.h>
+#include <ranges>
 #include <cassert>
 
 namespace Methane::Graphics::DirectX
@@ -56,7 +57,7 @@ DescriptorHeapReservation::DescriptorHeapReservation(const Ref<DescriptorHeap>&
     : heap(heap)
 {
     META_FUNCTION_TASK();
-    std::fill(ranges.begin(), ranges.end(), DescriptorHeap::Range(0, 0));
+    std::ranges::fill(ranges, DescriptorHeap::Range(0, 0));
 }
 
 DescriptorHeapReservation::DescriptorHeapReservation(const Ref<DescriptorHeap>& heap, const Ranges& ranges)

Modules/Graphics/RHI/DirectX/Sources/Methane/Graphics/DirectX/ProgramBindings.cpp

@@ -37,13 +37,14 @@ DirectX 12 implementation of the program bindings interface.
 #include <Methane/Checks.hpp>
 
 #include <magic_enum/magic_enum.hpp>
+#include <ranges>
 
 namespace Methane::Graphics::DirectX
 {
 
 DescriptorsCountByAccess::DescriptorsCountByAccess()
 {
-    std::fill(m_count_by_access_type.begin(), m_count_by_access_type.end(), 0U);
+    std::ranges::fill(m_count_by_access_type, 0U);
 }
 
 uint32_t& DescriptorsCountByAccess::operator[](Rhi::ProgramArgumentAccessType access_type)

Modules/Graphics/RHI/Impl/Sources/Methane/Graphics/RHI/System.cpp

@@ -104,9 +104,9 @@ std::string System::ToString() const
 const Devices& System::UpdateDevices(const Ptrs<Rhi::IDevice>& devices) const
 {
     m_devices.clear();
-    std::ranges::transform(devices.cbegin(), devices.cend(), std::back_inserter(m_devices),
-                   [](const Ptr<Rhi::IDevice>& device_ptr)
-                   { return Device(device_ptr); });
+    std::ranges::transform(devices, std::back_inserter(m_devices),
+                           [](const Ptr<Rhi::IDevice>& device_ptr)
+                           { return Device(device_ptr); });
     return m_devices;
 }
 

Modules/Graphics/RHI/Metal/Include/Methane/Graphics/Metal/Sampler.hh

@@ -34,7 +34,8 @@ namespace Methane::Graphics::Metal
 
 struct IContext;
 
-class Sampler final : public Resource<Base::Sampler>
+class Sampler final
+    : public Resource<Base::Sampler>
 {
 public:
     Sampler(const Base::Context& context, const Settings& settings);

Modules/Graphics/RHI/Metal/Sources/Methane/Graphics/Metal/Program.mm

@@ -35,6 +35,8 @@
 #include <Methane/Instrumentation.h>
 #include <Methane/Checks.hpp>
 
+#include <ranges>
+
 #if defined(__MAC_15_0) || defined(__IPHONE_18_0)
 #define MTL_PIPELINE_OPTION_BINDING_INFO MTLPipelineOptionBindingInfo
 #else
@@ -182,7 +184,7 @@
 {
     META_FUNCTION_TASK();
     m_shader_argument_buffer_layouts.clear();
-    std::fill(m_arguments_range_size_by_access_type.begin(), m_arguments_range_size_by_access_type.end(), 0U);
+    std::ranges::fill(m_arguments_range_size_by_access_type, 0U);
 
     ForEachShader([this](const Base::Shader& shader)
     {
@@ -221,7 +223,7 @@
                                 ? dynamic_cast<const Rhi::IRenderContext&>(context).GetSettings().frame_buffers_count
                                 : 1U;
     m_frame_constant_argument_buffer_ranges.resize(frames_count);
-    std::fill(m_frame_constant_argument_buffer_ranges.begin(), m_frame_constant_argument_buffer_ranges.end(), ArgumentsRange{});
+    std::ranges::fill(m_frame_constant_argument_buffer_ranges, ArgumentsRange{});
 
     if (const Data::Size frame_const_args_range_size = GetArgumentsBufferRangeSize(Rhi::ProgramArgumentAccessType::FrameConstant))
     {

Modules/Graphics/RHI/Metal/Sources/Methane/Graphics/Metal/ProgramBindings.mm

@@ -34,6 +34,8 @@
 #include <Methane/Instrumentation.h>
 #include <Methane/Checks.hpp>
 
+#include <ranges>
+
 namespace Methane::Graphics::Metal
 {
 
@@ -747,7 +749,7 @@ static void WriteArgumentBindingResourceIds(const ProgramArgumentBinding& arg_bi
     const auto& program = GetMetalProgram();
     auto& descriptor_manager = static_cast<DescriptorManager&>(program.GetContext().GetDescriptorManager());
     std::array<Data::Size, magic_enum::enum_count<Rhi::ProgramArgumentAccessType>()> arg_layout_offset_by_buffer;
-    std::fill(arg_layout_offset_by_buffer.begin(), arg_layout_offset_by_buffer.end(), 0U);
+    std::ranges::fill(arg_layout_offset_by_buffer, 0U);
 
     for(const Program::ShaderArgumentBufferLayout& arg_layout : program.GetShaderArgumentBufferLayouts())
     {

Modules/Graphics/RHI/Metal/Sources/Methane/Graphics/Metal/Shader.mm

@@ -68,9 +68,10 @@ static MTLVertexStepFunction GetVertexStepFunction(Rhi::ProgramInputBufferLayout
     META_FUNCTION_TASK();
     switch(mtl_arg_type)
     {
-    case MTLBindingTypeBuffer:  return Rhi::ResourceType::Buffer;
-    case MTLBindingTypeTexture: return Rhi::ResourceType::Texture;
-    case MTLBindingTypeSampler: return Rhi::ResourceType::Sampler;
+    using enum Rhi::ResourceType;
+    case MTLBindingTypeBuffer:  return Buffer;
+    case MTLBindingTypeTexture: return Texture;
+    case MTLBindingTypeSampler: return Sampler;
     default:                    META_UNEXPECTED_RETURN(mtl_arg_type, IResource::Type::Buffer);
     }
 }
@@ -103,9 +104,10 @@ static uint32_t GetBindingBufferSize(id<MTLBinding> mtl_binding)
     META_FUNCTION_TASK();
     switch(mtl_data_type)
     {
-    case MTLDataTypePointer: return Rhi::ResourceType::Buffer;
-    case MTLDataTypeTexture: return Rhi::ResourceType::Texture;
-    case MTLDataTypeSampler: return Rhi::ResourceType::Sampler;
+    using enum Rhi::ResourceType;
+    case MTLDataTypePointer: return Buffer;
+    case MTLDataTypeTexture: return Texture;
+    case MTLDataTypeSampler: return Sampler;
     default:                 META_UNEXPECTED_RETURN(mtl_data_type, Rhi::ResourceType::Buffer);
     }
 }

Modules/UserInterface/Typography/Sources/Methane/UserInterface/FontImpl.hpp

@@ -467,7 +467,7 @@ class Font::Impl // NOSONAR - class destructor is required, class has more than
 
         // Sort chars by decreasing of glyph pixels count from largest to smallest
         std::ranges::sort(font_chars,
-            [](const Ref<Char>& left, const Ref<Char>& right)
+            [](Ref<Char> left, Ref<Char> right)
             { return left.get() > right.get(); }
         );