dockerfile: reduce the final image size #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hank <[email protected]>
Collaborator
Author
|
cc: @dtrifiro |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Dockerfile to use a multi-stage build, which is a great step towards reducing the final image size. The changes are well-structured. However, I've found a few critical issues that undermine the size reduction effort and introduce maintenance problems. My main concerns are:
- The final image incorrectly copies the entire
/usrdirectory from a build stage, including many unnecessary build tools and bloating the image. - There are hardcoded versions in
rpmandARGcommands, which will cause issues when versions are updated.
I've provided detailed comments and suggestions to address these points. Fixing them should further reduce the image size significantly and improve the Dockerfile's maintainability.
Signed-off-by: Hank <[email protected]>
dtrifiro
approved these changes
Dec 3, 2025
chr15p
reviewed
Dec 4, 2025
chr15p
reviewed
Dec 4, 2025
| --extra-index-url ${UV_EXTRA_INDEX_URL} \ | ||
| . -v && \ | ||
| vllm_metax_init | ||
| uv build --wheel --out-dir=/workspace/vllm_metax_wheel_dist |
There was a problem hiding this comment.
this commands fails because torch==2.6.0+metax3.2.1.3 is not available, does it need a --index=https://repos.metax-tech.com/r/maca-pypi/simple ?
Collaborator
Author
There was a problem hiding this comment.
It's weird I didnt got the problem in my local environment. I've alreay set the UV_EXTRA_INDEX_URL to the index so it should not happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The image size are too large for now. This PR reduce the image size from ~30g to ~23g