fix: fix linters

Author: salimtb

app/scripts/controller-init/account-tracker-controller-init.ts

@@ -16,7 +16,10 @@ export const AccountTrackerControllerInit: ControllerInitFunction<
 
   const onboardingController = () => getController('OnboardingController');
 
+  // TODO: Fix AccountTrackerControllerMessenger type - add AccountTrackerControllerActions & AccountTrackerControllerEvents
+  // TODO: Bump @metamask/network-controller, @metamask/accounts-controller to match assets-controllers
   const controller = new AccountTrackerController({
+    // @ts-expect-error - Messenger type mismatch due to missing controller actions/events and dependency version mismatch
     messenger: controllerMessenger,
     getStakedBalanceForChain: (
       addresses: string[],

app/scripts/controller-init/assets/assets-contract-controller-init.ts

@@ -19,7 +19,10 @@ export const AssetsContractControllerInit: ControllerInitFunction<
   AssetsContractControllerMessenger,
   AssetsContractControllerInitMessenger
 > = ({ controllerMessenger, initMessenger }) => {
+  // TODO: Fix AssetsContractControllerMessenger type - add AssetsContractControllerActions
+  // TODO: Bump @metamask/network-controller to match assets-controllers
   const controller = new AssetsContractController({
+    // @ts-expect-error - Messenger type mismatch due to missing controller actions and dependency version mismatch
     messenger: controllerMessenger,
     chainId: getGlobalChainId(initMessenger),
   });

app/scripts/controller-init/currency-rate-controller-init.ts

@@ -22,11 +22,12 @@ export const CurrencyRateControllerInit: ControllerInitFunction<
   CurrencyRateControllerMessenger,
   CurrencyRateControllerInitMessenger
 > = ({ controllerMessenger, initMessenger, persistedState }) => {
+  // TODO: Fix CurrencyRateControllerMessenger type - add CurrencyRateControllerActions & CurrencyRateControllerEvents
+  // TODO: Bump @metamask/network-controller to match assets-controllers
   const controller = new CurrencyRateController({
-    // @ts-expect-error: `CurrencyRateController` is persisted as
-    // `CurrencyController`, but the controller init pattern doesn't
-    // allow this in the type of `persistedState`.
+    // @ts-expect-error - CurrencyRateController is persisted as 'CurrencyController' but init pattern expects 'CurrencyRateController'
     state: persistedState.CurrencyController,
+    // @ts-expect-error - Messenger type mismatch due to missing controller actions/events and dependency version mismatch
     messenger: controllerMessenger,
     includeUsdRate: true,
     useExternalServices: () =>

app/scripts/controller-init/token-list-controller-init.ts

@@ -32,7 +32,10 @@ export const TokenListControllerInit: ControllerInitFunction<
     return useTokenDetection || petnamesEnabled || useTransactionSimulations;
   };
 
+  // TODO: Fix TokenListControllerMessenger type - add TokenListControllerActions & TokenListControllerEvents
+  // TODO: Bump @metamask/network-controller to match assets-controllers
   const controller = new TokenListController({
+    // @ts-expect-error - Messenger type mismatch due to missing controller actions/events and dependency version mismatch
     messenger: controllerMessenger,
     state: persistedState.TokenListController,
     preventPollingOnNetworkRestart: !isTokenListPollingRequired(

app/scripts/controller-init/tokens-controller-init.ts

@@ -16,14 +16,13 @@ export const TokensControllerInit: ControllerInitFunction<
     initMessenger.call('NetworkController:getSelectedNetworkClient') ?? {};
   assert(provider, 'Provider is required to initialize TokensController.');
 
+  // TODO: Fix TokensControllerMessenger type - add TokensControllerActions & TokensControllerEvents
+  // TODO: Bump @metamask/network-controller, @metamask/accounts-controller, @metamask/keyring-controller to match assets-controllers
   const controller = new TokensController({
+    // @ts-expect-error - Messenger type mismatch due to missing controller actions/events and dependency version mismatch
     messenger: controllerMessenger,
     state: persistedState.TokensController,
-    // TODO: Remove @ts-expect-error once @metamask/network-controller is bumped in
-    // @metamask/assets-controllers. The provider from NetworkController:getSelectedNetworkClient
-    // is a SwappableProxy that's runtime-compatible with Provider but TypeScript can't verify
-    // the private field requirement due to version mismatch.
-    // @ts-expect-error - Provider type mismatch between SwappableProxy and InternalProvider
+    // @ts-expect-error - Provider type mismatch between SwappableProxy and InternalProvider due to network-controller version mismatch
     provider,
     chainId: getGlobalChainId(initMessenger),
   });