Failures with script_spice_metadata_check_upgrade following 13.4 release

[theabro]

I'm attempting to run a 13.3 test branch, and am having issues with the script_spice_metadata_check_upgrade task. The information from the job.out file are:

[INFO] command: upgrade_test.sh
[INFO] Upgrading fcm_make_um from vn10.5 to vn13.4 (part 1 of 2)
[INFO] Upgrading fcm_make_um from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app fcm_make_um from vn10.5 validates
[FAIL] Upgraded fcm_make_um from vn10.5 does not match current working copy
[INFO] Upgrading fcm_make_recon from vn10.5 to vn13.4 (part 1 of 2)
[INFO] Upgrading fcm_make_recon from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app fcm_make_recon from vn10.5 validates
[FAIL] Upgraded fcm_make_recon from vn10.5 does not match current working copy
[INFO] Upgrading fcm_make_scm from vn11.3 to vn13.4 (part 1 of 2)
[INFO] Upgrading fcm_make_scm from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app fcm_make_scm from vn11.3 validates
[FAIL] Upgraded fcm_make_scm from vn11.3 does not match current working copy
[INFO] Upgrading fcm_make_createbc from vn10.5 to vn13.4 (part 1 of 2)
/file/*.cfg unchanged as not a scm or atmos fcm-make configuration
/file/*.cfg unchanged as not a scm or atmos fcm-make configuration
[INFO] Upgrading fcm_make_createbc from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app fcm_make_createbc from vn10.5 validates
[FAIL] Upgraded fcm_make_createbc from vn10.5 does not match current working copy
[INFO] Upgrading fcm_make_utils_mpp from vn10.5 to vn13.4 (part 1 of 2)
/file/*.cfg unchanged as not a scm or atmos fcm-make configuration
/file/*.cfg unchanged as not a scm or atmos fcm-make configuration
[INFO] Upgrading fcm_make_utils_mpp from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app fcm_make_utils_mpp from vn10.5 validates
[FAIL] Upgraded fcm_make_utils_mpp from vn10.5 does not match current working copy
[INFO] Upgrading fcm_make_utils_serial from vn10.5 to vn13.4 (part 1 of 2)
/file/*.cfg unchanged as not a scm or atmos fcm-make configuration
/file/*.cfg unchanged as not a scm or atmos fcm-make configuration
[INFO] Upgrading fcm_make_utils_serial from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app fcm_make_utils_serial from vn10.5 validates
[FAIL] Upgraded fcm_make_utils_serial from vn10.5 does not match current working copy
[INFO] Upgrading createbc_calcs from 54180 to vn13.4 (part 1 of 2)
[INFO] Upgrading createbc_calcs from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app createbc_calcs from 54180 validates
[FAIL] Upgraded createbc_calcs from 54180 does not match current working copy
[INFO] Upgrading recon_lam_from_grib_cutout from vn11.3 to vn13.4 (part 1 of 2)
[INFO] Upgrading recon_lam_from_grib_cutout from vn13.4 to vn13.4 (part 2 of 2)
[PASS] Upgraded app recon_lam_from_grib_cutout from vn11.3 validates
[FAIL] Upgraded recon_lam_from_grib_cutout from vn11.3 does not match current working copy

and I'm confused here because this is a UM13.3 branch, so I'm not sure why it's referencing 13.4. The job.err file has:

[FAIL] vn13.4: already at this version.
1c1
< meta=um-fcm-make/vn13.4
---
> meta=um-fcm-make/vn13.3
[FAIL] Upgraded fcm_make_um from vn10.5 does not match current working copy
[FAIL] vn13.4: already at this version.
1c1
< meta=um-fcm-make/vn13.4
---
> meta=um-fcm-make/vn13.3
[FAIL] Upgraded fcm_make_recon from vn10.5 does not match current working copy
[FAIL] vn13.4: already at this version.
1c1
< meta=um-fcm-make/vn13.4
---
> meta=um-fcm-make/vn13.3
[FAIL] Upgraded fcm_make_scm from vn11.3 does not match current working copy
[FAIL] vn13.4: already at this version.
1c1
< meta=um-fcm-make/vn13.4
---
> meta=um-fcm-make/vn13.3
[FAIL] Upgraded fcm_make_createbc from vn10.5 does not match current working copy
[FAIL] vn13.4: already at this version.
1c1
< meta=um-fcm-make/vn13.4
---
> meta=um-fcm-make/vn13.3
[FAIL] Upgraded fcm_make_utils_mpp from vn10.5 does not match current working copy
[FAIL] vn13.4: already at this version.
1c1
< meta=um-fcm-make/vn13.4
---
> meta=um-fcm-make/vn13.3
[FAIL] Upgraded fcm_make_utils_serial from vn10.5 does not match current working copy
[FAIL] vn13.4: already at this version.
[FAIL] Could not load macro /home/h03/fcm/rose-meta/um-createbc/vn13.4/lib/python/macros/stash_ordering.py: Traceback (most recent call last):
[FAIL]   File "/net/home/h03/fcm/rose-2019.01.8/lib/python/rose/macro.py", line 747, in load_meta_macro_modules
[FAIL]     modules.append(imp.load_source(as_name, meta_file))
[FAIL]   File "/home/h03/fcm/rose-meta/um-createbc/vn13.4/lib/python/macros/stash_ordering.py", line 101, in <module>
[FAIL]     class StashOrderUMTransform(rose.macro.MacroBase):
[FAIL] AttributeError: 'module' object has no attribute 'macro'
1c1
< meta=um-createbc/vn13.4
---
> meta=um-createbc/vn13.3
[FAIL] Upgraded createbc_calcs from 54180 does not match current working copy
[FAIL] vn13.4: already at this version.
1c1
< meta=um-atmos/vn13.4
---
> meta=um-atmos/vn13.3_t7271
846c846
< !!overbank_model=1
---
> !!l_riv_hypsometry=.false.
850a851
> !!use_rosgen=.false.
943,945d943
< !!sug_g0_io=5*1.0
< !!sug_grec_io=5*1.0
< !!sug_yg_io=5*1.0
986d983
< !!lake_water_conserve_method=1
1278d1274
< !!l_sugar=.false.
2727a2724
> !!file_volc_so2=$UMDIR/vn$VN/ctldata/UKCA/strat/SO2_expvolc_1979-2021.csv
2818a2816
> !!l_ukca_so2ems_plumeria=.false.
2829a2828
> !!nerupt=178
[FAIL] Upgraded recon_lam_from_grib_cutout from vn11.3 does not match current working copy
[FAIL] upgrade_test.sh <<'__STDIN__'
[FAIL]
[FAIL] '__STDIN__' # return-code=1
2023-11-06T10:30:02Z CRITICAL - failed/EXIT

with the lines at the end referencing what it being added by the new versions.py file.

The test branch being worked on is r120380_vplume_test_branch_5.

Any advice here would be much appreciated.

[james-bruten-mo]

Hi Luke, I don't think any of this is your fault. The first suggestion is to upgrade to vn13.4 and I think most of those failures will disappear. I think the createbc failure will likely continue however, so I'd suggest if the metadata_upgrade test does fail again, then ignore it in this case and make a note on the the ticket summary before review. We'll work out what to do with the underlying issue in the meantime. Cheers

[theabro]

Hi James - thanks for this. We're in the process of upgrading to 13.4 - we'd just been ironing out some bugs in the current branch before doing so. Hopefully this will be done soon and then we can test again.
Best wishes,
Luke