Allow disabling DNSSEC with cdflag

[Dhravya]

No description provided.

[Dhravya]

Hey @MattIPv4 can you please review this and let me know if any changes need to be made? I was unable to test it

[MattIPv4]

Thank you for the work so far, looking good but you're missing the actual logic changes needed within the DNS lookup to set the flag.

I recommend following the steps in https://github.com/MattIPv4/DNS-over-Discord#development so that you can test this functionality is actually behaving as you'd expect locally.

(For testing, dnssec-failed.org should result in a servfail normally, but should return A records when the cdflag is set.)

[MattIPv4]

👋 I'm not sure what exactly your last commit did, but you appear to have caused a diff across every single file in the repo now? Have you changed the line endings on everything perhaps?

[Dhravya]

That's weird - I've not changed anything manually, except for the dns.js file

[MattIPv4]

If you're using a Windows system, make sure git is configured to use lf endings, not crlf endings. It should warn you about this though when you staged/committed this massive change.

[Dhravya]

Oh - I got it now. Any way to undo it?

[MattIPv4]

If you've updated git to use lf endings, I'd expect it'd now let you commit again to revert it all -- or you could just drop the last commit and redo the change.

[Dhravya]

HELL YES! Done

[Dhravya]

Ok I was testing if everything works fine and I noticed a mistake i made

So I followed the cloudflare docs (https://developers.cloudflare.com/1.1.1.1/encryption/dns-over-https/) and added the cd bit to the JSON and DNS lookup snippets, but this causes an error when using google's DNS lookup (8.8.8.8)

SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON
    at async performLookup (worker.js:10086:42)
    at async Promise.all (index 0)
    at async handleDig (worker.js:14844:21)
    at async worker.js:17271:35 at line 0, col 0

[Dhravya]

Wait.... it should still work with 8.8.8.8, that's odd

[Dhravya]

dns.google is returning Error 400 (Bad Request)!!

[MattIPv4]

Before I can start reviewing this, you're going to need to revert the line ending changes that you've made to every file here

[Dhravya]

Ok! I'll revert the commit and do the same changes again

[Dhravya]

Done! @MattIPv4

[Dhravya]

Hey @MattIPv4 I think all the changes are done (soo sorry for all the trouble)

[MattIPv4]

There are a few eslint errors that need resolving

[Dhravya]

Fixed eslint errors

[Dhravya]

Made the changes

[MattIPv4]

LGTM, thank you for working on this and seeing it through 💙

[Dhravya]

cool, thanks a lot! I genuinely learnt so much through this one PR and I definitely look forward to contributing more to this repository!