WIP - #305 fixup

Author: tegefaulkes

src/vaults/VaultInternal.ts

@@ -316,17 +316,6 @@ class VaultInternal {
     );
   }
 
-  // Is remote?
-  // well we don't just get remote
-  // we keep track of it
-  public async getRemote(): Promise<[NodeId, VaultId]> {
-    // Get the remote if exists
-    // if undefined you consider this to be not remote
-    // and therefore can proceed
-    // return Promise of [NodeId, VaultId]
-    throw Error('Not implemented');
-  }
-
   @ready(new vaultsErrors.ErrorVaultNotRunning())
   public async log(
     ref: string | VaultRef = 'HEAD',

src/vaults/VaultManager.ts

@@ -588,7 +588,11 @@ class VaultManager {
         );
         if (existingVaultId == null) break;
         newVaultName = `${baseVaultName}-${attempts}`;
-        if (attempts >= 100) throw Error('MAKE PROPER ERROR');
+        if (attempts >= 50) {
+          throw new vaultsErrors.ErrorVaultsNameConflict(
+            `Too many copies of ${baseVaultName}`,
+          );
+        }
         attempts++;
       }
       // Set the vaultName -> vaultId mapping

src/vaults/errors.ts

@@ -94,6 +94,11 @@ class ErrorVaultsPermissionDenied extends ErrorVaults {
   exitCode = sysexits.NOPERM;
 }
 
+class ErrorVaultsNameConflict extends ErrorVaults {
+  description = 'Unique name could not be created';
+  exitCode = sysexits.UNAVAILABLE;
+}
+
 class ErrorSecrets extends ErrorPolykey {}
 
 class ErrorSecretsSecretUndefined extends ErrorSecrets {
@@ -127,6 +132,7 @@ export {
   ErrorVaultsCreateVaultId,
   ErrorVaultsMergeConflict,
   ErrorVaultsPermissionDenied,
+  ErrorVaultsNameConflict,
   ErrorSecrets,
   ErrorSecretsSecretUndefined,
   ErrorSecretsSecretDefined,