Skip to content

Commit a9080f7

Browse files
authored
Fixed narrowing conversion issues. (sonic-net#3395)
What I did Fixed 3 narrowing conversion issues in the code. Why I did it g++ 9.4.0 and 10.5.0 both reported compile errors when trying to compile aclorch.cpp using -Werror and -Wconversion flags.
1 parent 98303af commit a9080f7

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

orchagent/aclorch.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5938,7 +5938,7 @@ bool MetaDataMgr::isValidMetaData(uint16_t metadata)
59385938

59395939
uint16_t MetaDataMgr::getFreeMetaData(uint8_t dscp)
59405940
{
5941-
uint16_t metadata = metaMax + 1;
5941+
uint16_t metadata = (uint16_t)(metaMax + 1);
59425942
SWSS_LOG_INFO("Metadata Request for dscp %d", dscp);
59435943

59445944
if (initComplete)
@@ -5962,7 +5962,7 @@ uint16_t MetaDataMgr::getFreeMetaData(uint8_t dscp)
59625962
m_dscpMetadata[dscp] = metadata;
59635963
SWSS_LOG_INFO("New Metadata %d allocated for dscp %d", metadata, dscp);
59645964
}
5965-
m_MetadataRef[metadata] += 1;
5965+
m_MetadataRef[metadata] = (uint16_t)(m_MetadataRef[metadata] + 1);
59665966
}
59675967
else
59685968
{
@@ -5975,7 +5975,7 @@ void MetaDataMgr::recycleMetaData(uint16_t metadata)
59755975
{
59765976
if (initComplete)
59775977
{
5978-
m_MetadataRef[metadata] -= 1;
5978+
m_MetadataRef[metadata] = (uint16_t)(m_MetadataRef[metadata] - 1);
59795979
SWSS_LOG_INFO("Freeing Metadata %d refcount %d", metadata, m_MetadataRef[metadata]);
59805980
if (m_MetadataRef[metadata] == 0)
59815981
{

0 commit comments

Comments
 (0)