Skip to content

#18 Add validation of custom grok patterns file #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

#18 Add validation of custom grok patterns file #24

wants to merge 1 commit into from

Conversation

@MazixM
Copy link

@MazixM MazixM commented Aug 23, 2021

This is checking if content of custom grok patterns and also grok-patterns are correct on loading.

@Marusyk Marusyk self-requested a review August 24, 2021 21:58
@Marusyk Marusyk self-assigned this Aug 24, 2021
@Marusyk Marusyk linked an issue Aug 24, 2021 that may be closed by this pull request
Add validation of custom grok patterns file #18
Closed
@Marusyk
Copy link
Owner

Marusyk commented Aug 24, 2021

Please add unit tests

Marusyk
Marusyk reviewed Aug 27, 2021
View reviewed changes
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about throwing some valid exception when the custom file is not valid instead of just ignore it?

@MazixM
Copy link
Author

MazixM commented Aug 27, 2021

If i add this then i can help users to find bug if they done some mistake in a file. I can add for example ArgumentException in case of not valid file. Can you let me know is it good way?

@Marusyk
Copy link
Owner

Marusyk commented Aug 30, 2021

Yeah, agree. I think you can use FormatException for that

@Marusyk
Copy link
Owner

Marusyk commented Sep 4, 2021 •
edited
Loading

Hi @MazixM
I am sorry but the issue has already been fixed in this PR #23
Thank you for your interest in this project.
If you have some ideas on how to make grok.net better, please don't hesitate - create a PR.

Also, we will keep a list of issues that are approachable for newcomers under the good-first-issue label.

Waiting for your new PRs

@Marusyk Marusyk closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marusyk Marusyk Marusyk left review comments

Assignees

@Marusyk Marusyk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add validation of custom grok patterns file

2 participants

@MazixM @Marusyk