Skip to content

Commit 83309c1

Browse files
AdrianDCthinkyhead
authored andcommitted
Fix E3V2 Control Menu icon/text order (#21838)
Fixes #21837
1 parent ec2f4f5 commit 83309c1

1 file changed

Lines changed: 20 additions & 18 deletions

File tree

Marlin/src/lcd/dwin/e3v2/dwin.cpp

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -815,8 +815,6 @@ void Draw_Control_Menu() {
815815

816816
if (CVISI(CONTROL_CASE_ADVSET)) {
817817
DWIN_Draw_Label(CLINE(CONTROL_CASE_ADVSET), GET_TEXT_F(MSG_ADVANCED_SETTINGS)); // Advanced Settings
818-
Draw_More_Icon(CSCROL(CONTROL_CASE_ADVSET));
819-
Draw_Menu_Line(CSCROL(CONTROL_CASE_ADVSET), ICON_AdvSet);
820818
}
821819

822820
if (CVISI(CONTROL_CASE_INFO)) Item_Control_Info(CLINE(CONTROL_CASE_INFO));
@@ -825,23 +823,26 @@ void Draw_Control_Menu() {
825823
Draw_Menu_Cursor(CSCROL(select_control.now));
826824

827825
// Draw icons and lines
828-
uint8_t i = 0;
829-
#define _TEMP_ICON(N) do{ ++i; if (CVISI(i)) Draw_Menu_Line(CSCROL(i), ICON_Temperature + (N) - 1); }while(0)
830-
831-
_TEMP_ICON(CONTROL_CASE_TEMP);
832-
if (CVISI(i)) Draw_More_Icon(CSCROL(i));
833-
834-
_TEMP_ICON(CONTROL_CASE_MOVE);
835-
Draw_More_Icon(CSCROL(i));
826+
#define _TEMP_ICON(N, I, M) do { \
827+
if (CVISI(N)) { \
828+
Draw_Menu_Line(CSCROL(N), I); \
829+
if (M) { \
830+
Draw_More_Icon(CSCROL(N)); \
831+
} \
832+
} \
833+
} while(0)
834+
835+
_TEMP_ICON(CONTROL_CASE_TEMP, ICON_Temperature, true);
836+
_TEMP_ICON(CONTROL_CASE_MOVE, ICON_Motion, true);
836837

837838
#if ENABLED(EEPROM_SETTINGS)
838-
_TEMP_ICON(CONTROL_CASE_SAVE);
839-
_TEMP_ICON(CONTROL_CASE_LOAD);
840-
_TEMP_ICON(CONTROL_CASE_RESET);
839+
_TEMP_ICON(CONTROL_CASE_SAVE, ICON_WriteEEPROM, false);
840+
_TEMP_ICON(CONTROL_CASE_LOAD, ICON_ReadEEPROM, false);
841+
_TEMP_ICON(CONTROL_CASE_RESET, ICON_ResumeEEPROM, false);
841842
#endif
842843

843-
_TEMP_ICON(CONTROL_CASE_INFO);
844-
if (CVISI(CONTROL_CASE_INFO)) Draw_More_Icon(CSCROL(i));
844+
_TEMP_ICON(CONTROL_CASE_ADVSET, ICON_AdvSet, true);
845+
_TEMP_ICON(CONTROL_CASE_INFO, ICON_Info, true);
845846
}
846847

847848
void Draw_Tune_Menu() {
@@ -2653,11 +2654,12 @@ void HMI_Control() {
26532654
Scroll_Menu(DWIN_SCROLL_UP);
26542655

26552656
switch (index_control) { // Last menu items
2656-
case CONTROL_CASE_ADVSET: // Advance Settings >
2657+
case CONTROL_CASE_ADVSET: // Advanced Settings >
26572658
Draw_Menu_Item(MROWS, ICON_AdvSet, GET_TEXT(MSG_ADVANCED_SETTINGS), true);
26582659
break;
26592660
case CONTROL_CASE_INFO: // Info >
2660-
Draw_Menu_Item(MROWS, ICON_Info, GET_TEXT(MSG_INFO_SCREEN), true);
2661+
Item_Control_Info(MBASE(MROWS));
2662+
Draw_Menu_Icon(MROWS, ICON_Info);
26612663
break;
26622664
default: break;
26632665
}
@@ -2721,7 +2723,7 @@ void HMI_Control() {
27212723
HMI_AudioFeedback();
27222724
break;
27232725
#endif
2724-
case CONTROL_CASE_ADVSET: // Advance Settings
2726+
case CONTROL_CASE_ADVSET: // Advanced Settings
27252727
checkkey = AdvSet;
27262728
select_advset.reset();
27272729
Draw_AdvSet_Menu();

0 commit comments

Comments
 (0)