Default TCP and Unix sockets to SOCK_NONBLOCK, fix up new lints

Author: MarcusGrass

.local/tiny-std-test.sh

@@ -1,8 +1,9 @@
 #!/bin/sh
 set -ex
-
 cargo test -p tiny-std --no-default-features
 cargo test -p tiny-std --features threaded,global-allocator
 
 cross test -p tiny-std --no-default-features --target aarch64-unknown-linux-gnu
-cross test -p tiny-std --target aarch64-unknown-linux-gnu --features threaded,global-allocator
+
+cross test -p tiny-std --target aarch64-unknown-linux-gnu --features threaded,global-allocator
+

Cargo.toml

@@ -1,4 +1,5 @@
 [workspace]
 resolver = "2"
 members = ["rusl", "tiny-cli", "tiny-start", "tiny-std"]
-exclude = ["test-runners/alloc-st-main", "test-runners/no-alloc-main", "test-runners/threaded-main", "test-runners/test-lib"]
+exclude = ["test-runners/alloc-st-main", "test-runners/no-alloc-main", "test-runners/threaded-main", "test-runners/test-lib"]
+

rusl/Cargo.toml

@@ -21,4 +21,4 @@ integration-test = []
 linux-rust-bindings = { version = "0.1.3", features = ["all"] }
 sc = "0.2.7"
 
-[dev-dependencies]
+[dev-dependencies]

rusl/src/futex.rs

@@ -18,7 +18,7 @@ pub fn futex_wait(
     let res = unsafe {
         syscall!(
             FUTEX,
-            uaddr as *const AtomicU32,
+            core::ptr::from_ref::<AtomicU32>(uaddr),
             FUTEX_WAIT & flags.bits().0,
             val,
             timeout
@@ -41,7 +41,7 @@ pub fn futex_wake(uaddr: &AtomicU32, num_waiters: i32) -> Result<usize, Error> {
     let res = unsafe {
         syscall!(
             FUTEX,
-            uaddr as *const AtomicU32,
+            core::ptr::from_ref::<AtomicU32>(uaddr),
             FUTEX_WAKE,
             num_waiters,
             0,

rusl/src/io_uring.rs

@@ -25,7 +25,7 @@ mod test;
 /// See the [linux documentation for details](https://man7.org/linux/man-pages//man2/io_uring_setup.2.html)  
 /// # Errors
 /// See above
-#[allow(clippy::too_many_lines)]
+#[expect(clippy::too_many_lines)]
 pub fn setup_io_uring(
     entries: u32,
     flags: IoUringParamFlags,
@@ -173,7 +173,7 @@ pub fn io_uring_setup(entries: u32, io_uring_params: &mut IoUringParams) -> Resu
         syscall!(
             IO_URING_SETUP,
             entries,
-            io_uring_params as *mut IoUringParams
+            core::ptr::from_mut::<IoUringParams>(io_uring_params)
         )
     };
     Fd::coerce_from_register(res, "`IO_URING_SETUP` syscall failed")

rusl/src/io_uring/test.rs

@@ -73,7 +73,7 @@ fn uring_register_buffer() {
     unsafe { io_uring_register_buffers(uring_fd, &[ioslice]).unwrap() };
 }
 
-#[cfg_attr(target_arch = "x86_64", allow(clippy::unnecessary_wraps))]
+#[cfg_attr(target_arch = "x86_64", expect(clippy::unnecessary_wraps))]
 fn setup_ignore_enosys(entries: u32, flags: IoUringParamFlags) -> Option<IoUring> {
     let uring = setup_io_uring(entries, flags, 0, 0);
     match uring {
@@ -98,7 +98,7 @@ fn uring_setup_instance() {
 }
 
 #[test]
-#[allow(clippy::cast_sign_loss)]
+#[expect(clippy::cast_sign_loss)]
 fn uring_single_read() {
     let Some(mut uring) = setup_ignore_enosys(8, IoUringParamFlags::empty()) else {
         return;
@@ -130,7 +130,7 @@ fn uring_single_read() {
 }
 
 #[test]
-#[allow(clippy::cast_sign_loss)]
+#[expect(clippy::cast_sign_loss)]
 fn uring_single_write() {
     let Some(mut uring) = setup_ignore_enosys(8, IoUringParamFlags::empty()) else {
         return;
@@ -364,7 +364,7 @@ fn uring_single_socket() {
 
 #[test]
 #[cfg(feature = "alloc")]
-#[allow(clippy::cast_sign_loss, clippy::too_many_lines)]
+#[expect(clippy::cast_sign_loss, clippy::too_many_lines)]
 fn uring_unix_accept_send_recv() {
     use crate::network::{bind_unix, connect_unix, listen, socket};
     let Some(mut uring) = setup_ignore_enosys(8, IoUringParamFlags::empty()) else {
@@ -491,7 +491,6 @@ fn uring_unix_accept_send_recv() {
 
 #[test]
 #[cfg(feature = "alloc")]
-#[allow(clippy::cast_sign_loss, clippy::too_many_lines)]
 fn uring_tcp_accept() {
     use crate::network::{bind_inet, listen, socket};
     const FIFTEEN: crate::platform::NonNegativeI32 =
@@ -622,7 +621,7 @@ fn uring_single_timeout() {
 }
 
 #[test]
-#[allow(clippy::cast_sign_loss)]
+#[expect(clippy::cast_sign_loss)]
 fn uring_read_registered_buffers_and_fds() {
     let mut buf1 = [0u8; 64];
     let buf1_addr = core::ptr::addr_of_mut!(buf1);
@@ -716,7 +715,7 @@ fn uring_read_registered_buffers_and_fds() {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
+#[expect(clippy::too_many_lines)]
 fn uring_write_registered_buffers_and_fds() {
     let content1 = b"Uring fixed write 1!\n";
     let mut buf1 = [0u8; 21];

rusl/src/lib.rs

@@ -1,13 +1,12 @@
-#![allow(unused_doc_comments)]
+#![expect(unused_doc_comments)]
 #![cfg_attr(not(test), no_std)]
 #![warn(clippy::pedantic)]
-#![allow(
+#![expect(
     clippy::module_name_repetitions,
     clippy::similar_names,
     clippy::cast_possible_truncation,
     clippy::cast_possible_wrap
 )]
-#![cfg_attr(test, allow(clippy::ignored_unit_patterns))]
 
 #[cfg(feature = "alloc")]
 extern crate alloc;

rusl/src/network/bind.rs

@@ -32,7 +32,7 @@ pub fn bind_inet(sock_fd: Fd, socket_address_inet: &SocketAddressInet) -> Result
         syscall!(
             BIND,
             sock_fd.0,
-            socket_address_inet as *const SocketAddressInet,
+            core::ptr::from_ref::<SocketAddressInet>(socket_address_inet),
             SocketAddressInet::LENGTH
         )
     };

rusl/src/network/connect.rs

@@ -33,7 +33,7 @@ pub fn connect_inet(sock_fd: Fd, addr: &SocketAddressInet) -> Result<()> {
         syscall!(
             CONNECT,
             sock_fd.0,
-            addr as *const SocketAddressInet,
+            core::ptr::from_ref::<SocketAddressInet>(addr),
             SocketAddressInet::LENGTH
         )
     };

rusl/src/network/socket.rs

@@ -80,7 +80,7 @@ pub fn recvmsg(sock_fd: Fd, recv: &mut crate::platform::MsgHdrBorrow, flags: i32
         syscall!(
             RECVMSG,
             sock_fd.0,
-            recv as *mut crate::platform::MsgHdrBorrow,
+            core::ptr::from_mut::<crate::platform::MsgHdrBorrow>(recv),
             flags
         )
     };