From a72c6f28b2bca44b803b95ec1e211395382c2003 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Wed, 9 Feb 2022 23:35:11 +0200 Subject: [PATCH 01/12] Use latest client for base in CI runtime upgrade test --- .github/workflows/publish-draft-releases.yml | 135 +++---------------- runtime/calamari/src/lib.rs | 2 +- runtime/manta/src/lib.rs | 2 +- 3 files changed, 23 insertions(+), 116 deletions(-) diff --git a/.github/workflows/publish-draft-releases.yml b/.github/workflows/publish-draft-releases.yml index 77c58909e..f257d7d1e 100644 --- a/.github/workflows/publish-draft-releases.yml +++ b/.github/workflows/publish-draft-releases.yml @@ -175,98 +175,6 @@ jobs: with: name: config-for-integration-test path: .github/resources/config-for-integration-test.json - - build-node-base: - needs: - - start-node-builder-base - - check-for-runtime-upgrade - runs-on: ${{ needs.start-node-builder-base.outputs.runner-label }} - env: - CARGO_TERM_COLOR: always - steps: - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - uses: actions/checkout@v2 - with: - ref: 'manta' - - - name: install sccache - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - env: - SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download - SCCACHE_VERSION: v0.2.15 - run: | - SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl - mkdir -p $HOME/.local/bin - curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz - mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache - chmod +x $HOME/.local/bin/sccache - echo "$HOME/.local/bin" >> $GITHUB_PATH - echo "$HOME/.cargo/bin" >> $GITHUB_PATH - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: cache cargo registry - uses: actions/cache@v2 - with: - path: | - ~/.cargo/registry - ~/.cargo/git - key: cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - cargo- - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: cache sccache - uses: actions/cache@v2 - continue-on-error: false - with: - path: /home/runner/.cache/sccache - key: sccache-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - sccache- - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: start sccache server - run: sccache --start-server - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: init - run: | - curl -s https://sh.rustup.rs -sSf | sh -s -- -y - source ${HOME}/.cargo/env - rustup toolchain install stable - rustup toolchain install nightly - rustup default stable - rustup target add wasm32-unknown-unknown --toolchain nightly - cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force - rustup update - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: build - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - cargo build --verbose --release - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: stop sccache server - run: sccache --stop-server || true - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: strip - run: | - strip target/release/manta - - - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: upload - uses: actions/upload-artifact@v2 - with: - name: manta-base - path: target/release/manta - name: upload uses: actions/upload-artifact@v2 @@ -276,7 +184,7 @@ jobs: runtime-upgrade-test: needs: - - build-node-base + - build-node-current - build-runtimes - start-runtime-upgrade-tester - check-for-runtime-upgrade @@ -304,17 +212,17 @@ jobs: echo "${HOME}/.local/bin" >> $GITHUB_PATH - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: fetch manta-base + name: fetch manta uses: actions/download-artifact@v2 with: - name: manta-base + name: manta - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: mv and chmod manta-base + name: mv and chmod manta run: | ls -ahl ${{ github.workspace }}/ - mv ${{ github.workspace }}/manta $HOME/.local/bin/manta-base - chmod +x $HOME/.local/bin/manta-base + mv ${{ github.workspace }}/manta $HOME/.local/bin/manta + chmod +x $HOME/.local/bin/manta ls -ahl ${{ github.workspace }}/ ls -ahl $HOME/.local/bin/ - @@ -328,20 +236,20 @@ jobs: if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} id: create-chainspec run: | - manta-base build-spec --chain ${{ matrix.runtime.chain-spec }} --disable-default-bootnode --raw > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json + manta build-spec --chain ${{ matrix.runtime.chain-spec }} --disable-default-bootnode --raw > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json jq \ --sort-keys \ - --arg name "${{ matrix.runtime.name }} testnet base" \ - --arg id ${{ matrix.runtime.chain-spec }}-base \ - --arg relay_chain rococo-local-base \ + --arg name "${{ matrix.runtime.name }} testnet" \ + --arg id ${{ matrix.runtime.chain-spec }} \ + --arg relay_chain rococo-local \ '. | .name = $name | .id = $id | .relay_chain = $relay_chain | .telemetryEndpoints = [["/dns/api.telemetry.manta.systems/tcp/443/x-parity-wss/%2Fsubmit%2F", 0]] - ' $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-spec.json + ' $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json ls -ahl $HOME/.local/share/${{ matrix.runtime.name }}-pc/ - manta-base export-state --chain $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-state.json || true + manta export-state --chain $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-state.json || true - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} name: fetch config-for-runtime-upgrade-test @@ -356,18 +264,18 @@ jobs: cat config-for-runtime-upgrade-test.json | \ jq \ --arg relaychain_bin $HOME/.local/bin/polkadot \ - --arg relaychain_id rococo-local-base \ - --arg relaychain_name "rococo local base" \ - --arg parachains_bin $HOME/.local/bin/manta-base \ - --arg parachains_spec $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-spec.json \ + --arg relaychain_id rococo-local \ + --arg relaychain_name "rococo local" \ + --arg parachains_bin $HOME/.local/bin/manta \ + --arg parachains_spec $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json \ '. | .relaychain.bin = $relaychain_bin | .relaychain.mutation.id = $relaychain_id | .relaychain.mutation.name = $relaychain_name | .parachains[].bin = $parachains_bin | .parachains[].chain = $parachains_spec - ' > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-launch-config.json - jq . $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-launch-config.json + ' > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-launch-config.json + jq . $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-launch-config.json ls -ahl $HOME/.local/share/${{ matrix.runtime.name }}-pc/ - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} @@ -393,7 +301,7 @@ jobs: --output ${{ github.workspace }}/manta-pc-launch-for-${{ matrix.runtime.chain-spec }}-stdout.log \ --error ${{ github.workspace }}/manta-pc-launch-for-${{ matrix.runtime.chain-spec }}-stderr.log \ --no-autorestart \ - -- $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-launch-config.json + -- $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-launch-config.json - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} name: init measure-block-time ${{ matrix.runtime.name }} @@ -446,9 +354,9 @@ jobs: name: check if spec version was successfully incremented run: | cd ${{ github.workspace }}/dev-tools/runtime-upgrade-test - node check_runtime_version.js --address=ws://127.0.0.1:9921 --compare_to=${{ needs.parse-runtimes.outputs.calamari-runtime-base }} + node check_runtime_version.js --address=ws://127.0.0.1:9921 --compare_to=${{ needs.parse-runtimes.outputs.calamari-runtime }} echo $? - if [ $? == 1 ]; then echo "Runtime upgrade failed, still using old spec version - ${{ needs.parse-runtimes.outputs.calamari-runtime-base }}"; exit 1; fi + if [ $? == 1 ]; then echo "Runtime upgrade failed, still using old spec version - ${{ needs.parse-runtimes.outputs.calamari-runtime }}"; exit 1; fi cd ${{ github.workspace }} - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} @@ -1013,7 +921,6 @@ jobs: stop-node-builder-base: needs: - start-node-builder-base - - build-node-base runs-on: ubuntu-20.04 if: ${{ always() }} steps: diff --git a/runtime/calamari/src/lib.rs b/runtime/calamari/src/lib.rs index 9da9da19f..897ce5f9a 100644 --- a/runtime/calamari/src/lib.rs +++ b/runtime/calamari/src/lib.rs @@ -111,7 +111,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("calamari"), impl_name: create_runtime_str!("calamari"), authoring_version: 1, - spec_version: 3130, + spec_version: 3131, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 3, diff --git a/runtime/manta/src/lib.rs b/runtime/manta/src/lib.rs index 1d546a2c3..5b348c605 100644 --- a/runtime/manta/src/lib.rs +++ b/runtime/manta/src/lib.rs @@ -110,7 +110,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("manta"), impl_name: create_runtime_str!("manta"), authoring_version: 1, - spec_version: 3130, + spec_version: 3131, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 1, From cdcd7045b5933a387c9267a60bf9b99dc313c2f1 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Thu, 10 Feb 2022 11:26:16 +0200 Subject: [PATCH 02/12] Fix test --- .github/workflows/publish-draft-releases.yml | 81 +++++--------------- 1 file changed, 20 insertions(+), 61 deletions(-) diff --git a/.github/workflows/publish-draft-releases.yml b/.github/workflows/publish-draft-releases.yml index f257d7d1e..459e6bf17 100644 --- a/.github/workflows/publish-draft-releases.yml +++ b/.github/workflows/publish-draft-releases.yml @@ -184,7 +184,7 @@ jobs: runtime-upgrade-test: needs: - - build-node-current + - build-node-base - build-runtimes - start-runtime-upgrade-tester - check-for-runtime-upgrade @@ -212,17 +212,17 @@ jobs: echo "${HOME}/.local/bin" >> $GITHUB_PATH - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: fetch manta + name: fetch manta-base uses: actions/download-artifact@v2 with: name: manta - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} - name: mv and chmod manta + name: mv and chmod manta-base run: | ls -ahl ${{ github.workspace }}/ - mv ${{ github.workspace }}/manta $HOME/.local/bin/manta - chmod +x $HOME/.local/bin/manta + mv ${{ github.workspace }}/manta $HOME/.local/bin/manta-base + chmod +x $HOME/.local/bin/manta-base ls -ahl ${{ github.workspace }}/ ls -ahl $HOME/.local/bin/ - @@ -236,20 +236,20 @@ jobs: if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} id: create-chainspec run: | - manta build-spec --chain ${{ matrix.runtime.chain-spec }} --disable-default-bootnode --raw > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json + manta-base build-spec --chain ${{ matrix.runtime.chain-spec }} --disable-default-bootnode --raw > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json jq \ --sort-keys \ - --arg name "${{ matrix.runtime.name }} testnet" \ - --arg id ${{ matrix.runtime.chain-spec }} \ - --arg relay_chain rococo-local \ + --arg name "${{ matrix.runtime.name }} testnet base" \ + --arg id ${{ matrix.runtime.chain-spec }}-base \ + --arg relay_chain rococo-local-base \ '. | .name = $name | .id = $id | .relay_chain = $relay_chain | .telemetryEndpoints = [["/dns/api.telemetry.manta.systems/tcp/443/x-parity-wss/%2Fsubmit%2F", 0]] - ' $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json + ' $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-spec.json ls -ahl $HOME/.local/share/${{ matrix.runtime.name }}-pc/ - manta export-state --chain $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-state.json || true + manta-base export-state --chain $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-spec.json > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-state.json || true - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} name: fetch config-for-runtime-upgrade-test @@ -264,18 +264,18 @@ jobs: cat config-for-runtime-upgrade-test.json | \ jq \ --arg relaychain_bin $HOME/.local/bin/polkadot \ - --arg relaychain_id rococo-local \ - --arg relaychain_name "rococo local" \ - --arg parachains_bin $HOME/.local/bin/manta \ - --arg parachains_spec $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-spec.json \ + --arg relaychain_id rococo-local-base \ + --arg relaychain_name "rococo local base" \ + --arg parachains_bin $HOME/.local/bin/manta-base \ + --arg parachains_spec $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-spec.json \ '. | .relaychain.bin = $relaychain_bin | .relaychain.mutation.id = $relaychain_id | .relaychain.mutation.name = $relaychain_name | .parachains[].bin = $parachains_bin | .parachains[].chain = $parachains_spec - ' > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-launch-config.json - jq . $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-launch-config.json + ' > $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-launch-config.json + jq . $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-launch-config.json ls -ahl $HOME/.local/share/${{ matrix.runtime.name }}-pc/ - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} @@ -301,7 +301,7 @@ jobs: --output ${{ github.workspace }}/manta-pc-launch-for-${{ matrix.runtime.chain-spec }}-stdout.log \ --error ${{ github.workspace }}/manta-pc-launch-for-${{ matrix.runtime.chain-spec }}-stderr.log \ --no-autorestart \ - -- $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-launch-config.json + -- $HOME/.local/share/${{ matrix.runtime.name }}-pc/${{ matrix.runtime.chain-spec }}-base-launch-config.json - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} name: init measure-block-time ${{ matrix.runtime.name }} @@ -354,9 +354,9 @@ jobs: name: check if spec version was successfully incremented run: | cd ${{ github.workspace }}/dev-tools/runtime-upgrade-test - node check_runtime_version.js --address=ws://127.0.0.1:9921 --compare_to=${{ needs.parse-runtimes.outputs.calamari-runtime }} + node check_runtime_version.js --address=ws://127.0.0.1:9921 --compare_to=${{ needs.parse-runtimes.outputs.calamari-runtime-base }} echo $? - if [ $? == 1 ]; then echo "Runtime upgrade failed, still using old spec version - ${{ needs.parse-runtimes.outputs.calamari-runtime }}"; exit 1; fi + if [ $? == 1 ]; then echo "Runtime upgrade failed, still using old spec version - ${{ needs.parse-runtimes.outputs.calamari-runtime-base }}"; exit 1; fi cd ${{ github.workspace }} - if: ${{ needs.check-for-runtime-upgrade.outputs.do-versions-match == 'false' }} @@ -894,47 +894,6 @@ jobs: runner-label: ${{ needs.start-node-builder-current.outputs.runner-label }} aws-instance-id: ${{ needs.start-node-builder-current.outputs.aws-instance-id }} - start-node-builder-base: - runs-on: ubuntu-20.04 - outputs: - runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} - aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} - aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} - steps: - - - id: start-self-hosted-runner - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: start - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-instance-ssh-public-key: ${{ env.AWS_INSTANCE_SSH_PUBLIC_KEY }} - aws-region: ${{ env.AWS_REGION }} - aws-subnet-id: ${{ env.AWS_SUBNET_ID }} - aws-security-group-id: ${{ env.AWS_SECURITY_GROUP_ID }} - aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} # 32 vcpu, 64gb ram, $1.392 hourly - aws-instance-root-volume-size: 32 - aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} - aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical - - stop-node-builder-base: - needs: - - start-node-builder-base - runs-on: ubuntu-20.04 - if: ${{ always() }} - steps: - - - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: stop - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ needs.start-node-builder-base.outputs.aws-region }} - runner-label: ${{ needs.start-node-builder-base.outputs.runner-label }} - aws-instance-id: ${{ needs.start-node-builder-base.outputs.aws-instance-id }} - start-integration-tester: runs-on: ubuntu-20.04 outputs: From b6f89126f2bc4c338b905f506f56b9eb7898e4f6 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Thu, 10 Feb 2022 11:28:27 +0200 Subject: [PATCH 03/12] Remove build and test checks temporariliy --- .github/workflows/check_build.yml | 136 ------------------- .github/workflows/check_tests.yml | 121 ----------------- .github/workflows/publish-draft-releases.yml | 1 - 3 files changed, 258 deletions(-) delete mode 100644 .github/workflows/check_build.yml delete mode 100644 .github/workflows/check_tests.yml diff --git a/.github/workflows/check_build.yml b/.github/workflows/check_build.yml deleted file mode 100644 index dd59d706a..000000000 --- a/.github/workflows/check_build.yml +++ /dev/null @@ -1,136 +0,0 @@ ---- - -# yamllint disable rule:line-length - -name: Check Build - -# yamllint disable-line rule:truthy -on: - pull_request: - branches: [manta] - push: - branches: [manta] - -env: - AWS_REGION: us-east-1 - AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly - AWS_INSTANCE_ROOT_VOLUME_SIZE: 32 - AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* - AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical - -jobs: - - start-checks: - runs-on: ubuntu-20.04 - outputs: - runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} - aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} - aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} - steps: - - - id: start-self-hosted-runner - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: start - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ env.AWS_REGION }} - aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} - aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} - aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} - aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical - - - uses: actions/checkout@v2 - - - name: install sccache - - env: - SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download - SCCACHE_VERSION: v0.2.15 - run: | - SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl - mkdir -p $HOME/.local/bin - curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz - mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache - chmod +x $HOME/.local/bin/sccache - echo "$HOME/.local/bin" >> $GITHUB_PATH - echo "$HOME/.cargo/bin" >> $GITHUB_PATH - - - name: cache cargo registry - uses: actions/cache@v2 - with: - path: | - ~/.cargo/registry - ~/.cargo/git - key: cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - cargo- - - - name: cache sccache - uses: actions/cache@v2 - continue-on-error: false - with: - path: /home/runner/.cache/sccache - key: sccache-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - sccache- - - - name: start sccache server - run: sccache --start-server - - - name: init - run: | - curl -s https://sh.rustup.rs -sSf | sh -s -- -y - source ${HOME}/.cargo/env - rustup toolchain install stable - rustup toolchain install nightly - rustup default stable - rustup target add wasm32-unknown-unknown --toolchain nightly - cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force - rustup update - - - name: Run yamllint - uses: actionshub/yamllint@main - - - name: Check Clippy & Formatting - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - SKIP_WASM_BUILD=1 cargo clippy - SKIP_WASM_BUILD=1 cargo fmt - - - name: Check Build - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - cargo check --no-default-features - cargo check --all-features - - - name: stop sccache server - run: sccache --stop-server || true - - stop-checks: - needs: - - start-checks - runs-on: ubuntu-20.04 - if: ${{ always() }} - steps: - - - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: stop - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ needs.start-checks.outputs.aws-region }} - runner-label: ${{ needs.start-checks.outputs.runner-label }} - aws-instance-id: ${{ needs.start-checks.outputs.aws-instance-id }} diff --git a/.github/workflows/check_tests.yml b/.github/workflows/check_tests.yml deleted file mode 100644 index b2d27c79f..000000000 --- a/.github/workflows/check_tests.yml +++ /dev/null @@ -1,121 +0,0 @@ ---- - -# yamllint disable rule:line-length - -name: Run Tests - -# yamllint disable-line rule:truthy -on: - pull_request: - branches: [manta] - push: - branches: [manta] - -env: - AWS_REGION: us-east-1 - AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly - AWS_INSTANCE_ROOT_VOLUME_SIZE: 64 - AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* - AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical - -jobs: - - start-unit-test-checks: - runs-on: ubuntu-20.04 - outputs: - runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} - aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} - aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} - steps: - - - id: start-self-hosted-runner - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: start - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ env.AWS_REGION }} - aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} - aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} - aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} - aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical - - - uses: actions/checkout@v2 - - - name: install sccache - - env: - SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download - SCCACHE_VERSION: v0.2.15 - run: | - SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl - mkdir -p $HOME/.local/bin - curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz - mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache - chmod +x $HOME/.local/bin/sccache - echo "$HOME/.local/bin" >> $GITHUB_PATH - echo "$HOME/.cargo/bin" >> $GITHUB_PATH - - - name: cache cargo registry - uses: actions/cache@v2 - with: - path: | - ~/.cargo/registry - ~/.cargo/git - key: cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - cargo- - - - name: cache sccache - uses: actions/cache@v2 - continue-on-error: false - with: - path: /home/runner/.cache/sccache - key: sccache-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - sccache- - - - name: start sccache server - run: sccache --start-server - - - name: init - run: | - curl -s https://sh.rustup.rs -sSf | sh -s -- -y - source ${HOME}/.cargo/env - rustup toolchain install stable - rustup toolchain install nightly - rustup default stable - rustup target add wasm32-unknown-unknown --toolchain nightly - cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force - rustup update - - - name: Run Unit Tests - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - cargo test --all-features - - - name: stop sccache server - run: sccache --stop-server || true - - stop-unit-test-checks: - needs: - - start-unit-test-checks - runs-on: ubuntu-20.04 - if: ${{ always() }} - steps: - - - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: stop - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ needs.start-unit-test-checks.outputs.aws-region }} - runner-label: ${{ needs.start-unit-test-checks.outputs.runner-label }} - aws-instance-id: ${{ needs.start-unit-test-checks.outputs.aws-instance-id }} diff --git a/.github/workflows/publish-draft-releases.yml b/.github/workflows/publish-draft-releases.yml index 459e6bf17..8c065a255 100644 --- a/.github/workflows/publish-draft-releases.yml +++ b/.github/workflows/publish-draft-releases.yml @@ -184,7 +184,6 @@ jobs: runtime-upgrade-test: needs: - - build-node-base - build-runtimes - start-runtime-upgrade-tester - check-for-runtime-upgrade From bfd8d2ec15ef24d370e9d930439e4ed81404f364 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Thu, 10 Feb 2022 11:34:50 +0200 Subject: [PATCH 04/12] Revert temporary changes --- .github/workflows/check_build.yml | 136 ++++++++++++++++++++++++++++++ .github/workflows/check_tests.yml | 121 ++++++++++++++++++++++++++ runtime/calamari/src/lib.rs | 2 +- runtime/manta/src/lib.rs | 2 +- 4 files changed, 259 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/check_build.yml create mode 100644 .github/workflows/check_tests.yml diff --git a/.github/workflows/check_build.yml b/.github/workflows/check_build.yml new file mode 100644 index 000000000..dd59d706a --- /dev/null +++ b/.github/workflows/check_build.yml @@ -0,0 +1,136 @@ +--- + +# yamllint disable rule:line-length + +name: Check Build + +# yamllint disable-line rule:truthy +on: + pull_request: + branches: [manta] + push: + branches: [manta] + +env: + AWS_REGION: us-east-1 + AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly + AWS_INSTANCE_ROOT_VOLUME_SIZE: 32 + AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* + AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical + +jobs: + + start-checks: + runs-on: ubuntu-20.04 + outputs: + runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} + aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} + aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} + steps: + - + id: start-self-hosted-runner + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: start + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ env.AWS_REGION }} + aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} + aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} + aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} + aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical + - + uses: actions/checkout@v2 + - + name: install sccache + + env: + SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download + SCCACHE_VERSION: v0.2.15 + run: | + SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl + mkdir -p $HOME/.local/bin + curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz + mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache + chmod +x $HOME/.local/bin/sccache + echo "$HOME/.local/bin" >> $GITHUB_PATH + echo "$HOME/.cargo/bin" >> $GITHUB_PATH + - + name: cache cargo registry + uses: actions/cache@v2 + with: + path: | + ~/.cargo/registry + ~/.cargo/git + key: cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + cargo- + - + name: cache sccache + uses: actions/cache@v2 + continue-on-error: false + with: + path: /home/runner/.cache/sccache + key: sccache-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + sccache- + - + name: start sccache server + run: sccache --start-server + - + name: init + run: | + curl -s https://sh.rustup.rs -sSf | sh -s -- -y + source ${HOME}/.cargo/env + rustup toolchain install stable + rustup toolchain install nightly + rustup default stable + rustup target add wasm32-unknown-unknown --toolchain nightly + cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force + rustup update + - + name: Run yamllint + uses: actionshub/yamllint@main + - + name: Check Clippy & Formatting + env: + RUST_BACKTRACE: full + RUSTC_WRAPPER: sccache + SCCACHE_CACHE_SIZE: 2G + SCCACHE_DIR: /home/runner/.cache/sccache + run: | + source ${HOME}/.cargo/env + SKIP_WASM_BUILD=1 cargo clippy + SKIP_WASM_BUILD=1 cargo fmt + - + name: Check Build + env: + RUST_BACKTRACE: full + RUSTC_WRAPPER: sccache + SCCACHE_CACHE_SIZE: 2G + SCCACHE_DIR: /home/runner/.cache/sccache + run: | + source ${HOME}/.cargo/env + cargo check --no-default-features + cargo check --all-features + - + name: stop sccache server + run: sccache --stop-server || true + + stop-checks: + needs: + - start-checks + runs-on: ubuntu-20.04 + if: ${{ always() }} + steps: + - + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: stop + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ needs.start-checks.outputs.aws-region }} + runner-label: ${{ needs.start-checks.outputs.runner-label }} + aws-instance-id: ${{ needs.start-checks.outputs.aws-instance-id }} diff --git a/.github/workflows/check_tests.yml b/.github/workflows/check_tests.yml new file mode 100644 index 000000000..b2d27c79f --- /dev/null +++ b/.github/workflows/check_tests.yml @@ -0,0 +1,121 @@ +--- + +# yamllint disable rule:line-length + +name: Run Tests + +# yamllint disable-line rule:truthy +on: + pull_request: + branches: [manta] + push: + branches: [manta] + +env: + AWS_REGION: us-east-1 + AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly + AWS_INSTANCE_ROOT_VOLUME_SIZE: 64 + AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* + AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical + +jobs: + + start-unit-test-checks: + runs-on: ubuntu-20.04 + outputs: + runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} + aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} + aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} + steps: + - + id: start-self-hosted-runner + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: start + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ env.AWS_REGION }} + aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} + aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} + aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} + aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical + - + uses: actions/checkout@v2 + - + name: install sccache + + env: + SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download + SCCACHE_VERSION: v0.2.15 + run: | + SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl + mkdir -p $HOME/.local/bin + curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz + mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache + chmod +x $HOME/.local/bin/sccache + echo "$HOME/.local/bin" >> $GITHUB_PATH + echo "$HOME/.cargo/bin" >> $GITHUB_PATH + - + name: cache cargo registry + uses: actions/cache@v2 + with: + path: | + ~/.cargo/registry + ~/.cargo/git + key: cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + cargo- + - + name: cache sccache + uses: actions/cache@v2 + continue-on-error: false + with: + path: /home/runner/.cache/sccache + key: sccache-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + sccache- + - + name: start sccache server + run: sccache --start-server + - + name: init + run: | + curl -s https://sh.rustup.rs -sSf | sh -s -- -y + source ${HOME}/.cargo/env + rustup toolchain install stable + rustup toolchain install nightly + rustup default stable + rustup target add wasm32-unknown-unknown --toolchain nightly + cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force + rustup update + - + name: Run Unit Tests + env: + RUST_BACKTRACE: full + RUSTC_WRAPPER: sccache + SCCACHE_CACHE_SIZE: 2G + SCCACHE_DIR: /home/runner/.cache/sccache + run: | + source ${HOME}/.cargo/env + cargo test --all-features + - + name: stop sccache server + run: sccache --stop-server || true + + stop-unit-test-checks: + needs: + - start-unit-test-checks + runs-on: ubuntu-20.04 + if: ${{ always() }} + steps: + - + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: stop + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ needs.start-unit-test-checks.outputs.aws-region }} + runner-label: ${{ needs.start-unit-test-checks.outputs.runner-label }} + aws-instance-id: ${{ needs.start-unit-test-checks.outputs.aws-instance-id }} diff --git a/runtime/calamari/src/lib.rs b/runtime/calamari/src/lib.rs index 897ce5f9a..9da9da19f 100644 --- a/runtime/calamari/src/lib.rs +++ b/runtime/calamari/src/lib.rs @@ -111,7 +111,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("calamari"), impl_name: create_runtime_str!("calamari"), authoring_version: 1, - spec_version: 3131, + spec_version: 3130, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 3, diff --git a/runtime/manta/src/lib.rs b/runtime/manta/src/lib.rs index 5b348c605..1d546a2c3 100644 --- a/runtime/manta/src/lib.rs +++ b/runtime/manta/src/lib.rs @@ -110,7 +110,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("manta"), impl_name: create_runtime_str!("manta"), authoring_version: 1, - spec_version: 3131, + spec_version: 3130, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 1, From 8fd064ecad330bb28e4c2fc380613857e1e7e9b2 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Thu, 10 Feb 2022 11:42:13 +0200 Subject: [PATCH 05/12] Fix --- .github/workflows/check_build.yml | 136 ------------------- .github/workflows/check_tests.yml | 121 ----------------- .github/workflows/publish-draft-releases.yml | 1 + runtime/calamari/src/lib.rs | 2 +- runtime/manta/src/lib.rs | 2 +- 5 files changed, 3 insertions(+), 259 deletions(-) delete mode 100644 .github/workflows/check_build.yml delete mode 100644 .github/workflows/check_tests.yml diff --git a/.github/workflows/check_build.yml b/.github/workflows/check_build.yml deleted file mode 100644 index dd59d706a..000000000 --- a/.github/workflows/check_build.yml +++ /dev/null @@ -1,136 +0,0 @@ ---- - -# yamllint disable rule:line-length - -name: Check Build - -# yamllint disable-line rule:truthy -on: - pull_request: - branches: [manta] - push: - branches: [manta] - -env: - AWS_REGION: us-east-1 - AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly - AWS_INSTANCE_ROOT_VOLUME_SIZE: 32 - AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* - AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical - -jobs: - - start-checks: - runs-on: ubuntu-20.04 - outputs: - runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} - aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} - aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} - steps: - - - id: start-self-hosted-runner - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: start - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ env.AWS_REGION }} - aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} - aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} - aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} - aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical - - - uses: actions/checkout@v2 - - - name: install sccache - - env: - SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download - SCCACHE_VERSION: v0.2.15 - run: | - SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl - mkdir -p $HOME/.local/bin - curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz - mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache - chmod +x $HOME/.local/bin/sccache - echo "$HOME/.local/bin" >> $GITHUB_PATH - echo "$HOME/.cargo/bin" >> $GITHUB_PATH - - - name: cache cargo registry - uses: actions/cache@v2 - with: - path: | - ~/.cargo/registry - ~/.cargo/git - key: cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - cargo- - - - name: cache sccache - uses: actions/cache@v2 - continue-on-error: false - with: - path: /home/runner/.cache/sccache - key: sccache-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - sccache- - - - name: start sccache server - run: sccache --start-server - - - name: init - run: | - curl -s https://sh.rustup.rs -sSf | sh -s -- -y - source ${HOME}/.cargo/env - rustup toolchain install stable - rustup toolchain install nightly - rustup default stable - rustup target add wasm32-unknown-unknown --toolchain nightly - cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force - rustup update - - - name: Run yamllint - uses: actionshub/yamllint@main - - - name: Check Clippy & Formatting - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - SKIP_WASM_BUILD=1 cargo clippy - SKIP_WASM_BUILD=1 cargo fmt - - - name: Check Build - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - cargo check --no-default-features - cargo check --all-features - - - name: stop sccache server - run: sccache --stop-server || true - - stop-checks: - needs: - - start-checks - runs-on: ubuntu-20.04 - if: ${{ always() }} - steps: - - - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: stop - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ needs.start-checks.outputs.aws-region }} - runner-label: ${{ needs.start-checks.outputs.runner-label }} - aws-instance-id: ${{ needs.start-checks.outputs.aws-instance-id }} diff --git a/.github/workflows/check_tests.yml b/.github/workflows/check_tests.yml deleted file mode 100644 index b2d27c79f..000000000 --- a/.github/workflows/check_tests.yml +++ /dev/null @@ -1,121 +0,0 @@ ---- - -# yamllint disable rule:line-length - -name: Run Tests - -# yamllint disable-line rule:truthy -on: - pull_request: - branches: [manta] - push: - branches: [manta] - -env: - AWS_REGION: us-east-1 - AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly - AWS_INSTANCE_ROOT_VOLUME_SIZE: 64 - AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* - AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical - -jobs: - - start-unit-test-checks: - runs-on: ubuntu-20.04 - outputs: - runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} - aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} - aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} - steps: - - - id: start-self-hosted-runner - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: start - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ env.AWS_REGION }} - aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} - aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} - aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} - aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical - - - uses: actions/checkout@v2 - - - name: install sccache - - env: - SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download - SCCACHE_VERSION: v0.2.15 - run: | - SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl - mkdir -p $HOME/.local/bin - curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz - mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache - chmod +x $HOME/.local/bin/sccache - echo "$HOME/.local/bin" >> $GITHUB_PATH - echo "$HOME/.cargo/bin" >> $GITHUB_PATH - - - name: cache cargo registry - uses: actions/cache@v2 - with: - path: | - ~/.cargo/registry - ~/.cargo/git - key: cargo-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - cargo- - - - name: cache sccache - uses: actions/cache@v2 - continue-on-error: false - with: - path: /home/runner/.cache/sccache - key: sccache-${{ hashFiles('**/Cargo.lock') }} - restore-keys: | - sccache- - - - name: start sccache server - run: sccache --start-server - - - name: init - run: | - curl -s https://sh.rustup.rs -sSf | sh -s -- -y - source ${HOME}/.cargo/env - rustup toolchain install stable - rustup toolchain install nightly - rustup default stable - rustup target add wasm32-unknown-unknown --toolchain nightly - cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force - rustup update - - - name: Run Unit Tests - env: - RUST_BACKTRACE: full - RUSTC_WRAPPER: sccache - SCCACHE_CACHE_SIZE: 2G - SCCACHE_DIR: /home/runner/.cache/sccache - run: | - source ${HOME}/.cargo/env - cargo test --all-features - - - name: stop sccache server - run: sccache --stop-server || true - - stop-unit-test-checks: - needs: - - start-unit-test-checks - runs-on: ubuntu-20.04 - if: ${{ always() }} - steps: - - - uses: audacious-network/aws-github-runner@v1.0.33 - with: - mode: stop - github-token: ${{ secrets.GH_SHR_TOKEN }} - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ${{ needs.start-unit-test-checks.outputs.aws-region }} - runner-label: ${{ needs.start-unit-test-checks.outputs.runner-label }} - aws-instance-id: ${{ needs.start-unit-test-checks.outputs.aws-instance-id }} diff --git a/.github/workflows/publish-draft-releases.yml b/.github/workflows/publish-draft-releases.yml index 8c065a255..3c5d47a4b 100644 --- a/.github/workflows/publish-draft-releases.yml +++ b/.github/workflows/publish-draft-releases.yml @@ -184,6 +184,7 @@ jobs: runtime-upgrade-test: needs: + - build-node-current - build-runtimes - start-runtime-upgrade-tester - check-for-runtime-upgrade diff --git a/runtime/calamari/src/lib.rs b/runtime/calamari/src/lib.rs index 9da9da19f..897ce5f9a 100644 --- a/runtime/calamari/src/lib.rs +++ b/runtime/calamari/src/lib.rs @@ -111,7 +111,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("calamari"), impl_name: create_runtime_str!("calamari"), authoring_version: 1, - spec_version: 3130, + spec_version: 3131, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 3, diff --git a/runtime/manta/src/lib.rs b/runtime/manta/src/lib.rs index 1d546a2c3..5b348c605 100644 --- a/runtime/manta/src/lib.rs +++ b/runtime/manta/src/lib.rs @@ -110,7 +110,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("manta"), impl_name: create_runtime_str!("manta"), authoring_version: 1, - spec_version: 3130, + spec_version: 3131, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 1, From 44606c6123cbb7a8b3fc6a080437b5ad8041fe30 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Thu, 10 Feb 2022 12:32:07 +0200 Subject: [PATCH 06/12] Revert temp changes --- .github/workflows/check_build.yml | 136 ++++++++++++++++++++++++++++++ .github/workflows/check_tests.yml | 121 ++++++++++++++++++++++++++ runtime/calamari/src/lib.rs | 2 +- runtime/manta/src/lib.rs | 2 +- 4 files changed, 259 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/check_build.yml create mode 100644 .github/workflows/check_tests.yml diff --git a/.github/workflows/check_build.yml b/.github/workflows/check_build.yml new file mode 100644 index 000000000..dd59d706a --- /dev/null +++ b/.github/workflows/check_build.yml @@ -0,0 +1,136 @@ +--- + +# yamllint disable rule:line-length + +name: Check Build + +# yamllint disable-line rule:truthy +on: + pull_request: + branches: [manta] + push: + branches: [manta] + +env: + AWS_REGION: us-east-1 + AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly + AWS_INSTANCE_ROOT_VOLUME_SIZE: 32 + AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* + AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical + +jobs: + + start-checks: + runs-on: ubuntu-20.04 + outputs: + runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} + aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} + aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} + steps: + - + id: start-self-hosted-runner + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: start + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ env.AWS_REGION }} + aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} + aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} + aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} + aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical + - + uses: actions/checkout@v2 + - + name: install sccache + + env: + SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download + SCCACHE_VERSION: v0.2.15 + run: | + SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl + mkdir -p $HOME/.local/bin + curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz + mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache + chmod +x $HOME/.local/bin/sccache + echo "$HOME/.local/bin" >> $GITHUB_PATH + echo "$HOME/.cargo/bin" >> $GITHUB_PATH + - + name: cache cargo registry + uses: actions/cache@v2 + with: + path: | + ~/.cargo/registry + ~/.cargo/git + key: cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + cargo- + - + name: cache sccache + uses: actions/cache@v2 + continue-on-error: false + with: + path: /home/runner/.cache/sccache + key: sccache-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + sccache- + - + name: start sccache server + run: sccache --start-server + - + name: init + run: | + curl -s https://sh.rustup.rs -sSf | sh -s -- -y + source ${HOME}/.cargo/env + rustup toolchain install stable + rustup toolchain install nightly + rustup default stable + rustup target add wasm32-unknown-unknown --toolchain nightly + cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force + rustup update + - + name: Run yamllint + uses: actionshub/yamllint@main + - + name: Check Clippy & Formatting + env: + RUST_BACKTRACE: full + RUSTC_WRAPPER: sccache + SCCACHE_CACHE_SIZE: 2G + SCCACHE_DIR: /home/runner/.cache/sccache + run: | + source ${HOME}/.cargo/env + SKIP_WASM_BUILD=1 cargo clippy + SKIP_WASM_BUILD=1 cargo fmt + - + name: Check Build + env: + RUST_BACKTRACE: full + RUSTC_WRAPPER: sccache + SCCACHE_CACHE_SIZE: 2G + SCCACHE_DIR: /home/runner/.cache/sccache + run: | + source ${HOME}/.cargo/env + cargo check --no-default-features + cargo check --all-features + - + name: stop sccache server + run: sccache --stop-server || true + + stop-checks: + needs: + - start-checks + runs-on: ubuntu-20.04 + if: ${{ always() }} + steps: + - + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: stop + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ needs.start-checks.outputs.aws-region }} + runner-label: ${{ needs.start-checks.outputs.runner-label }} + aws-instance-id: ${{ needs.start-checks.outputs.aws-instance-id }} diff --git a/.github/workflows/check_tests.yml b/.github/workflows/check_tests.yml new file mode 100644 index 000000000..b2d27c79f --- /dev/null +++ b/.github/workflows/check_tests.yml @@ -0,0 +1,121 @@ +--- + +# yamllint disable rule:line-length + +name: Run Tests + +# yamllint disable-line rule:truthy +on: + pull_request: + branches: [manta] + push: + branches: [manta] + +env: + AWS_REGION: us-east-1 + AWS_INSTANCE_TYPE: c5a.8xlarge # 32 vcpu, 64gb ram, $1.392 hourly + AWS_INSTANCE_ROOT_VOLUME_SIZE: 64 + AWS_IMAGE_SEARCH_PATTERN: ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-* + AWS_IMAGE_SEARCH_OWNERS: '["099720109477"]' # canonical + +jobs: + + start-unit-test-checks: + runs-on: ubuntu-20.04 + outputs: + runner-label: ${{ steps.start-self-hosted-runner.outputs.runner-label }} + aws-region: ${{ steps.start-self-hosted-runner.outputs.aws-region }} + aws-instance-id: ${{ steps.start-self-hosted-runner.outputs.aws-instance-id }} + steps: + - + id: start-self-hosted-runner + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: start + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ env.AWS_REGION }} + aws-instance-type: ${{ env.AWS_INSTANCE_TYPE }} + aws-instance-root-volume-size: ${{ env.AWS_INSTANCE_ROOT_VOLUME_SIZE }} + aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }} + aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }} # canonical + - + uses: actions/checkout@v2 + - + name: install sccache + + env: + SCCACHE_RELEASE_URL: https://github.com/mozilla/sccache/releases/download + SCCACHE_VERSION: v0.2.15 + run: | + SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl + mkdir -p $HOME/.local/bin + curl -L "$SCCACHE_RELEASE_URL/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz + mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache + chmod +x $HOME/.local/bin/sccache + echo "$HOME/.local/bin" >> $GITHUB_PATH + echo "$HOME/.cargo/bin" >> $GITHUB_PATH + - + name: cache cargo registry + uses: actions/cache@v2 + with: + path: | + ~/.cargo/registry + ~/.cargo/git + key: cargo-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + cargo- + - + name: cache sccache + uses: actions/cache@v2 + continue-on-error: false + with: + path: /home/runner/.cache/sccache + key: sccache-${{ hashFiles('**/Cargo.lock') }} + restore-keys: | + sccache- + - + name: start sccache server + run: sccache --start-server + - + name: init + run: | + curl -s https://sh.rustup.rs -sSf | sh -s -- -y + source ${HOME}/.cargo/env + rustup toolchain install stable + rustup toolchain install nightly + rustup default stable + rustup target add wasm32-unknown-unknown --toolchain nightly + cargo +nightly install --git https://github.com/alexcrichton/wasm-gc --force + rustup update + - + name: Run Unit Tests + env: + RUST_BACKTRACE: full + RUSTC_WRAPPER: sccache + SCCACHE_CACHE_SIZE: 2G + SCCACHE_DIR: /home/runner/.cache/sccache + run: | + source ${HOME}/.cargo/env + cargo test --all-features + - + name: stop sccache server + run: sccache --stop-server || true + + stop-unit-test-checks: + needs: + - start-unit-test-checks + runs-on: ubuntu-20.04 + if: ${{ always() }} + steps: + - + uses: audacious-network/aws-github-runner@v1.0.33 + with: + mode: stop + github-token: ${{ secrets.GH_SHR_TOKEN }} + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + aws-region: ${{ needs.start-unit-test-checks.outputs.aws-region }} + runner-label: ${{ needs.start-unit-test-checks.outputs.runner-label }} + aws-instance-id: ${{ needs.start-unit-test-checks.outputs.aws-instance-id }} diff --git a/runtime/calamari/src/lib.rs b/runtime/calamari/src/lib.rs index 897ce5f9a..9da9da19f 100644 --- a/runtime/calamari/src/lib.rs +++ b/runtime/calamari/src/lib.rs @@ -111,7 +111,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("calamari"), impl_name: create_runtime_str!("calamari"), authoring_version: 1, - spec_version: 3131, + spec_version: 3130, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 3, diff --git a/runtime/manta/src/lib.rs b/runtime/manta/src/lib.rs index 5b348c605..1d546a2c3 100644 --- a/runtime/manta/src/lib.rs +++ b/runtime/manta/src/lib.rs @@ -110,7 +110,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { spec_name: create_runtime_str!("manta"), impl_name: create_runtime_str!("manta"), authoring_version: 1, - spec_version: 3131, + spec_version: 3130, impl_version: 1, apis: RUNTIME_API_VERSIONS, transaction_version: 1, From f95684b222846eadd1e43fe23e96ce4089d15069 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Wed, 16 Feb 2022 17:11:02 +0200 Subject: [PATCH 07/12] Reduce expected blocks for integration-tests CI workflow, in order to reduce false positives --- .github/workflows/publish-draft-releases.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-draft-releases.yml b/.github/workflows/publish-draft-releases.yml index e2d978204..628bd38bc 100644 --- a/.github/workflows/publish-draft-releases.yml +++ b/.github/workflows/publish-draft-releases.yml @@ -402,8 +402,8 @@ jobs: id: calamari-local expected: block-count: - relay: 25 - para: 6 + relay: 20 + para: 2 peer-count: relay: 5 para: 2 @@ -411,8 +411,8 @@ jobs: id: calamari-dev expected: block-count: - relay: 25 - para: 6 + relay: 20 + para: 2 peer-count: relay: 5 para: 2 From 514b2c80832592367504bb7ba5d52941e3d95d3e Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Thu, 17 Feb 2022 21:16:02 +0200 Subject: [PATCH 08/12] Remove unnecessary lines in the PR template --- .github/PULL_REQUEST_TEMPLATE.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 21ad57552..762013206 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,7 +18,6 @@ Before we can merge this PR, please make sure that all the following items have checked off. If any of the checklist items are not applicable, please leave them but write a little note why. -- [ ] Targeted PR against correct branch (`manta` or `dolphin`) with right title (start with [Manta] or [Dolphin]), - [ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work. - [ ] Wrote unit tests. - [ ] Updated relevant documentation in the code. @@ -28,10 +27,7 @@ write a little note why. * `spec_version`: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native. * `impl_version`: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing. * `transaction_version`: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated -- [ ] If needed, notify the committer this is a draft-release and a tag is needed after merging the PR. - [ ] Verify benchmarks & weights have been updated for any modified runtime logics -- [ ] If needed, bump `version` for every crate. - [ ] If import a new pallet, choose a proper module index for it, and allow it in `BaseFilter`. Ensure **every** extrinsic works from front-end. If there's corresponding tool, ensure both work for each other. - [ ] If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers. -- [ ] If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing. -- [ ] Check if inheriting any upstream runtime storage migrations. If any, perform tests with `try-runtime`. \ No newline at end of file +- [ ] When integrating upstream changes check if you are inheriting runtime storage migrations. If any, perform tests with `try-runtime`. \ No newline at end of file From 6c864ba7ed910afc726bef709746f35e46927e86 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Fri, 18 Feb 2022 09:41:23 +0200 Subject: [PATCH 09/12] Move someo of the chelist items from PR template to Release template --- .github/ISSUE_TEMPLATE/release.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/release.md b/.github/ISSUE_TEMPLATE/release.md index 49412d10b..390fb817f 100644 --- a/.github/ISSUE_TEMPLATE/release.md +++ b/.github/ISSUE_TEMPLATE/release.md @@ -10,8 +10,7 @@ of the Calamari/Manta runtime or client. Some need to be completed after the new ### Runtime Releases -These checks should be performed on the codebase prior to forking to a release- -candidate branch. +These checks should be performed on the codebase prior to freezing our release candidate: - [ ] Verify [`spec_version`](#spec-version) has been incremented since the last release for any native runtimes from any existing use on public @@ -24,7 +23,9 @@ candidate branch. runtime logic. - [ ] Check for any upstream storage migrations and perform tests with `try-runtime`, if any. -The following checks can be performed after we have forked off to the release branch. +The following checks can be performed after we have frozen our release candidate: + +- [ ] Code freeze should typically happen one week prior to rlease, to ensure we have enough time for related testing. - [ ] Complete the following [manual QA workflow](https://hackmd.io/TbFmorG2RnOPmLuFcg9JOQ?view). - [ ] Verify [Polkadot JS API](#polkadot-js) are up to date with the latest runtime changes. @@ -32,10 +33,13 @@ The following checks can be performed after we have forked off to the release br - [ ] Execute runtime upgrade to Baikal and verify network stability. - [ ] Prepare a governance post and submit to our forum with description and motivation for changes. +### Client Releases + +- [ ] Verify that each crate's `version` has been bumped from previous release. +- [ ] Check that the new client versions have [run on the network](#burn-in) without issue for 12 hours. + ### All Releases -- [ ] Check that the new client versions have [run on the network](#burn-in) - without issue for 12 hours. - [ ] Check that a draft release has been created at https://github.com/Manta-Network/Manta/releases with relevant [release notes](#release-notes) From 763ea053b387ce96f8173edf9a38357b0bf7d942 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Mon, 21 Feb 2022 10:35:33 +0200 Subject: [PATCH 10/12] Spelling correction --- .github/ISSUE_TEMPLATE/release.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/release.md b/.github/ISSUE_TEMPLATE/release.md index 390fb817f..d0553e780 100644 --- a/.github/ISSUE_TEMPLATE/release.md +++ b/.github/ISSUE_TEMPLATE/release.md @@ -25,7 +25,7 @@ These checks should be performed on the codebase prior to freezing our release c The following checks can be performed after we have frozen our release candidate: -- [ ] Code freeze should typically happen one week prior to rlease, to ensure we have enough time for related testing. +- [ ] Code freeze should typically happen one week prior to release, to ensure we have enough time for related testing. - [ ] Complete the following [manual QA workflow](https://hackmd.io/TbFmorG2RnOPmLuFcg9JOQ?view). - [ ] Verify [Polkadot JS API](#polkadot-js) are up to date with the latest runtime changes. From e9f149ca905bf0189e2e97c3254e6a14ddbcc235 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Tue, 1 Mar 2022 11:35:30 +0200 Subject: [PATCH 11/12] Revert change to target relay and para blocks in integration test --- .github/workflows/publish-draft-releases.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-draft-releases.yml b/.github/workflows/publish-draft-releases.yml index 628bd38bc..e2d978204 100644 --- a/.github/workflows/publish-draft-releases.yml +++ b/.github/workflows/publish-draft-releases.yml @@ -402,8 +402,8 @@ jobs: id: calamari-local expected: block-count: - relay: 20 - para: 2 + relay: 25 + para: 6 peer-count: relay: 5 para: 2 @@ -411,8 +411,8 @@ jobs: id: calamari-dev expected: block-count: - relay: 20 - para: 2 + relay: 25 + para: 6 peer-count: relay: 5 para: 2 From 2275fed2c34ad9c8e84cced942921e3d5ea24512 Mon Sep 17 00:00:00 2001 From: ghzlatarev Date: Tue, 1 Mar 2022 20:47:00 +0200 Subject: [PATCH 12/12] Be more specific about code freeze and runtime migration checks --- .github/ISSUE_TEMPLATE/release.md | 1 + .github/PULL_REQUEST_TEMPLATE.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/release.md b/.github/ISSUE_TEMPLATE/release.md index d0553e780..4b44bf82b 100644 --- a/.github/ISSUE_TEMPLATE/release.md +++ b/.github/ISSUE_TEMPLATE/release.md @@ -26,6 +26,7 @@ These checks should be performed on the codebase prior to freezing our release c The following checks can be performed after we have frozen our release candidate: - [ ] Code freeze should typically happen one week prior to release, to ensure we have enough time for related testing. +- [ ] Notify everyone, especially people with merge rights to `manta` (stechu, Dengjianping) that a release is ongoing and no more merges to `manta` should happen until told otherwise - [ ] Complete the following [manual QA workflow](https://hackmd.io/TbFmorG2RnOPmLuFcg9JOQ?view). - [ ] Verify [Polkadot JS API](#polkadot-js) are up to date with the latest runtime changes. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0f588d497..1467eb4d1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -31,4 +31,4 @@ write a little note why. - [ ] Verify benchmarks & weights have been updated for any modified runtime logics - [ ] If import a new pallet, choose a proper module index for it, and allow it in `BaseFilter`. Ensure **every** extrinsic works from front-end. If there's corresponding tool, ensure both work for each other. - [ ] If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers. -- [ ] When integrating upstream changes check if you are inheriting runtime storage migrations. If any, perform tests with `try-runtime`. +- [ ] If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with `try-runtime`. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of `#[pallet::storage]` items to check for any.