[1LP][RFR] Update set_conversion_host_api() to use CA certs (#10047)

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

* Update set_conversion_host_api() to use CA certs

Author: nachandr

cfme/fixtures/v2v_fixtures.py

@@ -213,28 +213,37 @@ def vddk_url():
 
 
 def get_conversion_data(appliance, target_provider):
+    # SSL certificate verification is required while configuring conversion hosts only if RHV-M
+    # uses SSL. It's not related to the SSL certificate verification in the provider configuration
+    # and there is no way to link them because they are not used in the same way.
+    tls_ca_certs = None
+
     if target_provider.one_of(RHEVMProvider):
+        engine_key = conf.credentials[target_provider.data["ssh_creds"]]
+        ssh_client = ssh.SSHClient(
+            hostname=target_provider.hostname,
+            username=engine_key.username,
+            password=engine_key.password,
+        )
+
         # Support for UCI hosts for RHV would be added in 5.11.6.
         if appliance.version >= '5.11.6':
+            tls_ca_certs = ssh_client.run_command(
+                "cat /etc/pki/ovirt-engine/apache-ca.pem").output
             resource_type = "ManageIQ::Providers::Redhat::InfraManager::Vm"
             vm_key = conf.credentials[
                 target_provider.data["private-keys"]["engine-rsa"]["credentials"]]
             auth_user = vm_key.username
-            private_key = vm_key.password
+            private_key = ssh_client.run_command(
+                "cat /root/.ssh/id_rsa").output
             try:
                 hosts = target_provider.data["conversion_instances"]
             except KeyError:
                 pytest.skip("No conversion host on provider")
 
         else:
             resource_type = "ManageIQ::Providers::Redhat::InfraManager::Host"
-            engine_key = conf.credentials[target_provider.data["ssh_creds"]]
             auth_user = engine_key.username
-            ssh_client = ssh.SSHClient(
-                hostname=target_provider.hostname,
-                username=engine_key.username,
-                password=engine_key.password,
-            )
             private_key = ssh_client.run_command(
                 "cat /etc/pki/ovirt-engine/keys/engine_id_rsa").output
             try:
@@ -257,7 +266,8 @@ def get_conversion_data(appliance, target_provider):
         "resource_type": resource_type,
         "private_key": private_key,
         "auth_user": auth_user,
-        "hosts": hosts
+        "hosts": hosts,
+        "tls_ca_certs": tls_ca_certs
     }
 
 
@@ -294,13 +304,23 @@ def set_conversion_host_api(
         host_id = (
             getattr(appliance.rest_api.collections, conversion_entity).filter(
                 Q.from_dict({"name": host})).resources[0].id)
-        response = appliance.rest_api.collections.conversion_hosts.action.create(
-            resource_id=host_id,
-            resource_type=conversion_data["resource_type"],
-            vmware_vddk_package_url=vmware_vddk_package_url,
-            vmware_ssh_private_key=vmware_ssh_private_key,
-            conversion_host_ssh_private_key=conversion_data["private_key"],
-            auth_user=conversion_data["auth_user"])[0]
+        if target_provider.one_of(RHEVMProvider) and appliance.version >= '5.11.6':
+            response = appliance.rest_api.collections.conversion_hosts.action.create(
+                resource_id=host_id,
+                resource_type=conversion_data["resource_type"],
+                vmware_vddk_package_url=vmware_vddk_package_url,
+                vmware_ssh_private_key=vmware_ssh_private_key,
+                conversion_host_ssh_private_key=conversion_data["private_key"],
+                tls_ca_certs=conversion_data["tls_ca_certs"],
+                auth_user=conversion_data["auth_user"])[0]
+        else:
+            response = appliance.rest_api.collections.conversion_hosts.action.create(
+                resource_id=host_id,
+                resource_type=conversion_data["resource_type"],
+                vmware_vddk_package_url=vmware_vddk_package_url,
+                vmware_ssh_private_key=vmware_ssh_private_key,
+                conversion_host_ssh_private_key=conversion_data["private_key"],
+                auth_user=conversion_data["auth_user"])[0]
         response.reload()
         wait_for(
             lambda: response.task.state == "Finished",

cfme/infrastructure/virtual_machines.py

@@ -1521,7 +1521,12 @@ def step(self, *args, **kwargs):
         entity_item.click()
 
     def resetter(self, *args, **kwargs):
-        self.view.toolbar.reload.click()
+        # https://bugzilla.redhat.com/show_bug.cgi?id=1821974#c5
+        # History & Refresh buttons have been removed from explorer screens on upstream only.
+        if self.obj.appliance.is_downstream:
+            self.view.toolbar.reload.click()
+        else:
+            pass
 
 
 @navigator.register(InfraTemplate, 'ArchiveDetails')