fix: Allow set externalIPs #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request allows to set externalIPs for external-service
promasu
suggested changes
Oct 19, 2025
Contributor
promasu
left a comment
promasu
left a comment
There was a problem hiding this comment.
Can you please add documentation for the newly added value and run the pre-commit-hook?
DrPsychick
approved these changes
Oct 25, 2025
Collaborator
DrPsychick
left a comment
DrPsychick
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Collaborator
|
@andriishestakov The pipeline also wants a documentation entry in values.yaml, not just the value.
|
promasu
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows to set externalIPs for external-service