Skip to content

feat: icp-logs now store the prior SE(3) PDF#58

Merged
jlblancoc merged 1 commit intodevelopfrom
feat/icp-viewer-show-prior
Apr 28, 2026
Merged

feat: icp-logs now store the prior SE(3) PDF#58
jlblancoc merged 1 commit intodevelopfrom
feat/icp-viewer-show-prior

Conversation

@jlblancoc
Copy link
Copy Markdown
Member

No description provided.

@jlblancoc jlblancoc enabled auto-merge April 28, 2026 15:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@jlblancoc has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 26 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b435f4ff-e157-4a48-b156-c06caea27ad3

📥 Commits

Reviewing files that changed from the base of the PR and between 7b05b31 and fba7893.

📒 Files selected for processing (4)
  • apps/icp-log-viewer/main.cpp
  • mp2p_icp/include/mp2p_icp/LogRecord.h
  • mp2p_icp/src/ICP.cpp
  • mp2p_icp/src/LogRecord.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/icp-viewer-show-prior

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jlblancoc jlblancoc merged commit 5b4bdea into develop Apr 28, 2026
13 checks passed
@jlblancoc jlblancoc deleted the feat/icp-viewer-show-prior branch April 28, 2026 15:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.62%. Comparing base (7b05b31) to head (fba7893).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
mp2p_icp/src/LogRecord.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #58   +/-   ##
========================================
  Coverage    78.62%   78.62%           
========================================
  Files          191      191           
  Lines        10635    10641    +6     
  Branches       985      986    +1     
========================================
+ Hits          8362     8367    +5     
- Misses        2273     2274    +1     
Files with missing lines Coverage Δ
mp2p_icp/include/mp2p_icp/LogRecord.h 100.00% <ø> (ø)
mp2p_icp/src/ICP.cpp 78.41% <100.00%> (+0.06%) ⬆️
mp2p_icp/src/LogRecord.cpp 83.56% <83.33%> (-0.27%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant