mm-viewer: add CLI flags to load overlaid 3D scenes for visualization#28
mm-viewer: add CLI flags to load overlaid 3D scenes for visualization#28
Conversation
📝 WalkthroughWalkthroughThe pull request adds functionality to load and visualize additional 3D scene files within the mm-viewer application. A new CLI option enables specifying extra scene files at startup, which are parsed and displayed as toggleable visualization layers in the GUI. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant CLI as CLI Parser
participant App as Application
participant FileLoader as Scene Loader
participant GUI as GUI Layer
participant Renderer as 3D Renderer
User->>CLI: Execute with --add-3d-scene <scene_path>
CLI->>App: Parse arg_add3dScenes
App->>FileLoader: Load 3D scene file for each path
FileLoader->>FileLoader: Extract viewport objects
FileLoader->>App: Return viewport objects
App->>App: Create ExtraVizLayer structure
App->>App: Store in extraVizLayers collection
App->>GUI: Create per-file visibility checkbox
GUI->>GUI: Register checkbox state listener
User->>GUI: Toggle checkbox for layer visibility
GUI->>App: Trigger visibility change
App->>Renderer: Rebuild 3D view
Renderer->>Renderer: Aggregate glVizObjects from extraVizLayers
Renderer->>User: Display/hide layer in 3D scene
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes The main.cpp changes introduce new data structures, CLI argument handling, and visualization management logic spread across startup, GUI, and rendering flows. The documentation addition is trivial. Overall complexity stems from integrating multiple interacting components rather than dense algorithmic logic. Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0234495 to
95ef8ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #28 +/- ##
========================================
Coverage 66.19% 66.19%
========================================
Files 165 165
Lines 8100 8100
Branches 879 879
========================================
Hits 5362 5362
Misses 2738 2738 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.