Tcp fixes #6
Open
Tcp fixes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable _sckt->timeout is used for the sole purpose of determining whether the sequence number should be incremented, or whether this is a retransmit. However, the updating of this variable didn't really work correctly since nwk_upstream can be called through other means than from nwk_tick (there is for example a "Reschedule 50ms later for eventual further processing") which is where the variable would be updated. The result being that the sequence number would be incorrectly incremented on any retransmit caused by a call to nwk_upstream not coming from nwk_tick. Change this to the more robust approach of setting timeout whenever the sequence number is incremented, and clearing it only when there is new data to transmit. This variable could probably use a new name as well. :-)
If the callback responded to the disconnect event by doing socket_release, then then handshake would never complete. Therefore, hold off on the event until after the handshake has completed.
Author
|
Added two more. The first fixes weeip getting confused about the sequence number when transmitting. The second is just removing of a "TESTE" event generator which made it difficult to properly clean up a socket when it is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed two issues with the TCP handling.
The first is that it got confused about the payload length when there are options in the received TCP packet.
The other is that it kept retransmitting packets even after all data had been acked by the peer, eventually closing down
the socket because the retry count never got reset.