fix: bump major for breaking change#187
Conversation
There was a problem hiding this comment.
Pull request overview
Updates documentation in the TypeScript client SDK to adjust terminology in the AppRenderer component’s docstring.
Changes:
- Tweaks the
AppRendererJSDoc description to refer to an “MCP Apps tool” lifecycle (instead of “MCP-UI tool”).
| * React component that renders an MCP tool's custom UI in a sandboxed iframe. | ||
| * | ||
| * This component manages the complete lifecycle of an MCP-UI tool: | ||
| * This component manages the complete lifecycle of an MCP Apps tool: | ||
| * 1. Creates AppBridge for MCP communication |
There was a problem hiding this comment.
The updated docstring introduces the term "MCP Apps tool", but the surrounding docstring line still says "MCP tool's custom UI". This makes the component description inconsistent/unclear; consider using the same terminology throughout (e.g., "MCP tool (Apps spec)" or similar) so readers understand whether this is specific to the Apps spec or MCP tools generally.
| * React component that renders an MCP tool's custom UI in a sandboxed iframe. | ||
| * | ||
| * This component manages the complete lifecycle of an MCP-UI tool: | ||
| * This component manages the complete lifecycle of an MCP Apps tool: |
There was a problem hiding this comment.
PR title indicates a major-version bump for a breaking change, but this change appears to be documentation-only (a docstring wording tweak). If the intent is actually a breaking change, the version bump/change should be included; otherwise, consider updating the PR title/description to match the actual change to avoid misleading release notes.
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.