Bugfixes - Favorite Foods and math fix for Carb Entry

1. bug-saving as favorite food does not actually save as favorite - Fixed
2. bug-math problem when calculating carbs for a portion using AI - Fixed

Author: taylorpatterson-T1D

Loop/Extensions/UserDefaults+Loop.swift

@@ -123,6 +123,21 @@ extension UserDefaults {
             }
         }
     }
+
+    /// Persist favorite foods with explicit call and lightweight logging.
+    /// Use this after user-initiated changes to avoid race conditions between multiple view models.
+    func writeFavoriteFoods(_ newValue: [StoredFavoriteFood]) {
+        do {
+            let encoder = JSONEncoder()
+            let data = try encoder.encode(newValue)
+            set(data, forKey: Key.favoriteFoods.rawValue)
+            #if DEBUG
+            print("💾 Saved favorite foods count: \(newValue.count)")
+            #endif
+        } catch {
+            assertionFailure("Unable to encode stored favorite foods (explicit write)")
+        }
+    }
 
     var aiProvider: String {
         get {
@@ -340,7 +355,7 @@ MANDATORY REQUIREMENTS:
 
     var textSearchProvider: String {
         get {
-            return string(forKey: Key.textSearchProvider.rawValue) ?? "USDA FoodData Central"
+            return string(forKey: Key.textSearchProvider.rawValue) ?? "OpenFoodFacts (Default)"
         }
         set {
             set(newValue, forKey: Key.textSearchProvider.rawValue)
@@ -349,7 +364,7 @@ MANDATORY REQUIREMENTS:
 
     var barcodeSearchProvider: String {
         get {
-            return string(forKey: Key.barcodeSearchProvider.rawValue) ?? "OpenFoodFacts"
+            return string(forKey: Key.barcodeSearchProvider.rawValue) ?? "OpenFoodFacts (Default)"
         }
         set {
             set(newValue, forKey: Key.barcodeSearchProvider.rawValue)
@@ -358,7 +373,7 @@ MANDATORY REQUIREMENTS:
 
     var aiImageProvider: String {
         get {
-            return string(forKey: Key.aiImageProvider.rawValue) ?? "OpenAI (ChatGPT API)"
+            return string(forKey: Key.aiImageProvider.rawValue) ?? "Google (Gemini API)"
         }
         set {
             set(newValue, forKey: Key.aiImageProvider.rawValue)

Loop/Services/AIFoodAnalysis.swift

@@ -229,8 +229,7 @@ FOR MENU AND RECIPE ITEMS:
 ❌ NEVER multiply nutrition values by assumed restaurant portion sizes
 
 ✅ ALWAYS set image_type to "menu_item" when analyzing menu text
-✅ When analyzing a MENU, ALWAYS set portion_estimate to "CANNOT DETERMINE PORTION - menu text only"
-✅ When analyzing a RECIPE, ALWAYS set portion_estimate to "CANNOT DETERMINE PORTION - recipe text only"
+✅ ALWAYS set portion_estimate to "CANNOT DETERMINE - menu text only"
 ✅ ALWAYS set serving_multiplier to 1.0 for menu items (USDA standard only)
 ✅ ALWAYS set visual_cues to "NONE - menu text analysis only"
 ✅ ALWAYS mark assessment_notes as "ESTIMATE ONLY - Based on USDA standard serving size"
@@ -472,7 +471,7 @@ FOR MENU ITEMS:
   "food_items": [
     {
       "name": "menu item name as written on menu",
-      "portion_estimate": "CANNOT DETERMINE PORTION - menu text only, no actual food visible",
+      "portion_estimate": "CANNOT DETERMINE - menu text only, no actual food visible",
       "usda_serving_size": "standard USDA serving size for this food type (e.g., '3 oz for chicken breast', '1/2 cup for cooked rice')",
       "serving_multiplier": 1.0,
       "preparation_method": "method described on menu (if any)",
@@ -515,7 +514,7 @@ If menu shows "Grilled Chicken Caesar Salad", respond:
   "food_items": [
     {
       "name": "Grilled Chicken Caesar Salad",
-      "portion_estimate": "CANNOT DETERMINE PORTION - menu text only, no actual food visible",
+      "portion_estimate": "CANNOT DETERMINE - menu text only, no actual food visible",
       "usda_serving_size": "3 oz chicken breast + 2 cups mixed greens",
       "serving_multiplier": 1.0,
       "preparation_method": "grilled chicken as described on menu",
@@ -557,7 +556,7 @@ If menu shows "Teriyaki Chicken Bowl with White Rice", respond:
   "food_items": [
     {
       "name": "Teriyaki Chicken with White Rice",
-      "portion_estimate": "CANNOT DETERMINE PORTION - menu text only, no actual food visible",
+      "portion_estimate": "CANNOT DETERMINE - menu text only, no actual food visible",
       "usda_serving_size": "3 oz chicken breast + 1/2 cup cooked white rice",
       "serving_multiplier": 1.0,
       "preparation_method": "teriyaki glazed chicken with steamed white rice as described on menu",
@@ -597,7 +596,7 @@ If menu shows "Quinoa Bowl with Sweet Potato and Black Beans", respond:
   "food_items": [
     {
       "name": "Quinoa Bowl with Sweet Potato and Black Beans",
-      "portion_estimate": "CANNOT DETERMINE PORTION - menu text only, no actual food visible",
+      "portion_estimate": "CANNOT DETERMINE - menu text only, no actual food visible",
       "usda_serving_size": "1/2 cup cooked quinoa + 1/2 cup sweet potato + 1/2 cup black beans",
       "serving_multiplier": 1.0,
       "preparation_method": "cooked quinoa, roasted sweet potato, and seasoned black beans as described on menu",
@@ -676,8 +675,7 @@ FOR MENU AND RECIPE ITEMS:
 ❌ NEVER multiply nutrition values by assumed restaurant portion sizes
 
 ✅ ALWAYS set image_type to "menu_item" when analyzing menu text
-✅ When analyzing a MENU, ALWAYS set portion_estimate to "CANNOT DETERMINE PORTION - menu text only"
-✅ When analyzing a RECIPE, ALWAYS set portion_estimate to "CANNOT DETERMINE PORTION - recipe text only"
+✅ ALWAYS set portion_estimate to "CANNOT DETERMINE - menu text only"
 ✅ ALWAYS set serving_multiplier to 1.0 for menu items (USDA standard only)
 ✅ ALWAYS set visual_cues to "NONE - menu text analysis only"
 ✅ ALWAYS mark assessment_notes as "ESTIMATE ONLY - Based on USDA standard serving size"
@@ -917,7 +915,7 @@ enum SearchProvider: String, CaseIterable {
     case claude = "Anthropic (Claude API)"
     case googleGemini = "Google (Gemini API)"
     case openAI = "OpenAI (ChatGPT API)"
-    case openFoodFacts = "OpenFoodFacts"
+    case openFoodFacts = "OpenFoodFacts (Default)"
     case usdaFoodData = "USDA FoodData Central"
 
 

Loop/View Models/CarbEntryViewModel.swift

@@ -320,6 +320,8 @@ final class CarbEntryViewModel: ObservableObject {
     func onFavoriteFoodSave(_ food: NewFavoriteFood) {
         let newStoredFood = StoredFavoriteFood(name: food.name, carbsQuantity: food.carbsQuantity, foodType: food.foodType, absorptionTime: food.absorptionTime)
         favoriteFoods.append(newStoredFood)
+        // Explicitly persist to avoid race with other view models' sinks
+        UserDefaults.standard.writeFavoriteFoods(favoriteFoods)
         selectedFavoriteFoodIndex = favoriteFoods.count - 1
     }
 
@@ -1787,4 +1789,3 @@ extension CarbEntryViewModel {
         return (totalHours, reasoning)
     }
 }
-

Loop/View Models/FavoriteFoodsViewModel.swift

@@ -40,6 +40,8 @@ final class FavoriteFoodsViewModel: ObservableObject {
             withAnimation {
                 favoriteFoods.append(newStoredFood)
             }
+            // Explicitly persist after add
+            UserDefaults.standard.writeFavoriteFoods(favoriteFoods)
             isAddViewActive = false
         }
         else if var selectedFood, let selectedFooxIndex = favoriteFoods.firstIndex(of: selectedFood) {
@@ -48,6 +50,8 @@ final class FavoriteFoodsViewModel: ObservableObject {
             selectedFood.foodType = newFood.foodType
             selectedFood.absorptionTime = newFood.absorptionTime
             favoriteFoods[selectedFooxIndex] = selectedFood
+            // Explicitly persist after edit
+            UserDefaults.standard.writeFavoriteFoods(favoriteFoods)
             isEditViewActive = false
         }
     }
@@ -59,12 +63,16 @@ final class FavoriteFoodsViewModel: ObservableObject {
         withAnimation {
             _ = favoriteFoods.remove(food)
         }
+        // Explicitly persist after delete
+        UserDefaults.standard.writeFavoriteFoods(favoriteFoods)
     }
 
     func onFoodReorder(from: IndexSet, to: Int) {
         withAnimation {
             favoriteFoods.move(fromOffsets: from, toOffset: to)
         }
+        // Explicitly persist after reorder
+        UserDefaults.standard.writeFavoriteFoods(favoriteFoods)
     }
 
     func addFoodTapped() {