Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 3, 2025

Description

Now that tmp files are retained from homebrew build and test steps, the gcno files should remain intact.

Depends on gcovr/gcovr#1047

TODO:

  • coverage on Ubuntu runners (required same version of gcov and gcc)
  • coverage on macOS runners

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented May 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.23%. Comparing base (8372c37) to head (0dd02ce).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
+ Coverage   11.98%   13.23%   +1.24%     
==========================================
  Files          87       91       +4     
  Lines       17572    17682     +110     
  Branches     8076     8129      +53     
==========================================
+ Hits         2106     2340     +234     
+ Misses      14569    14345     -224     
- Partials      897      997     +100     
Flag Coverage Δ
Homebrew-ubuntu-latest 13.66% <ø> (?)
Linux-AppImage 11.49% <ø> (ø)
Windows-AMD64 13.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 29 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 11 times, most recently from 09350b4 to bccfda2 Compare May 4, 2025 15:23
@codecov
Copy link

codecov bot commented May 4, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 13 times, most recently from 52eb7ae to 6cf5e8a Compare May 8, 2025 01:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2025

@LizardByte-bot
Copy link
Member

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 10 times, most recently from ac5a86a to c88af19 Compare September 2, 2025 13:09
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Sep 2, 2025
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 9 times, most recently from ab5edc0 to 3f3e2da Compare September 7, 2025 01:05
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch from 3f3e2da to 0dd02ce Compare October 6, 2025 22:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4 New issues
4 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants