Merge branch 'release'

Author: live-github-bot[bot]

.eslintrc.js

@@ -0,0 +1,31 @@
+module.exports = {
+  root: true,
+  env: {
+    node: true,
+  },
+  parser: "@typescript-eslint/parser",
+  plugins: ["@typescript-eslint", "prettier", "json"],
+  extends: [
+    "eslint:recommended",
+    "plugin:prettier/recommended",
+    "plugin:json/recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+  ],
+  rules: {
+    "prettier/prettier": "error",
+    "no-inner-declarations": "off",
+    // Enables no-unused-vars only from TypeScript
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        argsIgnorePattern: "^_",
+        destructuredArrayIgnorePattern: "^_",
+        vars: "all",
+        args: "after-used",
+        ignoreRestSiblings: true,
+      },
+    ],
+  },
+};

.github/workflows/build-desktop-external.yml

@@ -12,6 +12,11 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
+      draft:
+        description: true if the PR is in draft
+        required: false
+        default: "false"
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341

.github/workflows/build-desktop.yml

@@ -18,6 +18,11 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
+      draft:
+        description: true if the PR is in draft
+        required: false
+        default: "false"
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341

.github/workflows/build-mobile-external.yml

@@ -12,6 +12,7 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341
@@ -28,7 +29,7 @@ jobs:
       - uses: LedgerHQ/ledger-live/tools/actions/composites/checkout-merge@develop
         with:
           ref: ${{ github.ref_name }}
-          base_ref: ${{ inputs.base_ref }}
+          base: ${{ inputs.base_ref }}
       - name: set git user
         run: |
           git config user.email "105061298+live-github-bot[bot]@users.noreply.github.com"
@@ -97,7 +98,7 @@ jobs:
       - uses: LedgerHQ/ledger-live/tools/actions/composites/checkout-merge@develop
         with:
           ref: ${{ github.ref_name }}
-          base_ref: ${{ inputs.base_ref }}
+          base: ${{ inputs.base_ref }}
       - name: set git user
         run: |
           git config user.email "105061298+live-github-bot[bot]@users.noreply.github.com"

.github/workflows/build-mobile.yml

@@ -18,6 +18,7 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341

.github/workflows/test-desktop-external.yml

@@ -12,6 +12,11 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
+      draft:
+        description: true if the PR is in draft
+        required: false
+        default: "false"
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341
@@ -82,7 +87,12 @@ jobs:
           install_playwright: true
       - name: Run playwright tests [Linux => xvfb-run]
         id: tests
-        run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright
+        run: |
+          if [[ "${{ inputs.draft }}" == true ]]; then
+            xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright
+          else
+            xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright
+          fi
       - name: upload diffs to imgur
         if: always() && !cancelled()
         uses: ./tools/actions/upload-images
@@ -140,7 +150,12 @@ jobs:
           install_playwright: true
       - name: Run playwright tests
         id: tests
-        run: pnpm desktop test:playwright
+        run: |
+          if [[ "${{ inputs.draft }}" == true ]]; then
+            pnpm desktop test:playwright
+          else
+            pnpm desktop test:playwright
+          fi
       - name: upload diffs to imgur
         if: always() && !cancelled()
         uses: ./tools/actions/upload-images
@@ -198,7 +213,13 @@ jobs:
           upgrade_npm: true
       - name: Run playwright tests
         id: tests
-        run: pnpm desktop test:playwright
+        run: |
+          if [[ "${{ inputs.draft }}" == true ]]; then
+            pnpm desktop test:playwright
+          else
+            pnpm desktop test:playwright
+          fi
+        shell: bash
       - name: upload diffs to imgur
         if: always() && !cancelled()
         uses: ./tools/actions/upload-images

.github/workflows/test-desktop.yml

@@ -18,6 +18,11 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
+      draft:
+        description: true if the PR is in draft
+        required: false
+        default: "false"
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341
@@ -109,7 +114,13 @@ jobs:
           upgrade_npm: true
       - name: Run playwright tests
         id: tests
-        run: pnpm desktop test:playwright
+        run: |
+          if [[ "${{ inputs.draft }}" == true ]]; then
+            pnpm desktop test:playwright
+          else
+            pnpm desktop test:playwright
+          fi
+        shell: bash
       - name: upload diffs to imgur
         if: always() && !cancelled()
         uses: ./tools/actions/upload-images
@@ -174,7 +185,12 @@ jobs:
           install_playwright: true
       - name: Run playwright tests [Linux => xvfb-run]
         id: tests
-        run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright
+        run: |
+          if [[ "${{ inputs.draft }}" == true ]]; then
+            xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright
+          else
+            xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright
+          fi
       - name: upload diffs to imgur
         if: always() && !cancelled()
         uses: ./tools/actions/upload-images
@@ -239,7 +255,12 @@ jobs:
           pnpm_dest: ${{ runner.temp }}/setup-pnpm
       - name: Run playwright tests
         id: tests
-        run: pnpm desktop test:playwright
+        run: |
+          if [[ "${{ inputs.draft }}" == true ]]; then
+            pnpm desktop test:playwright
+          else
+            pnpm desktop test:playwright
+          fi
       - name: upload diffs to imgur
         if: always() && !cancelled()
         uses: ./tools/actions/upload-images

.github/workflows/test-mobile-e2e.yml

@@ -18,6 +18,7 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
 
 # Uncomment to have log-level: trace on detox run and build
 # (cf: apps/ledger-live-mobile/detox.config.js)

.github/workflows/test-mobile.yml

@@ -18,6 +18,7 @@ on:
         required: true
       base_ref:
         description: The base branch to merge the head into when checking out the code
+        required: false
 
 concurrency:
   # See: https://github.com/orgs/community/discussions/35341
@@ -52,8 +53,7 @@ jobs:
       - name: Run linter
         run: |
           pnpm lint --filter="live-mobile" --api="http://127.0.0.1:${{ steps.turborepo-cache-server.outputs.port }}" --token="yolo" --team="foo" -- --format="json" -o="lint.json"
-          cd apps/ledger-live-mobile
-          node -p "require('./node_modules/eslint/lib/cli-engine/formatters/stylish.js')(require('./lint.json'))"
+          node -p "require('./node_modules/eslint/lib/cli-engine/formatters/stylish.js')(require('./apps/ledger-live-mobile/lint.json'))"
       - name: check for dead code
         run: cd apps/ledger-live-mobile && npx unimported
         shell: bash

.github/workflows/test.yml

@@ -49,6 +49,27 @@ jobs:
           echo "diff=$diff" >> $GITHUB_OUTPUT
           exit $diff
 
+
+  test-common-tools:
+    name: "Test common-tools"
+    env:
+      NODE_OPTIONS: "--max-old-space-size=7168"
+      FORCE_COLOR: 3
+    outputs:
+      fail: ${{ steps.diff.outputs.diff }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: LedgerHQ/ledger-live/tools/actions/composites/checkout-merge@develop
+        with:
+          ref: ${{ github.event_name == 'workflow_dispatch' && github.ref_name || github.sha }}
+          base: ${{ inputs.since_branch }}
+      - name: Setup the toolchain
+        uses: ./tools/actions/composites/setup-toolchain
+      - name: Install dependencies
+        run: pnpm i -F "live-common-tools..." -F "ledger-live"
+      - name: build common-tools
+        run: pnpm turbo run build --filter="live-common-tools"
+
   test-cli:
     name: "Test CLI"
     env:
@@ -154,7 +175,7 @@ jobs:
           path: ${{ github.workspace }}/summary-${{ matrix.os }}.txt
 
   report:
-    needs: [test-cli, test-docs, test-libraries]
+    needs: [test-cli, test-docs, test-libraries, test-common-tools]
     if: always() && !cancelled() && github.event_name == 'workflow_dispatch'
     runs-on: ubuntu-latest
     steps: