-
Notifications
You must be signed in to change notification settings - Fork 40
Laghos spack-v.1 and umpire changes #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheibelp
previously approved these changes
Sep 25, 2025
pearce8
approved these changes
Oct 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1087 +/- ##
===========================================
+ Coverage 65.20% 65.33% +0.12%
===========================================
Files 44 44
Lines 3245 3245
Branches 257 257
===========================================
+ Hits 2116 2120 +4
+ Misses 1122 1118 -4
Partials 7 7 🚀 New features to boost your workflow:
|
pearce8
requested changes
Oct 30, 2025
Collaborator
pearce8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfhaque the laghos runs seem to be failing on all systems.
pearce8
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following changes:
repo/benchmark_name/package.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.