Skip to content

Conversation

@rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Sep 25, 2025

Description

This PR makes the following changes:

  1. Adds support for building mesh in laghos instead of using a prebuilt mesh file
  2. Adds supports for building GPU aware MPI in laghos, mfem and hypre, when applicable
  3. Adds support for umpire pools in laghos - PR by Tom shared device umpire pool CEED/Laghos#198
  4. switches to the upstreamed caliper package.py
  5. syncs with the upstreamed mfem package.py with additional changes for caliper support
  6. Builds and runs on dane, matrix and tuolumne
  7. The caliperized branch of Laghos must be merged [with the main branch https://github.com/wdhawkins/Laghos.git (caliper branch)](Basic Caliper support CEED/Laghos#196)
  8. The Laghos PR (Add options to generate mesh from command line CEED/Laghos#197) must be merged
  9. The git URL in laghos package.py must be changed to the main Laghos repo at https://github.com/CEED/Laghos.git
  10. If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.

scheibelp
scheibelp previously approved these changes Sep 25, 2025
@scheibelp scheibelp added this pull request to the merge queue Sep 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 26, 2025
@github-actions github-actions bot added the experiment New or modified experiment label Oct 3, 2025
@rfhaque rfhaque changed the title Use upstreamed caliper and mfem spack packages Laghos spack-v.1 and umpire changees Oct 3, 2025
@rfhaque rfhaque changed the title Laghos spack-v.1 and umpire changees Laghos spack-v.1 and umpire changes Oct 3, 2025
@pearce8 pearce8 mentioned this pull request Oct 10, 2025
20 tasks
@rfhaque rfhaque added the ready for review Ready for review label Oct 26, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.33%. Comparing base (b1c2293) to head (36301bb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1087      +/-   ##
===========================================
+ Coverage    65.20%   65.33%   +0.12%     
===========================================
  Files           44       44              
  Lines         3245     3245              
  Branches       257      257              
===========================================
+ Hits          2116     2120       +4     
+ Misses        1122     1118       -4     
  Partials         7        7              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque the laghos runs seem to be failing on all systems.

@pearce8 pearce8 added changes requested Changes requested and removed ready for review Ready for review labels Oct 30, 2025
@pearce8 pearce8 merged commit 7401db3 into develop Oct 31, 2025
61 of 66 checks passed
@pearce8 pearce8 deleted the laghos_remhos_spackv1 branch October 31, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application changes requested Changes requested experiment New or modified experiment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants