Skip to content

Memory arena for launch #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Memory arena for launch #1817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b12358
memory arena for launch
artv3 Apr 14, 2025
5bfd2c8
Update include/RAJA/pattern/launch/launch_core.hpp
artv3 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions include/RAJA/pattern/launch/launch_core.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,11 @@ class LaunchContext
// Bump style allocator used to
// get memory from the pool
size_t shared_mem_offset;

void* shared_mem_ptr;

size_t mem_arena_offset;
void* mem_arena_ptr;

#if defined(RAJA_ENABLE_SYCL)
mutable ::sycl::nd_item<3>* itm;
#endif
Expand All @@ -208,6 +210,26 @@ class LaunchContext
return static_cast<T*>(mem_ptr);
}

template<typename T>
RAJA_HOST_DEVICE createMemoryArena(T *ptr, size_t bytes)
{
void * mem_arena_ptr = static_cast<char*>(&ptr[0]);
}

// TODO handle alignment
template<typename T>
RAJA_HOST_DEVICE T* getArenaMemory(size_t bytes)
Copy link

@YohannDudouit YohannDudouit Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think bytes reflects well how this is used, it seems to be a number of values, not a number of bytes.

{

// Calculate offset in bytes with a char pointer
void* mem_ptr = static_cast<char*>(mem_arena_ptr) + mem_arena_offset;

arena_mem_offset += bytes * sizeof(T);

// convert to desired type
return static_cast<T*>(mem_ptr);
}

/*
//Odd dependecy with atomics is breaking CI builds
template<typename T, size_t DIM, typename IDX_T=RAJA::Index_type, ptrdiff_t
Expand All @@ -222,12 +244,21 @@ class LaunchContext
}
*/

RAJA_HOST_DEVICE void releaseSharedMemory()
//default is to release all
RAJA_HOST_DEVICE void releaseSharedMemory(size_t offset=-1)
{
// On the cpu/gpu we want to restart the count
shared_mem_offset = 0;
shared_mem_offset = offset < 0 ? 0 : shared_mem_offset - offset;
}

//default is to release all
RAJA_HOST_DEVICE void releaseArenaMemory(size_t offset=-1)
{
// On the cpu/gpu we want to restart the count
arena_mem_offset = offset < 0 ? 0 : arena_mem_offset - offset;
}


RAJA_HOST_DEVICE
void teamSync()
{
Expand Down
Loading