fix: await identity collection to prevent null telemetry fields#85
Merged
fix: await identity collection to prevent null telemetry fields#85
Conversation
The identity collection (gitEmail, gitRemoteUrl, hostname) was fire-and-forget, causing a race condition where short-running commands would emit telemetry before the identity cache populated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 0.20.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectUserIdentity()in cli.ts instead of fire-and-forgetgitEmail,gitRemoteUrl, andhostnamewere null on telemetry events because the identity cache hadn't populated before commands completedAlso deployed (separate from this PR)
Impact
All telemetry events will now include identity fields when available. Combined with the worker fix, all 15 previously-null enrichment fields will now be stored.
🤖 Generated with Claude Code