Fix INS-2242, add afterPack workaround for electron-builder (#5627)

Author: filfreire

packages/insomnia/electron-builder.config.js

@@ -26,6 +26,7 @@ const config = {
   ],
   publish: null,
   afterSign: './scripts/afterSignHook.js',
+  afterPack: './scripts/afterPack.js',
   extraResources: [
     {
       from: './bin',
@@ -43,6 +44,8 @@ const config = {
   },
   fileAssociations: [],
   mac: {
+    // disabling notarize on electron-builder, we use afterSignHook.js
+    notarize: false,
     hardenedRuntime: true,
     category: 'public.app-category.developer-tools',
     entitlements: './build/static/entitlements.mac.inherit.plist',

packages/insomnia/scripts/afterPack.js

@@ -0,0 +1,28 @@
+/* Remove these hacks when this bug is fixed
+ * https://github.com/electron-userland/electron-builder/issues/7317
+ * Adapted from https://github.com/electron-userland/electron-builder/issues/7317#issuecomment-1351168459
+ */
+
+exports.default = async function patchSign(context) {
+  if (context.electronPlatformName !== 'darwin') {
+    return;
+  }
+  const asoSave = context.packager.adjustSignOptions;
+  if (asoSave.patched) {
+    return;
+  }
+  console.log('[afterpack] Applying adjustSignOptions hack, see electron-userland/electron-builder#7317');
+  context.packager.adjustSignOptions = async function(signOptions, masOptions) {
+    await asoSave.call(this, signOptions, masOptions);
+    if (typeof signOptions.identity === 'object' && signOptions.identity.name) {
+      console.warn('[afterpack] Applying signOptions hack for signing identity.');
+      signOptions.identity = signOptions.identity.name;
+    }
+    if (signOptions['identity-validation'] !== undefined) {
+      console.warn('[afterpack] Applying identity validation hack.');
+      signOptions.identityValidation = signOptions['identity-validation'];
+      delete signOptions['identity-validation'];
+    }
+  };
+  context.packager.adjustSignOptions.patched = true;
+};