fix: deCONZ: enable APS ACKs per request if the first request fails #1590
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firing all unicast requests with APS ACKs doesn't scale well. This PR makes a balance to send a failed requests again when the first one yields a APS confirm error. This only raises the chance the request goes through within the timeout. Later on more logic needs to be added to enable APS ACKs for more requests while not clocking the queue with it. E.g if the queue is almost empty it's safe to use APS ACKs for N requests.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firing all unicast requests with APS ACKs doesn't scale well. This PR makes a balance to send a failed requests again when the first one yields a APS confirm error.
This only raises the chance the request goes through within the timeout. Later on more logic needs to be added to enable APS ACKs for more requests while not clocking the queue with it. E.g if the queue is almost empty it's safe to use APS ACKs for N requests.