fix: implement attr/param meta checking

Author: Nerivec

src/controller/helpers/zclFrameConverter.ts

@@ -26,7 +26,16 @@ function attributeKeyValue<Cl extends number | string, Custom extends TCustomClu
 
     // TODO: remove this type once Zcl.Frame is typed
     for (const item of frame.payload as TFoundation["report" | "write" | "readRsp"]) {
-        payload[cluster.getAttribute(item.attrId)?.name ?? item.attrId] = item.attrData;
+        const attribute = cluster.getAttribute(item.attrId);
+
+        if (attribute) {
+            // XXX: refs that are "after this item" won't be populated (pre-loop?)
+            const attrData = Zcl.Utils.processAttributePostRead(attribute, item.attrData, payload);
+
+            payload[attribute.name] = attrData;
+        } else {
+            payload[item.attrId] = item.attrData;
+        }
     }
 
     return payload as ClusterOrRawWriteAttributes<Cl, Custom>;
@@ -38,7 +47,9 @@ function attributeList(frame: Zcl.Frame, deviceManufacturerID: number | undefine
 
     // TODO: remove this type once Zcl.Frame is typed
     for (const item of frame.payload as TFoundation["read"]) {
-        payload.push(cluster.getAttribute(item.attrId)?.name ?? item.attrId);
+        const attribute = cluster.getAttribute(item.attrId);
+
+        payload.push(attribute?.name ?? item.attrId);
     }
 
     return payload;

src/controller/model/endpoint.ts

@@ -393,6 +393,8 @@ export class Endpoint extends ZigbeeEntity {
         const cluster = this.getCluster(clusterKey, undefined, options?.manufacturerCode);
         const payload: TFoundation["report"] = [];
 
+        // TODO: handle `attr.reportRequired !== true`
+
         for (const nameOrID in attributes) {
             const attribute = cluster.getAttribute(nameOrID);
 
@@ -429,7 +431,11 @@ export class Endpoint extends ZigbeeEntity {
             const attribute = cluster.getAttribute(nameOrID);
 
             if (attribute) {
-                payload.push({attrId: attribute.ID, attrData: attributes[nameOrID], dataType: attribute.type});
+                // TODO: refs are not processed (pre-loop?)
+                // TODO: handle `attr.writeOptional !== true`
+                const attrData = Zcl.Utils.processAttributeWrite(attribute, attributes[nameOrID], attributes);
+
+                payload.push({attrId: attribute.ID, attrData, dataType: attribute.type});
             } else if (!Number.isNaN(Number(nameOrID))) {
                 const value = attributes[nameOrID];
 
@@ -498,13 +504,17 @@ export class Endpoint extends ZigbeeEntity {
         );
         const payload: TFoundation["read"] = [];
 
+        // TODO: handle `attr.required !== true` => should not throw
+
         for (const attribute of attributes) {
             if (typeof attribute === "number") {
                 payload.push({attrId: attribute});
             } else {
                 const attr = cluster.getAttribute(attribute);
 
                 if (attr) {
+                    // TODO: force to also read *Ref if attribute has any and not already present in array for PostRead refs?
+                    Zcl.Utils.processAttributePreRead(attr);
                     payload.push({attrId: attr.ID});
                 } else {
                     logger.warning(`Ignoring unknown attribute ${attribute} in cluster ${cluster.name}`, NS);

src/controller/model/group.ts

@@ -271,7 +271,10 @@ export class Group extends ZigbeeEntity {
             const attribute = cluster.getAttribute(nameOrID);
 
             if (attribute) {
-                payload.push({attrId: attribute.ID, attrData: attributes[nameOrID], dataType: attribute.type});
+                // TODO: refs are not processed (pre-loop?)
+                const attrData = Zcl.Utils.processAttributeWrite(attribute, attributes[nameOrID], attributes);
+
+                payload.push({attrId: attribute.ID, attrData, dataType: attribute.type});
             } else if (!Number.isNaN(Number(nameOrID))) {
                 const value = attributes[nameOrID];
 
@@ -320,13 +323,16 @@ export class Group extends ZigbeeEntity {
         const optionsWithDefaults = this.getOptionsWithDefaults(options, Zcl.Direction.CLIENT_TO_SERVER, cluster.manufacturerCode);
         const payload: TFoundation["read"] = [];
 
+        // TODO: handle `attr.required !== true` => should not throw
+
         for (const attribute of attributes) {
             if (typeof attribute === "number") {
                 payload.push({attrId: attribute});
             } else {
                 const attr = cluster.getAttribute(attribute);
 
                 if (attr) {
+                    Zcl.Utils.processAttributePreRead(attr);
                     payload.push({attrId: attr.ID});
                 } else {
                     logger.warning(`Ignoring unknown attribute ${attribute} in cluster ${cluster.name}`, NS);