Skip to content

LiXee ZLinky: fix polling interval + improve option descriptions #10485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koenkk merged 3 commits into from
Oct 25, 2025
Merged

LiXee ZLinky: fix polling interval + improve option descriptions #10485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0157d92
fix: LiXee ZLinky: make polling interval configurable again
sbraz Oct 23, 2025
5680284
fix: LiXee ZLinky: describe actual default polling interval
sbraz Oct 23, 2025
b8895da
fix: LiXee ZLinky: improve description of measurement_poll_chunk
sbraz Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/devices/lixee.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,8 @@ export const definitions: DefinitionWithExtend[] = [
.numeric("measurement_poll_chunk", ea.SET)
.withValueMin(1)
.withDescription(
"During the poll, request multiple exposes to the Zlinky at once for reducing Zigbee network overload. Too much request at once could exceed device limit. Requires Z2M restart. Default: 4",
"Number of attributes requested from the ZLinky in each poll to reduce Zigbee network load. " +
"Requesting too many at once may exceed the device's limit and cause read errors. Requires Z2M restart. Default: 4.",
),
e
.text("tic_command_whitelist", ea.SET)
Expand Down Expand Up @@ -1894,9 +1895,15 @@ export const definitions: DefinitionWithExtend[] = [
ota: {manufacturerName: "LiXee"}, // TODO: not sure if it's set properly in device
extend: [
m.poll({
key: "interval",
key: "measurement",
Copy link
Owner

@Koenkk Koenkk Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay as is

Copy link
Contributor Author

@sbraz sbraz Oct 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koenkk but it doesn't work as-is, the option is called measurement_poll_interval and the poll function checks ${args.key}_poll_interval, so the key must match the option name.

zigbee-herdsman-converters/src/lib/modernExtend.ts

Line 663 in f7323eb

const optionKey = args.optionKey ?? `${args.key}_poll_interval`;

Am I missing something? Before my fix commit, the poll interval was always 600 seconds, no matter the value of measurement_poll_interval.

defaultIntervalSeconds: 600,
option: exposes.options.measurement_poll_interval(),
option: exposes.options
.measurement_poll_interval()
Copy link
Contributor Author

@sbraz sbraz Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use e.numeric("measurement_poll_interval", instead? I wasn't sure.

Copy link
Owner

@Koenkk Koenkk Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

.withDescription(
"Some attributes do not support reporting and are polled instead. " +
"The default poll interval for these is 600 seconds. Set to -1 to disable polling. " +
"Polled attributes are those marked as read-only at https://github.com/fairecasoimeme/Zlinky_TIC/",
),
poll: async (device, options) => {
const endpoint = device.getEndpoint(1);
const measurement_poll_chunk = options?.measurement_poll_chunk ? options.measurement_poll_chunk : 4;
Expand Down