Added: covers mode (SBDV-00199), diagnostics (SBDV-00196,00199,00202) #9958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Sep 8, 2025
Koenkk
reviewed
Sep 8, 2025
src/devices/sber.ts
Outdated
| return false; | ||
| } | ||
| function setMetaOption(device: Zh.Device, key: string, enabled: boolean) { | ||
| if (device != null && key != null) { |
Contributor
Author
There was a problem hiding this comment.
I think you are right, this additional check was an artefact from times when dummyDevice was not implemented yet
Koenkk
reviewed
Sep 8, 2025
src/devices/sber.ts
Outdated
| } | ||
| function setMetaOption(device: Zh.Device, key: string, enabled: boolean) { | ||
| if (device != null && key != null) { | ||
| device.meta[key] = enabled; |
Owner
There was a problem hiding this comment.
Suggested change
| device.meta[key] = enabled; | |
| device.meta[key] = enabled; | |
| device.save(); |
Contributor
Author
There was a problem hiding this comment.
done. Also got rid of extra functions
Koenkk
reviewed
Sep 8, 2025
src/devices/sber.ts
Outdated
| const defaultResponseOptions = {disableDefaultResponse: false}; | ||
|
|
||
| function checkMetaOption(device: Zh.Device, key: string) { | ||
| if (device != null) { |
Owner
There was a problem hiding this comment.
This check should not be needed? I think this function can be simplified to just return !!(device.meta[key] ?? false)
Owner
|
Thanks! |
avzasorin-sd
added a commit
to avzasorin-sd/zigbee-herdsman-converters
that referenced
this pull request
Sep 11, 2025
…agnostics (Koenkk#9958) Co-authored-by: Koen Kanters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new features for devices from SDevices:
PR with additional information about switching SBDV-00199 into covers mode: Koenkk/zigbee2mqtt.io#4126