fix: minor code cleanup #9645
Merged
fix: minor code cleanup #9645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR performs minor code cleanup in the utils.ts file by improving code consistency and removing linter suppressions. The changes focus on consolidating conditional logic and standardizing parameter handling patterns.
- Refactored conditional checks to use early returns for better readability
- Removed parameter reassignment by using inline ternary expressions
- Updated biome-ignore comments to be more descriptive
src/lib/utils.ts
Outdated
| // biome-ignore lint/suspicious/noExplicitAny: ignored using `--suppress` | ||
| // biome-ignore lint/suspicious/noExplicitAny: generic object | ||
| export function isObject(value: unknown): value is {[s: string]: any} { | ||
| return typeof value === "object" && !Array.isArray(value); |
There was a problem hiding this comment.
The isObject function doesn't check for null values, which means null will return true since typeof null === "object". This is inconsistent with the assertObject function which explicitly excludes null. Add && value !== null to maintain consistency.
Suggested change
| return typeof value === "object" && !Array.isArray(value); | |
| return typeof value === "object" && value !== null && !Array.isArray(value); |
Owner
|
Thanks! |
SimplaHome
pushed a commit
to SimplaHome/zigbee-herdsman-converters
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.