-
Notifications
You must be signed in to change notification settings - Fork 4k
Update ubisys.ts for H1 voltage exposure #9628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i did enhance converter for the "h1 TRV" to include the reported voltage. the converter works locally, i hope my changes wont break other stuff. Regards to anyone involved
corrected ubisysvoltage constant
correct ubisysvoltage
revamped h1 code
Whats the issue with |
since I got rid of the constant, the converter now works fine according to the GitHub checks (locally for a few days I have no issues using it as well) |
cleanup and use e.battery_voltage()
|
cleaned up my commit, i hope its good now! |
|
Thanks! |
|
I don't think this will be enough as voltage is not configure to be reported. The device only self sends this once on pairing so the value is probably very out of date unless the value is manual ready as the fz.battery does read it. Edit: A proper change would probably be:
Edit2: easy change, and I was working on a different PR so quickly made one. |
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
i did enhance converter for the "h1 TRV" to include the reported voltage.
Regards to anyone involved