Skip to content

Conversation

@senna1992
Copy link
Contributor

@senna1992 senna1992 commented Jul 16, 2025

i did enhance converter for the "h1 TRV" to include the reported voltage.

Regards to anyone involved

senna1992 and others added 12 commits July 16, 2025 16:44
i did enhance converter for the "h1 TRV" to include the reported voltage. 

the converter works locally, i hope my changes wont break other stuff. 

Regards to anyone involved
corrected ubisysvoltage constant
correct ubisysvoltage
revamped h1 code
@Koenkk
Copy link
Owner

Koenkk commented Jul 17, 2025

the converter works locally, but i cant fix the const "ubisysvoltage" code.

Whats the issue with ubisysvoltage?

@senna1992
Copy link
Contributor Author

senna1992 commented Jul 19, 2025

the converter works locally, but i cant fix the const "ubisysvoltage" code.

Whats the issue with ubisysvoltage?

since I got rid of the constant, the converter now works fine according to the GitHub checks (locally for a few days I have no issues using it as well)

@senna1992
Copy link
Contributor Author

cleaned up my commit, i hope its good now!

@Koenkk Koenkk merged commit dc4de70 into Koenkk:master Jul 20, 2025
3 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jul 20, 2025

Thanks!

@sjorge
Copy link
Contributor

sjorge commented Jul 22, 2025

I don't think this will be enough as voltage is not configure to be reported. The device only self sends this once on pairing so the value is probably very out of date unless the value is manual ready as the fz.battery does read it.

Edit: A proper change would probably be:

  • drop e.battery_voltage(), e.battery().withAccess(ea.STATE_GET), from exposes
  • drop await reporting.batteryPercentageRemaining(endpoint, {min: constants.repInterval.HOUR, max: 43200, change: 1}); from configure
  • add battery modern extend, but being carful to use batteryPercentageRemaining for battery value as that one is pretty accurate, the voltage based mapping is not.

Edit2: easy change, and I was working on a different PR so quickly made one.

SimplaHome pushed a commit to SimplaHome/zigbee-herdsman-converters that referenced this pull request Aug 15, 2025
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants