fix: correctly test 'exposes' values #11423
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For devices with more than one endpoint 'exposes' values can have endpoints attached, but they were not correctly tested, skipping the endpoint part.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For devices with more than one endpoint
'exposes' values can have endpoints attached,
but they were not correctly tested, skipping the endpoint part.
P.S: would be nice for generated definitions to write tests for endpoint ID > 1. As in this case it will test if endpoint name are correctly applied while generating definition, and for first endpoint values should still be correct either way.
Related to #11422 (merging one will require updating another before merge)