add new features to Heiman HS1SA-E#11239
Merged
Koenkk merged 49 commits intoKoenkk:masterfrom Jan 12, 2026
Merged
Conversation
Koenkk
reviewed
Jan 8, 2026
| 0: "muted", // bit0 | ||
| 1: "alarm muted", // bit1 | ||
| 2: "fault muted", // bit2 | ||
| 3: "low battery muted", // bit3 |
Owner
There was a problem hiding this comment.
Please keep _ instead of , also above in faultStateBitMap
Contributor
Author
There was a problem hiding this comment.
Hi @Koenkk ， Thanks for point out, but interestingly, when I put underline there, the entities are exposed with _ to HA, too, that looked like alarm_muted instead of alarm mute, which looks weird. is there any ways to correct it?
Owner
There was a problem hiding this comment.
Yes that's expected (and how it's done for all devices)
Contributor
Author
There was a problem hiding this comment.
Yes that's expected (and how it's done for all devices)
thanks, fixed, but still wonder why.
Owner
|
thanks |
Koenkk
added a commit
that referenced
this pull request
Feb 3, 2026
Co-authored-by: Koen Kanters <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Leo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Z2M team,
I am adding new features to Heiman HS1SA-E, could you please have an review on it. thanks.