fix(develco): add SIRZB-111 to warning info reverse list#10994
Merged
Koenkk merged 1 commit intoKoenkk:masterfrom Dec 10, 2025
Merged
fix(develco): add SIRZB-111 to warning info reverse list#10994Koenkk merged 1 commit intoKoenkk:masterfrom
Koenkk merged 1 commit intoKoenkk:masterfrom
Conversation
Owner
|
Thanks! |
|
Thanks for your work and the fix. I appreciate that. |
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add SIRZB-111 to the list of devices that require reversed warning info bits in the
warning_simpletoZigbee converter.Why
The SIRZB-111 requires the same bit order as SIRZB-110 for the
startwarninginfoparameter. Without this fix, the alarm OFF command sendsstartwarninginfo: 192instead of0, which fails to stop the siren.Testing
Tested on a frient SIRZB-111 siren:
{"alarm": "OFF"}sentstartwarninginfo: 192→ siren did NOT stop{"alarm": "OFF"}sendsstartwarninginfo: 0→ siren stops correctlyRelated Issues
Fixes Koenkk/zigbee2mqtt#28847