Update ikea.ts #10324
Merged
Update ikea.ts #10324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add raw data decoding for older firmware build (20230406). Note the battery info is not available with this converter for build 20230406
Update ikea.ts
Fixed ikeaParasollRawConverter
Koenkk
reviewed
Oct 14, 2025
src/devices/ikea.ts
Outdated
| convert: (model, msg, publish, options, meta) => { | ||
| const data = msg.data; // e.g., [21,104,17,62,240,110,111,116,105,102,121,0,0,0] | ||
| const contactState = data[data.length - 1]; // last number | ||
| return {contact: contactState ? false : true}; |
Owner
There was a problem hiding this comment.
Suggested change
| return {contact: contactState ? false : true}; | |
| return {contact: contactState === 0 ? false : true}; |
This is more clear, can you check if this works?
Koenkk
reviewed
Oct 14, 2025
Add comments for ikeaParasollRawConverter Change contact detection for clarity
Contributor
Author
|
Changes were made based on the feedback |
Koenkk
force-pushed
the
master
branch
10 times, most recently
from
bf7848c to
da8e480
Compare
Owner
|
Thanks! |
jacky202509
pushed a commit
to jacky202509/zigbee-herdsman-converters
that referenced
this pull request
Nov 13, 2025
…230406 (Koenkk#10324) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add raw data decoding for older firmware build (20230406).
Note the battery info is not available with this converter for build 20230406
Link to picture pull request: TODO