Test failurures caused by DeprecationWarning with websockets 15.0.1 and Python 3.11.14

[apteryks]

Hi,

Attempting to build 0.38 with GNU Guix and the following dependencies:

[email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected]

I get test failures like this:

=================================== FAILURES ===================================
__________________ test_missing_handshake[wsproto-httptools] ___________________
[gw7] linux -- Python 3.11.14 /gnu/store/76vhpdf5vc4rvr1rbcd0p0ycj0npjypb-python-wrapper-3.11.14/bin/python

ws_protocol_cls = <class 'uvicorn.protocols.websockets.wsproto_impl.WSProtocol'>
http_protocol_cls = <class 'uvicorn.protocols.http.httptools_impl.HttpToolsProtocol'>
unused_tcp_port = 48715

    async def test_missing_handshake(ws_protocol_cls: WSProtocol, http_protocol_cls: HTTPProtocol, unused_tcp_port: int):
        async def app(scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable):
            pass
    
        async def connect(url: str):
            await websockets.client.connect(url)
    
        config = Config(app=app, ws=ws_protocol_cls, http=http_protocol_cls, lifespan="off", port=unused_tcp_port)
        async with run_server(config):
>           with pytest.raises(websockets.exceptions.InvalidStatusCode) as exc_info:
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/protocols/test_websocket.py:409: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

name = 'InvalidStatusCode'

    def __getattr__(name: str) -> Any:
        assert aliases is not None  # mypy cannot figure this out
        try:
            source = aliases[name]
        except KeyError:
            pass
        else:
            return import_name(name, source, namespace)
    
        assert deprecated_aliases is not None  # mypy cannot figure this out
        try:
            source = deprecated_aliases[name]
        except KeyError:
            pass
        else:
>           warnings.warn(
                f"{package}.{name} is deprecated",
                DeprecationWarning,
                stacklevel=2,
            )
E           DeprecationWarning: websockets.exceptions.InvalidStatusCode is deprecated

/gnu/store/82wl6nvqqkj48s4ixsx4hnvnm0mvxysx-python-websockets-15.0.1/lib/python3.11/site-packages/websockets/imports.py:86: DeprecationWarning
----------------------------- Captured stderr call -----------------------------
INFO:     Started server process [99]
INFO:     Uvicorn running on http://127.0.0.1:48715 (Press CTRL+C to quit)
INFO:     Shutting down
------------------------------ Captured log call -------------------------------
INFO     uvicorn.error:server.py:84 Started server process [99]
INFO     uvicorn.error:server.py:216 Uvicorn running on http://127.0.0.1:48715 (Press CTRL+C to quit)
INFO     uvicorn.error:server.py:264 Shutting down

It looks like uvicorn should be updated to avoid deprecation warnings when using the latest websockets?

[apteryks]

After disabling the deprecation warning using Pytest "-W" "ignore::DeprecationWarning", I still see some failures like:

_ test_send_binary_data_to_server_bigger_than_default_on_websockets[httptools-max=defaults sent=defaults+1] _
[gw6] linux -- Python 3.11.14 /gnu/store/76vhpdf5vc4rvr1rbcd0p0ycj0npjypb-python-wrapper-3.11.14/bin/python

http_protocol_cls = <class 'uvicorn.protocols.http.httptools_impl.HttpToolsProtocol'>
client_size_sent = 16777217, server_size_max = 16777216, expected_result = 1009
unused_tcp_port = 46079

    @pytest.mark.parametrize(
        "client_size_sent, server_size_max, expected_result",
        [
            (MAX_WS_BYTES, MAX_WS_BYTES, 0),
            (MAX_WS_BYTES_PLUS1, MAX_WS_BYTES, 1009),
            (10, 10, 0),
            (11, 10, 1009),
        ],
        ids=[
            "max=defaults sent=defaults",
            "max=defaults sent=defaults+1",
            "max=10 sent=10",
            "max=10 sent=11",
        ],
    )
    async def test_send_binary_data_to_server_bigger_than_default_on_websockets(
        http_protocol_cls: HTTPProtocol,
        client_size_sent: int,
        server_size_max: int,
        expected_result: int,
        unused_tcp_port: int,
    ):
        class App(WebSocketResponse):
            async def websocket_connect(self, message: WebSocketConnectEvent):
                await self.send({"type": "websocket.accept"})
    
            async def websocket_receive(self, message: WebSocketReceiveEvent):
                _bytes = message.get("bytes")
                assert _bytes is not None
                await self.send({"type": "websocket.send", "bytes": _bytes})
    
        config = Config(
            app=App,
            ws=WebSocketProtocol,
            http=http_protocol_cls,
            lifespan="off",
            ws_max_size=server_size_max,
            port=unused_tcp_port,
        )
        async with run_server(config):
            async with websockets.client.connect(f"ws://127.0.0.1:{unused_tcp_port}", max_size=client_size_sent) as ws:
                await ws.send(b"\x01" * client_size_sent)
                if expected_result == 0:
                    data = await ws.recv()
                    assert data == b"\x01" * client_size_sent
                else:
>                   with pytest.raises(websockets.exceptions.ConnectionClosedError):
E                   Failed: DID NOT RAISE <class 'websockets.exceptions.ConnectionClosedError'>

tests/protocols/test_websocket.py:734: Failed
----------------------------- Captured stderr call -----------------------------
INFO:     Started server process [96]
INFO:     Uvicorn running on http://127.0.0.1:46079 (Press CTRL+C to quit)
INFO:     127.0.0.1:60972 - "WebSocket /" [accepted]
INFO:     connection open
INFO:     Shutting down
INFO:     connection closed
------------------------------ Captured log call -------------------------------
INFO     uvicorn.error:server.py:84 Started server process [96]
INFO     uvicorn.error:server.py:216 Uvicorn running on http://127.0.0.1:46079 (Press CTRL+C to quit)
INFO     uvicorn.error:websockets_impl.py:273 127.0.0.1:60972 - "WebSocket /" [accepted]
INFO     uvicorn.error:server.py:643 connection open
INFO     uvicorn.error:server.py:264 Shutting down
INFO     uvicorn.error:server.py:264 connection closed

[mtelka]

I'm facing the same issue. In my case it is uvicorn 0.39.0 with Python 3.9.25 and websockets 15.0.1.